Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3555235pxj; Tue, 15 Jun 2021 03:38:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwi+239x1ZdxuUJD3nKeR1coJMNNNnSRIjgipci+TzIBGbq6OtQrvF5CEwHabAaO9sKZe8d X-Received: by 2002:a05:6e02:ce:: with SMTP id r14mr16543139ilq.164.1623753493197; Tue, 15 Jun 2021 03:38:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623753493; cv=none; d=google.com; s=arc-20160816; b=jCHlGEClszsq4eTOvcnKGVsalVZ8FhMHhQUNr0mkIiP81DLOG5TQ3wHYxNmWPew65+ 3cG5tLDws1OjLs15av4RJu7pV9/hieK4fIIvk/TUog2Kc2LMTRDC4U1SyXL0zhDJ3tT7 fnevpYFZWOzjPcR8BRfQiVr+9YY21UkUyqDFI4CyVgVbngyfyIQ1xfFI3N1Hh1QmtP9p cNh+v0FtZupeU9INTWiBFO6KjF2FFffC1oEEas5LyboMkI4h6GID9KaCx4eltj8lC+WG TX7E2zM1kZWtxlEp9/gAyTsE+Amifw2arzhJDt9TBNh1PZIsxtPX9BtawyDO3W2b2czB eKZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=E4E+s3D3+4bovq58bDRtKTnzJl0tADNy2QmmvJf7UbY=; b=TGSATtc1+jQXkrULIhQjFJPI58N/MJH3EiN4+oEX+l8qGx+iaaqk/Yuda2gp/lTQt1 hcN/M63sB/EhVp4aAny/xJrbm47Zlf5AOJQcYW8tnDgcOXwc3EFwsGpjAxxnprSB78/C HUlIqSKvmx/gGKZjg6x/hRyTpdxXKT30Kmyvl4A8nkgFJg3U0aa/o0IVyhBCQG76Ymg6 KvAb2LAWHi4nxjbIJICMhPuBwinAOIt8oU1bYumrrUWJ7ML5EdrkVhqV588Cb4izC/YF qScJUiD1/52T3BUaZBQ8BOfUF4NYtQ+pYHwVreIhUPIk/bMs57y8AmX5LVAbHeroDIb2 0Z6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=kScl7BkT; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e7si10478406ilq.68.2021.06.15.03.38.00; Tue, 15 Jun 2021 03:38:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=kScl7BkT; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231803AbhFOKjy (ORCPT + 99 others); Tue, 15 Jun 2021 06:39:54 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:18652 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231785AbhFOKjw (ORCPT ); Tue, 15 Jun 2021 06:39:52 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1623753467; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=E4E+s3D3+4bovq58bDRtKTnzJl0tADNy2QmmvJf7UbY=; b=kScl7BkTqQJlZ2YBenZMM/afta1ypqzmFRAz2lbbWd4yhjSwWNmBBr1PI1IVWeNtL8SEnfQh oD0NU5niNgUbNYGG1KNgoKJXFQ/NyWBFN7uJv3MehojsWsu+Fi5/qilFDyoM5d28agWabOL9 c71SER4/YRvHCffF3Y/Cx3ucGIg= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-west-2.postgun.com with SMTP id 60c882f72eaeb98b5e3b3a0a (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 15 Jun 2021 10:37:43 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 5C4FCC4360C; Tue, 15 Jun 2021 10:37:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from tykki.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 12D0FC433F1; Tue, 15 Jun 2021 10:37:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 12D0FC433F1 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH -next] brcmfmac: Fix a double-free in brcmf_sdio_bus_reset From: Kalle Valo In-Reply-To: <20210601100128.69561-1-tongtiangen@huawei.com> References: <20210601100128.69561-1-tongtiangen@huawei.com> To: Tong Tiangen Cc: Arend van Spriel , Franky Lin , Hante Meuleman , Chi-hsien Lin , Wright Feng , Chung-hsien Hsu , "David S. Miller" , Jakub Kicinski , , , , , , Tong Tiangen User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-Id: <20210615103743.5C4FCC4360C@smtp.codeaurora.org> Date: Tue, 15 Jun 2021 10:37:43 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Tong Tiangen wrote: > brcmf_sdiod_remove has been called inside brcmf_sdiod_probe when fails, > so there's no need to call another one. Otherwise, sdiodev->freezer > would be double freed. > > Fixes: 7836102a750a ("brcmfmac: reset SDIO bus on a firmware crash") > Signed-off-by: Tong Tiangen > Reviewed-by: Arend van Spriel Patch applied to wireless-drivers-next.git, thanks. 7ea7a1e05c7f brcmfmac: Fix a double-free in brcmf_sdio_bus_reset -- https://patchwork.kernel.org/project/linux-wireless/patch/20210601100128.69561-1-tongtiangen@huawei.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches