Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3690012pxj; Tue, 15 Jun 2021 06:39:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzGR8mszWZPNfVUx2BxubZ0YPRKDOFqhMGNba+L4d7hAo8o2JuY7Ck9m5U5prqUMc4NarzJ X-Received: by 2002:a17:907:7b97:: with SMTP id ne23mr20620893ejc.499.1623764346554; Tue, 15 Jun 2021 06:39:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623764346; cv=none; d=google.com; s=arc-20160816; b=jTsb33NV4aHa/OxgKEc3KJlXeyT8g0OH1En9SijxsmdU4dD/q+ckIp1OHQyOHs2vvc cc9l8s605wQI3/3nbvC/p4R2foJhxyShBW6ndZbV/YBP1PsoTDT070xrGvRZTq3E3MtG jiT+MgEr75oEUARZRJLniM08CdSPIZ+LJTBbXPsD9WHsapCMkZttrc5Vd1SjnGWfDa21 h/Ap5JZsRzv6ehbijltgwIoT4aWa9liIRG/45vaudeA8hhaTc92iLf/jJ/wlXKjYKikP Lkqz8Wh/E2b8oRaUcZLo2SU43jKr7tIFI8wlJhRJVwvZ+f9Nn2h417IooZt8pdrHMKcE hm9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=S340EGtDPeniuZO5cIpMO34wHmxSREuBU32MD7QyPKA=; b=qh6SHh8lZFsp4YQOwxWoevtvIproRyCTnhZekM1eRZR9YZXLty1A5J/LUP5BGpN636 39Ku1dmGM6ygLEPvJjBvOAr8QQ/Dh78vDPJOB6T8pzzyGH6+m6RzdC3GTgpCdBRLo9LV 2KrYhwEwe0HS5ByHdUSjN24GYlVsGuCZnGPwKm+PEkX8bRhOcHr+9INBz6q+Lm7XjmdL Umywv34eneENMsXVFsUaTDu8fBoqV9STQeVJPQGvyL91W0bN/58+uCNAW+xNPdJkslbb zS1CFaji29PCJDp8M+13G1nlzrY7zRL7iHKETKW89dIIhj8vRV8o+RqJSRroQ5CFbi++ kgHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=pubRsAnO; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e11si12646166eds.608.2021.06.15.06.38.39; Tue, 15 Jun 2021 06:39:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=pubRsAnO; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231179AbhFONk2 (ORCPT + 99 others); Tue, 15 Jun 2021 09:40:28 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:35644 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231733AbhFONj2 (ORCPT ); Tue, 15 Jun 2021 09:39:28 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1623764244; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=S340EGtDPeniuZO5cIpMO34wHmxSREuBU32MD7QyPKA=; b=pubRsAnOk9w+tUAAfJItLVpk2xWyWgCl8pxIniWxSUC4ege00HUL9XW4NoDXhafsDKZl7yEF pB8yupxyHoSzQNoE+tCKUiQNaQ3ocuMU+C4G8Xt61xPg9+rHxSzOmWt7mvtA6VTbRBP04eCq 6hPIZtyJCVFIabr16T0VmqzLThk= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-east-1.postgun.com with SMTP id 60c8acf751f29e6bae33b28b (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 15 Jun 2021 13:36:55 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 4472CC4360C; Tue, 15 Jun 2021 13:36:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from tykki.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id C5D3EC4360C; Tue, 15 Jun 2021 13:36:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C5D3EC4360C Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] rtlwifi: 8821a: btcoexist: add comments to explain why if-else branches are identical From: Kalle Valo In-Reply-To: <20210506013738.5943-1-pkshih@realtek.com> References: <20210506013738.5943-1-pkshih@realtek.com> To: Ping-Ke Shih Cc: , User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-Id: <20210615133654.4472CC4360C@smtp.codeaurora.org> Date: Tue, 15 Jun 2021 13:36:54 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Ping-Ke Shih wrote: > The coexistence programmers preserve the same code of branches > intentionally to fine tune performance easier, because bandwidth and RSSI > strength are highly related to coexistence performance. The basic rule of > performance tuning is to assign most time slot to BT for realtime > application, and WiFi uses remaining time slot but don't lower than low > bound. > > Reported-by: Inigo Huguet > Signed-off-by: Ping-Ke Shih Patch applied to wireless-drivers-next.git, thanks. 924599d40792 rtlwifi: 8821a: btcoexist: add comments to explain why if-else branches are identical -- https://patchwork.kernel.org/project/linux-wireless/patch/20210506013738.5943-1-pkshih@realtek.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches