Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3714912pxj; Tue, 15 Jun 2021 07:10:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwDLXIFAFXvW416wRtGn4+WbAceKOkcur3dcliAOi/ga5YUD/UxYVzehcy7bpAtrTdPbGXk X-Received: by 2002:a50:eb8f:: with SMTP id y15mr23970259edr.285.1623766249013; Tue, 15 Jun 2021 07:10:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623766249; cv=none; d=google.com; s=arc-20160816; b=0ZIuO5oKhrDIFUZCMQzVBQ2TtXPLN89yg/6mQ4wyupfFgOseNv5tQDnUjYOsYEe2aW 0eKJg3Qnqsz7ZjiQOJRDNEGBFTNeOwQyeZ4ZclARduaWt6T6G/kiXy6xBQLZc53XTtuw tTwGx9t0MfP3wbYactz4aMhEfGwDmBurU4tFvyu3EDxyTpK+pfgpA4BwKBKzcNnpXhY5 zODHMlS8do7PRYBrNVrKWeWndQSof5a1H3/66ov0RQF8nKFOECF2t3cFXgXe3jpAyOHe qQVaruEUO++PsllgYD1daqZNNZed+XYIxAVjI4/a/StF3Cn9cf+oEe3jfAEgE21Mw/xl 6MPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=bL2RsfZYXAV0vII8L/w93w8CwK5JzCrsqfTfhYDVCas=; b=rVbumleZTLOTTQQ6+oF5WYQln8BrLsHDT3JqqSjTrXiFHJqW2jiluMboxIlNo19HOz qC64T0mCkFROfb5k9V6CZVR6D426BJDKLpjfCJhCtCXvO4bDnDtchlNeJhhIJWTBzyAd Fh6bR+o6cIqkMk4flIRnL0Q3Danjg5Qi8nM/w9s+G+XxCug88BHLMWgyoO8VB8QSxqZ8 l/icit9/NSbkvvojSQlk4upQ5gS+hu+3ypnPiQHvEUo378Vr3RaF7dXqTDMvQQMAQqgU Z6So9XienGIV8EGnTzON8nzyPJXMgv/ag1/WgJFHIX9khBTns/ytrYEbR8scm3GOoG9H PRyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=SiOvuwRR; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g4si15167008ejj.325.2021.06.15.07.10.21; Tue, 15 Jun 2021 07:10:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=SiOvuwRR; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230076AbhFOOKI (ORCPT + 99 others); Tue, 15 Jun 2021 10:10:08 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:21475 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230211AbhFOOKI (ORCPT ); Tue, 15 Jun 2021 10:10:08 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1623766083; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=bL2RsfZYXAV0vII8L/w93w8CwK5JzCrsqfTfhYDVCas=; b=SiOvuwRRsIriVzMBlXEdptp4RwmBsGRbzfwNm1ZkiF52AP3v8D8ZTX29gC53fZnJVOe21bDZ JXi71KxWQnvbVpj2A1mQ8PPNWsnnJusFwuq7cS5MtaFw8wqre7hDQTSdtT9T6iydEHS0xEY7 2UqZ8JkfdtQsaP5c3wvQ6YT1b1o= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-east-1.postgun.com with SMTP id 60c8b3f9e27c0cc77f5492e9 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 15 Jun 2021 14:06:49 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id C5755C43146; Tue, 15 Jun 2021 14:06:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from tykki.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id B6DB3C433F1; Tue, 15 Jun 2021 14:06:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B6DB3C433F1 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wil6210: remove erroneous wiphy locking From: Kalle Valo In-Reply-To: <20210426212929.83f1de07c2cd.I630a2a00eff185ba0452324b3d3f645e01128a95@changeid> References: <20210426212929.83f1de07c2cd.I630a2a00eff185ba0452324b3d3f645e01128a95@changeid> To: Johannes Berg Cc: linux-wireless@vger.kernel.org, Harald Arnesen , Johannes Berg User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-Id: <20210615140648.C5755C43146@smtp.codeaurora.org> Date: Tue, 15 Jun 2021 14:06:48 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Johannes Berg wrote: > We already hold the wiphy lock in all cases when we get > here, so this would deadlock, remove the erroneous locking. > > Fixes: a05829a7222e ("cfg80211: avoid holding the RTNL when calling the driver") > Signed-off-by: Johannes Berg > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 8f78caa2264e wil6210: remove erroneous wiphy locking -- https://patchwork.kernel.org/project/linux-wireless/patch/20210426212929.83f1de07c2cd.I630a2a00eff185ba0452324b3d3f645e01128a95@changeid/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches