Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     Johannes Berg <johannes@sipsolutions.net>,
        Abinaya Kalaiselvan <akalaise@codeaurora.org>
Cc:     linux-wireless@vger.kernel.org
References: <1618483625-31097-1-git-send-email-akalaise@codeaurora.org>
 <f7ebb34a0c01b1652defa3929559997c9885c045.camel@sipsolutions.net>
From:   Nicolas Cavallari <Nicolas.Cavallari@green-communications.fr>
Subject: Re: [PATCHv2] mac80211: fix NULL ptr dereference during mesh peer
 connection for non HE devices
Message-ID: <717ff301-e29c-66d1-c0d7-5efd1b2415ba@green-communications.fr>
Date:   Tue, 15 Jun 2021 16:17:29 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <f7ebb34a0c01b1652defa3929559997c9885c045.camel@sipsolutions.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 19/04/2021 13:23, Johannes Berg wrote:
> On Thu, 2021-04-15 at 16:17 +0530, Abinaya Kalaiselvan wrote:
>> "sband->iftype_data" is not assigned with any value for non HE supported
>> devices, which causes NULL pointer access during mesh peer connection
>> in those devices. Fix this by accessing the pointer after HE
>> capabilities condition check.
>>
>> Fixes: 7f7aa94bcaf0 (mac80211: reduce peer HE MCS/NSS to own capabilities)
>> Signed-off-by: Abinaya Kalaiselvan <akalaise@codeaurora.org>
>> ---
>> v2:
>> * ieee80211_sta_he_cap structure instance is initialized.
>>
> How about taking other feedback into account?
> 
> johannes
> 

I got a crash because of this bug and this patch fixes it. Abinaya, do you plan 
to submit a version with the indentation fixed, or can I do it ?