Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210521024834.8354-1-yguoaz@cse.ust.hk> <20210615133102.7E774C43145@smtp.codeaurora.org>
In-Reply-To: <20210615133102.7E774C43145@smtp.codeaurora.org>
From:   Brian Norris <briannorris@chromium.org>
Date:   Tue, 15 Jun 2021 10:17:47 -0700
Message-ID: <CA+ASDXNQkZvnCezWS6Y7e7SPO-u+9fY23g4VVpHC-Z5HC55Nig@mail.gmail.com>
Subject: Re: [PATCH] mwifiex: protect against divide by zero in mwifiex_set_ibss_params
To:     Kalle Valo <kvalo@codeaurora.org>
Cc:     Yiyuan GUO <yguoaz@gmail.com>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        amit karwar <amitkarwar@gmail.com>,
        Ganapathi Bhat <ganapathi017@gmail.com>,
        Sharvari Harisangam <sharvari.harisangam@nxp.com>,
        Xinming Hu <huxinming820@gmail.com>,
        Yiyuan GUO <yguoaz@cse.ust.hk>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jun 15, 2021 at 6:31 AM Kalle Valo <kvalo@codeaurora.org> wrote:
>
> Yiyuan GUO <yguoaz@gmail.com> wrote:
>
> > In function mwifiex_set_ibss_params, the variable index may remain
> > zero if it is never altered inside the loop, leading to a potential
> > divide by zero problem.
> >
> > Signed-off-by: Yiyuan GUO <yguoaz@cse.ust.hk>
>
> Brian explains in the report why the code is ok:
> https://bugzilla.kernel.org/show_bug.cgi?id=212993#c1

Ah, forgot there was a patch for this too. FWIW, it's probably ok to
submit such a patch, if just for safety's sake (future refactoring?).
I just didn't figure it deserved an open "bug" entry, when it's
clearly not one.

> Patch set to Rejected.

That's fine with me.

Thanks,
Brian