Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1360187pxj; Fri, 18 Jun 2021 05:36:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx/khjCkDr9GXSLlF48eAz7MgzZfFsH4ql4OSqN3F1GpwYaouYuKAQbdjbgMGTsqiyYpYSS X-Received: by 2002:aa7:c7c7:: with SMTP id o7mr4718104eds.231.1624019818151; Fri, 18 Jun 2021 05:36:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624019818; cv=none; d=google.com; s=arc-20160816; b=ZvehhBGgYttvqfYgWrBlVG+63TjhGbgim1Z4zPp1uoKJFNq//qWmsO9xX2UkvSjyh0 5jLUWQ0tKiA+eyyYtnHNxJ00uDwp1AZ9khuas81mCUy66FNmP/1Kyq9j83ZUHVQWKayp C21w+uoMIb1krJAbnAke+BLaPhzTDY6bL7mXUaiFppVzNb1E0e+cf+LrBCE4aCrhMJcK jbTC2Icx113HRl62YAF3gvM88iDCSnVs5zFHG5Yl0erLqP0V+8apG3RhrMQdZcSda/dg +3mQgzRnmu9BAsbkuE3iJoQNKPfSFgulGHa1mTNCGWxuQVXUdRVgo6JbzrsFbnQxDQUW vT1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:cc:to:from; bh=4hD2FALxkOw9SXollFfkgrL4C4+hm5McZJdrBIy8T80=; b=OThEwlu/LAIStezSs8sgNij7h7jfZIwYmvOmOx3ZBsApBpH9Raf1qp7LXzglFdk+GN c/Ozhi1ugr1iFmHR1N0gwwh2m9xEuE1tXZrGRFtxq2uE+B5mp87a09S5bYXTNAWaUmqo WBeThPP0ime8aE3r79q/1c14eVGRqUVfayZ2JZbKs8Vtby1KwfH47e62/bdvv+j8l7yx h5IdUbYpic6z2OHY1zczh6cR+UFwOvyKOzc/HIYl434WeI7pKZYntqKE1DZEe/6SZ10/ VCsFnYqnB3wbpFZcr2QgSf0XVVCd6qiLW/7o5GF9wWfDFDvNCLMZWWPtiFCrE4nUpyL9 EsDQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v10si2036492edc.300.2021.06.18.05.36.33; Fri, 18 Jun 2021 05:36:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229816AbhFRLDn (ORCPT + 99 others); Fri, 18 Jun 2021 07:03:43 -0400 Received: from paleale.coelho.fi ([176.9.41.70]:48260 "EHLO farmhouse.coelho.fi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229550AbhFRLDm (ORCPT ); Fri, 18 Jun 2021 07:03:42 -0400 Received: from 91-156-6-193.elisa-laajakaista.fi ([91.156.6.193] helo=kveik.lan) by farmhouse.coelho.fi with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1luBx4-001YXx-UW; Fri, 18 Jun 2021 13:42:20 +0300 From: Luca Coelho To: johannes@sipsolutions.net Cc: luca@coelho.fi, linux-wireless@vger.kernel.org Date: Fri, 18 Jun 2021 13:41:47 +0300 Message-Id: X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210618104156.747775-1-luca@coelho.fi> References: <20210618104156.747775-1-luca@coelho.fi> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Checker-Version: SpamAssassin 3.4.5-pre1 (2020-06-20) on farmhouse.coelho.fi X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, TVD_RCVD_IP autolearn=ham autolearn_force=no version=3.4.5-pre1 Subject: [PATCH 22/31] mac80211: improve AP disconnect message Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Johannes Berg If the AP changes capability/bandwidth in some fashion, the message might be somewhat misleading and we don't know what really changed. Modify the message to speak about "caps/bw" instead of just "bandwidth", and print out the flags. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho --- net/mac80211/mlme.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c index 5c58eae7ef4b..3eee75571650 100644 --- a/net/mac80211/mlme.c +++ b/net/mac80211/mlme.c @@ -444,8 +444,8 @@ static int ieee80211_config_bw(struct ieee80211_sub_if_data *sdata, IEEE80211_STA_DISABLE_160MHZ)) || !cfg80211_chandef_valid(&chandef)) { sdata_info(sdata, - "AP %pM changed bandwidth in a way we can't support - disconnect\n", - ifmgd->bssid); + "AP %pM changed caps/bw in a way we can't support (0x%x/0x%x) - disconnect\n", + ifmgd->bssid, flags, ifmgd->flags); return -EINVAL; } -- 2.32.0