Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C8D98C433F1
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Felix Fietkau <nbd@nbd.name>
Cc:     linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: pull request: mt76 2021-06-18
In-Reply-To: <3369c6a7-1fa5-7f9a-2d50-867d61dce304@nbd.name> (Felix Fietkau's
        message of "Fri, 18 Jun 2021 17:26:33 +0200")
References: <3369c6a7-1fa5-7f9a-2d50-867d61dce304@nbd.name>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
Date:   Fri, 18 Jun 2021 20:12:34 +0300
Message-ID: <87v96bhzb1.fsf@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Felix Fietkau <nbd@nbd.name> writes:

> Hi Kalle,
>
> here's an updated version of my first pull request for 5.14
>
> - Felix
>
> The following changes since commit 0c33795231bff5df410bd405b569c66851e92d4b:
>
>   Merge tag 'wireless-drivers-next-2021-06-16' of git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next (2021-06-16 12:59:42 -0700)
>
> are available in the Git repository at:
>
>   https://github.com/nbd168/wireless tags/mt76-for-kvalo-2021-06-18
>
> for you to fetch changes up to 6edc39a381a0842d6dd5dc073879fcaee08e9989:
>
>   mt76: mt7921: allow chip reset during device restart (2021-06-18 17:18:09 +0200)
>
> ----------------------------------------------------------------
> mt76 patches for 5.14
>
> * mt7915 MSI support
> * disable ASPM on mt7915
> * mt7915 tx status reporting
> * mt7921 decap offload
> * driver fixes
> * cleanups
> * mt7921 runtime power management improvements
> * testmode improvements/fixes
> * runtime PM improvements
>
> ----------------------------------------------------------------

Unfortunately I still see the sysfs warning:

drivers/net/wireless/mediatek/mt76/mt7915/init.c: In function 'mt7915_thermal_init':
drivers/net/wireless/mediatek/mt76/mt7915/init.c:138:17: warning: ignoring return value of 'sysfs_create_link' declared with attribute 'warn_unused_result' [-Wunused-result]
  138 |                 sysfs_create_link(&wiphy->dev.kobj, &cdev->device.kobj,
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  139 |                                   "cooling_device");
      |                                   ~~~~~~~~~~~~~~~~~

And s-o-b is missing in one commit:

Commit

  7c649aa4de81 ("mt76: move mt76_rates in mt76 module")

is missing a Signed-off-by from its committer.

I checked that I pulled the correct tag, and not the old one:

From https://github.com/nbd168/wireless
 * tag                         mt76-for-kvalo-2021-06-18 -> FETCH_HEAD

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches