Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2483365pxj; Sat, 19 Jun 2021 13:49:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzCHpUW+9KNnmyuHpAIIM2IR/GoFUmqMP0u7Fy2ukx0LmcLej9grtRgLZq+BzYSPL1UV2G7 X-Received: by 2002:a02:ccf2:: with SMTP id l18mr9696229jaq.128.1624135769776; Sat, 19 Jun 2021 13:49:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624135769; cv=none; d=google.com; s=arc-20160816; b=qflFOVPqxQ40SgDwiON4HZNVKWaxoMe0Mps7KcEIAMHoxcfP0jrmx5ZgTgYXvIH3bc f4grhAZwxubi1IuHVxYSC0nMyfkTf9leyJ5YbDjDvIKgTJPNAngOM6JLkuu7c2gByvEB BdKYKtKlf7RGATVye+nZ3NQHkRIrFfj1dPuWJloJ7ak/0Yt0mFMNRUsHL2aKX9NrgQvo xj5am9aMgXFeudywqBQEm+gz6DZV8KyagzN9RIGDq73MKFSnWQJgcVjGyiTeuo0P8rw6 5gbVkpuHi5PnnGhKIwzcex5ZzfmpPtOzNo/1u+CoHk1/CzgefCErqKJqWXjxgH+rQCUL W4UQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=qZdEzUdu8hPxMifGaG7fZdmhCERtDLp4vsc/oERsXdc=; b=jGxywDBh9vOm5yeoBt+dYp0Ni8i9Zz+h0bqHjpe+D28Ap4gkgfcfqnex/WOcG2qbki kbGIlFBqoDGUPiCJZIXsXIVpyvdWgZGC/fQdXKZs+T+JbcdygfiEjbWAA5pUhCLoU1l2 dQlzr82LHithUBThSyEdViXRYekKxxcrAwHLAcrISZ+xotiUml0TzCURZd1ZhTFDSynd eOAPMzNszaaDEF3PMhEe4CgETDaId4a2bZU1w/xwP9A7lVkV2tPKnBzt4HiUqDVtQv7a 69t6OCPiF4qVQ57PrhVtSuFpfD8ZjPzKz8c06kbBgQwPvuKhgNTq6z5IxVSfXpni5/rf 7UIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lp0kig9u; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q10si7240762ilu.60.2021.06.19.13.49.17; Sat, 19 Jun 2021 13:49:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lp0kig9u; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234939AbhFSSWP (ORCPT + 99 others); Sat, 19 Jun 2021 14:22:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:37786 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234084AbhFSSWP (ORCPT ); Sat, 19 Jun 2021 14:22:15 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CEAA2611CC; Sat, 19 Jun 2021 18:20:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624126803; bh=ZKhXwftqv7KArKaLN6vI2dd+fw17pOyafwVTwdNbS/s=; h=From:To:Cc:Subject:Date:From; b=lp0kig9uQ9upkHQsXHWtEURZuJNz8++WKARCZtbzAQT6uKutN3LX4o1uzuoxTFs3O SSs3PdTx80fM3KFRQ3jFviqmndwzmz4CNunBVryp7LgOrrbMV3mcOdK0u+/EGXj0fk iplKZ9bIqgXf/Bv4qPsbvwx3gpQ3Iw7iByjOw9w38BSIBhi9POpGvYKm351rMskOhd Swt8iHii68Ip0fUo8HOUb4EcRcgLI/8hYoMv19AnLLwZla8RuKaCYyQxY1bFBqH62l /qOt/FUocRsJ8lrscZRXJRgzimnggWgziDzHL6xhdvQzfg3yEMoRgMkp8kGBusmEWg wcHBAn67YwR0A== From: Lorenzo Bianconi To: nbd@nbd.name Cc: lorenzo.bianconi@redhat.com, linux-wireless@vger.kernel.org, sean.wang@mediatek.com, deren.wu@mediatek.com Subject: [PATCH] mt76: mt7921: avoid unnecessary spin_lock/spin_unlock in mt7921_mcu_tx_done_event Date: Sat, 19 Jun 2021 20:19:58 +0200 Message-Id: X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Do not grab the spinlock in mt7921_mcu_tx_done_event routine if not necessary. Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mt7921/mcu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c index 1819de869fdf..8e011214169c 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c @@ -534,9 +534,7 @@ mt7921_mcu_tx_done_event(struct mt7921_dev *dev, struct sk_buff *skb) mt7921_mcu_tx_rate_parse(mphy->mt76, &peer, &msta->stats.tx_rate, le16_to_cpu(event->tx_rate)); - - spin_lock_bh(&dev->sta_poll_lock); - break; + return; } spin_unlock_bh(&dev->sta_poll_lock); } -- 2.31.1