Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 22 Jun 2021 08:40:44 +0200
From:   Lorenzo Bianconi <lorenzo@kernel.org>
To:     sean.wang@mediatek.com
Cc:     lorenzo.bianconi@redhat.com, nbd@nbd.name, Soul.Huang@mediatek.com,
        YN.Chen@mediatek.com, Leon.Yen@mediatek.com, Deren.Wu@mediatek.com,
        km.lin@mediatek.com, robin.chiu@mediatek.com, ch.yeh@mediatek.com,
        posh.sun@mediatek.com, Eric.Liang@mediatek.com,
        Stella.Chang@mediatek.com, jemele@google.com, yenlinlai@google.com,
        linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] mt76: mt7921: add .set_sar_specs support
Message-ID: <YNGF7Bl2uP0SAnv9@lore-desk>
References: <YM8NBUZp+/97kiIH@lore-desk--annotate>
 <1624315331-16608-1-git-send-email-sean.wang@mediatek.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="gGYiClTCWJBu/p1R"
Content-Disposition: inline
In-Reply-To: <1624315331-16608-1-git-send-email-sean.wang@mediatek.com>
Precedence: bulk


--gGYiClTCWJBu/p1R
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

[...]
> >
> >I guess there is an use-after-free here since sar is freed at the end of=
 nl80211_set_sar_specs, right?
> >
>=20
> Nope, there is no use-after-free case happens here because frp->range jus=
t points to an entry of const struct cfg80211_sar_specs table, not the one =
created from nl80211_set_sar_specs.

ack, right. I misread the code.

Regards,
Lorenzo

>=20
> >Regards,
> >Lorenzo
> >
> >> +		frp->power =3D power;
> >> +	}
> >> +
> >> +	err =3D mt76_connac_mcu_set_rate_txpower(mphy);
> >> +
> >> +out:
> >> +	mt7921_mutex_release(dev);
> >> +
> >> +	return err;
> >> +}
> >> +
> >>  const struct ieee80211_ops mt7921_ops =3D {
> >>	.tx =3D mt7921_tx,
> >>	.start =3D mt7921_start,
> >> @@ -1209,4 +1253,5 @@ const struct ieee80211_ops mt7921_ops =3D {
> >>	.set_rekey_data =3D mt7921_set_rekey_data,  #endif /* CONFIG_PM */
> >>	.flush =3D mt7921_flush,
> >> +	.set_sar_specs =3D mt7921_set_sar_specs,
> >>  };
> >> --
> >> 2.25.1
> >>

--gGYiClTCWJBu/p1R
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCYNGF5wAKCRA6cBh0uS2t
rBhsAP95npOocHCGoicDiaIO8Uf1rLxnUf6RItP8GT8jhzI96wD9Grh9Tc8PSd/+
JGauE3SBfDXGS9Ey6tjP/AIhbplcdgY=
=rm2D
-----END PGP SIGNATURE-----

--gGYiClTCWJBu/p1R--