Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@redhat.com>
To:     Johannes Berg <johannes@sipsolutions.net>,
        linux-wireless@vger.kernel.org
Cc:     make-wifi-fast@lists.bufferbloat.net, Felix Fietkau <nbd@nbd.name>,
        Rajkumar Manoharan <rmanohar@codeaurora.org>,
        Kan Yan <kyan@google.com>, Yibo Zhao <yiboz@codeaurora.org>
Subject: Re: [PATCH mac80211-next v8] mac80211: Switch to a virtual
 time-based airtime scheduler
In-Reply-To: <e1798568decc6df9b44ce97f48be523bdc92bdc4.camel@sipsolutions.net>
References: <20210507094851.180838-1-toke@redhat.com>
 <e1798568decc6df9b44ce97f48be523bdc92bdc4.camel@sipsolutions.net>
Date:   Wed, 23 Jun 2021 11:27:16 +0200
Message-ID: <87tulpnd6z.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Johannes Berg <johannes@sipsolutions.net> writes:

> On Fri, 2021-05-07 at 11:48 +0200, Toke H=C3=B8iland-J=C3=B8rgensen wrote:
>> This switches the airtime scheduler in mac80211 to use a virtual time-ba=
sed
>
> Generally, we prefer <=3D72 columns in commit messages ... I started
> reformatting, but then your code also has a lot of places that go over
> 80 columns, so I gave up ... Can you please do that?

I thought the new limit was 100? :)

But sure, I can take a look and remove the unnecessary ones...

> Some refactoring, e.g. in sta_apply_parameters(), may also be in order.

Will take a look!

-Toke