Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <a2342a38a7fca26e0906057461f042981a94dad9.camel@sipsolutions.net>
Subject: Re: [PATCH] mac80211: Fix sw connection monitor and sw scan when
 STA is connected HE
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Pkshih <pkshih@realtek.com>
Cc:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Date:   Wed, 23 Jun 2021 15:00:01 +0200
In-Reply-To: <8f1524261420449d87b86e9067f3d74f@realtek.com>
References: <20210611030422.9608-1-pkshih@realtek.com>
         <072bfd8473ac4054a43818009e66a914@realtek.com>
         (sfid-20210611_052347_394259_CA96FBDB) <05835527eb79d7bad22b20247b351b82cc0776d3.camel@sipsolutions.net>
         <8f1524261420449d87b86e9067f3d74f@realtek.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 2021-06-23 at 12:49 +0000, Pkshih wrote:
> > -----Original Message-----
> > From: Johannes Berg [mailto:johannes@sipsolutions.net]
> > Sent: Wednesday, June 23, 2021 6:33 PM
> > To: Pkshih
> > Cc: linux-wireless@vger.kernel.org
> > Subject: Re: [PATCH] mac80211: Fix sw connection monitor and sw scan
> > when STA is connected HE
> > 
> > > Hi mac80211 team,
> > > 
> > > We are working on Realtek 11ax driver, rtw89, not being merged
> > > yet.
> > > This driver uses software connection monitor and software scan,
> > > like
> > > our 11ac driver rtw88,
> > > but we found these two functions don't work properly due to
> > > mac80211
> > > doesn't send
> > > null data frame when STA is connected HE.
> > > 
> > > We search for the reason why it can't send null frame, but we
> > > don't
> > > get the answer.
> > > Possibly, it is because existing HE hardware supports hardware
> > > connection monitor
> > > and scan, or supports TWT to avoid sending null data frame to tell
> > > AP
> > > its PS mode.
> > > Could anyone enlighten me the reason?
> > 
> > It was just a workaround for an iwlwifi specific issue that got left
> > in.
> > I just merged a patch from Felix to resolve that.
> > 
> 
> I check Felix's patch:
> https://patchwork.kernel.org/project/linux-wireless/patch/20210619101517.90806-1-nbd@nbd.name/
> 
> 
> I think we should revert the commit f39b07fdfb68 ("mac80211: HE STA
> disassoc due to QOS NULL not sent"),
> which fixes connection monitor due to QOS NULL not send.
> 

I agree, that makes sense.

> 
> Another place is ieee80211_send_null_response(); I'm not sure if we
> can remove
> the checking as well.

Yes, I think so.

Want to send patch(es) for that?

johannes