Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp5682050pxj; Wed, 23 Jun 2021 06:51:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyupOtOSkqXLTh7gbox3kgMdTzB7ZhTySIX19Bsi5f7PVrBnUhALiSLvpnkF3VT1r4QvoU1 X-Received: by 2002:a17:906:4b59:: with SMTP id j25mr70165ejv.511.1624456292930; Wed, 23 Jun 2021 06:51:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624456292; cv=none; d=google.com; s=arc-20160816; b=PFYS6uxkSK9G8YUeUgVVA+btjAcbUIPbnD2+DM4Kitw3bGsmDzybvfToZwc5/IGHoB 9l2+biqJI7G4fbqL/DUPgyAhIogkNrWnNIZ1FFp/CsQNv0VcnoYcRLb+vUwmJPT5zyTL itjFshmRpfWYuXd0b9wFhGd10Gu9/WStcBnJoLoGUsqn3NDhf7X+kXw/z2md2PosfmP6 xJxGlMq2B9Chj6SivYXGlssi/MxIszpThhp5asR4kFoh7Mb9b1NC1TbWOU5a6Eb60+5i oNu/+nyfHlh0m0S27i8zUpXgjbBfg25DfDneDAmbXwrVZxhBYsgUBFVNt4BuBgEosblD QK+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:authenticated-by; bh=Rk0j/lpP0cZGjSfR5+xTtk/GO+st0f5UzqSgrDEesmQ=; b=mCbIfcnrCjWNmSQkKiwOxKpTNKvxBgSY5iOvOxqtwdSh2Vs/pnmlHVHwzPsaRj4YJd im+g5js0iAkellf2FiGTiesv3GI1XwWVpEjb+S3PagxfLO4CcD6os/wMzUvIOFRY9IfN 4Ft+JDwE61cUVSApJNV4Jzjydj52rvhivZkxBh6rjRAchbuhCvhT5JHDAg5bNZmCXHeH tzRiPzCeI/u8ogvg9wCTxuBSs+q3m6aErv3aLjTlPkpi6XG7BoocgdLbiFQ6zM6wPd+R tYHkdEw6cmJ23UmA4404EVSauWRCiATQ8P7goqf210y1VqHTC2esLGSfRUuWIG1pGm/V RG9Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id yc25si17989634ejb.597.2021.06.23.06.51.06; Wed, 23 Jun 2021 06:51:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230286AbhFWNu5 (ORCPT + 99 others); Wed, 23 Jun 2021 09:50:57 -0400 Received: from rtits2.realtek.com ([211.75.126.72]:34998 "EHLO rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230274AbhFWNu4 (ORCPT ); Wed, 23 Jun 2021 09:50:56 -0400 Authenticated-By: X-SpamFilter-By: ArmorX SpamTrap 5.73 with qID 15NDmVHd9009732, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36502.realtek.com.tw[172.21.6.25]) by rtits2.realtek.com.tw (8.15.2/2.71/5.88) with ESMTPS id 15NDmVHd9009732 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Wed, 23 Jun 2021 21:48:31 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXH36502.realtek.com.tw (172.21.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 23 Jun 2021 21:48:30 +0800 Received: from localhost (172.16.16.17) by RTEXMBS04.realtek.com.tw (172.21.6.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 23 Jun 2021 21:48:30 +0800 From: Ping-Ke Shih To: CC: Subject: [PATCH 1/2] mac80211: remove iwlwifi specific workaround NDPs of null_response Date: Wed, 23 Jun 2021 21:48:25 +0800 Message-ID: <20210623134826.10318-1-pkshih@realtek.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [172.16.16.17] X-ClientProxiedBy: RTEXMBS02.realtek.com.tw (172.21.6.95) To RTEXMBS04.realtek.com.tw (172.21.6.97) X-KSE-ServerInfo: RTEXMBS04.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: trusted connection X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Deterministic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 06/23/2021 13:27:00 X-KSE-AttachmentFiltering-Interceptor-Info: no applicable attachment filtering rules found X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: =?big5?B?Q2xlYW4sIGJhc2VzOiAyMDIxLzYvMjMgpFWkyCAxMjowNjowMA==?= X-KSE-BulkMessagesFiltering-Scan-Result: protection disabled X-KSE-ServerInfo: RTEXH36502.realtek.com.tw, 9 X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: protection disabled X-KSE-AntiSpam-Outbound-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 5.9.20, Database issued on: 06/23/2021 13:24:27 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 0 X-KSE-AntiSpam-Info: Lua profiles 164583 [Jun 23 2021] X-KSE-AntiSpam-Info: Version: 5.9.20.0 X-KSE-AntiSpam-Info: Envelope from: pkshih@realtek.com X-KSE-AntiSpam-Info: LuaCore: 448 448 71fb1b37213ce9a885768d4012c46ac449c77b17 X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: 127.0.0.199:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;realtek.com:7.1.1 X-KSE-AntiSpam-Info: Rate: 0 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 06/23/2021 13:27:00 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Remove the remaining workaround that is not removed by the commit e41eb3e408de ("mac80211: remove iwlwifi specific workaround that broke sta NDP tx") Fixes: 41cbb0f5a295 ("mac80211: add support for HE") Signed-off-by: Ping-Ke Shih --- net/mac80211/sta_info.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c index 641a6657d0c9..e18c3855f616 100644 --- a/net/mac80211/sta_info.c +++ b/net/mac80211/sta_info.c @@ -1398,11 +1398,6 @@ static void ieee80211_send_null_response(struct sta_info *sta, int tid, struct ieee80211_tx_info *info; struct ieee80211_chanctx_conf *chanctx_conf; - /* Don't send NDPs when STA is connected HE */ - if (sdata->vif.type == NL80211_IFTYPE_STATION && - !(sdata->u.mgd.flags & IEEE80211_STA_DISABLE_HE)) - return; - if (qos) { fc = cpu_to_le16(IEEE80211_FTYPE_DATA | IEEE80211_STYPE_QOS_NULLFUNC | -- 2.25.1