Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: akalaise=codeaurora.org@mg.codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Wed, 23 Jun 2021 20:12:39 +0530
From:   Abinaya Kalaiselvan <akalaise@codeaurora.org>
To:     Nicolas Cavallari <Nicolas.Cavallari@green-communications.fr>
Cc:     Johannes Berg <johannes@sipsolutions.net>,
        linux-wireless@vger.kernel.org
Subject: Re: [PATCHv2] mac80211: fix NULL ptr dereference during mesh peer
 connection for non HE devices
In-Reply-To: <717ff301-e29c-66d1-c0d7-5efd1b2415ba@green-communications.fr>
References: <1618483625-31097-1-git-send-email-akalaise@codeaurora.org>
 <f7ebb34a0c01b1652defa3929559997c9885c045.camel@sipsolutions.net>
 <717ff301-e29c-66d1-c0d7-5efd1b2415ba@green-communications.fr>
Message-ID: <95cff90ba7d4b69fb71fd59d202c2d67@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk

On 2021-06-15 19:47, Nicolas Cavallari wrote:
> On 19/04/2021 13:23, Johannes Berg wrote:
>> On Thu, 2021-04-15 at 16:17 +0530, Abinaya Kalaiselvan wrote:
>>> "sband->iftype_data" is not assigned with any value for non HE 
>>> supported
>>> devices, which causes NULL pointer access during mesh peer connection
>>> in those devices. Fix this by accessing the pointer after HE
>>> capabilities condition check.
>>> 
>>> Fixes: 7f7aa94bcaf0 (mac80211: reduce peer HE MCS/NSS to own 
>>> capabilities)
>>> Signed-off-by: Abinaya Kalaiselvan <akalaise@codeaurora.org>
>>> ---
>>> v2:
>>> * ieee80211_sta_he_cap structure instance is initialized.
>>> 
>> How about taking other feedback into account?
>> 
>> johannes
>> 
> 
> I got a crash because of this bug and this patch fixes it. Abinaya, do
> you plan to submit a version with the indentation fixed, or can I do
> it ?

Thanks Nicolas. I have sent the updated patch with indentation fix.

Thanks,
Abinaya Kalaiselvan