Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <1d8645c19faf4c7aa759d8af3d4dfd993049daf4.camel@sipsolutions.net>
Subject: Re: [PATCH v10 4/4] mac80211: CSA on non-transmitting interfaces
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Aloka Dixit <alokad@codeaurora.org>
Cc:     linux-wireless@vger.kernel.org, John Crispin <john@phrozen.org>
Date:   Wed, 23 Jun 2021 18:03:09 +0200
In-Reply-To: <20210426190534.12667-5-alokad@codeaurora.org>
References: <20210426190534.12667-1-alokad@codeaurora.org>
         <20210426190534.12667-5-alokad@codeaurora.org>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2021-04-26 at 12:05 -0700, Aloka Dixit wrote:
> 
> +	if (sdata->vif.mbssid.flags & IEEE80211_VIF_MBSSID_TX) {
> +		struct ieee80211_sub_if_data *child;
> +
> +		wiphy_unlock(sdata->local->hw.wiphy);
> +		mutex_lock(&sdata->local->iflist_mtx);
> +		list_for_each_entry(child, &sdata->local->interfaces, list)
> +			if (child->vif.mbssid.parent == vif &&
> +			    ieee80211_sdata_running(child))
> +				ieee80211_queue_work(&child->local->hw,
> +						     &child->csa_finalize_work);
> +		mutex_unlock(&sdata->local->iflist_mtx);
> +		wiphy_lock(sdata->local->hw.wiphy);

Same here wrt. locking, but for queueing work it shouldn't matter?

johannes