Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <63d3f8ec9095031d5d6b1374f304a76c64a036f2.camel@sipsolutions.net>
Subject: Re: [PATCH] mac80211: add dependency for MAC80211_LEDS
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Liwei Song <liwei.song@windriver.com>, David <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        linux-wireless <linux-wireless@vger.kernel.org>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Thu, 24 Jun 2021 09:51:04 +0200
In-Reply-To: <20210624074956.37298-1-liwei.song@windriver.com>
References: <20210624074956.37298-1-liwei.song@windriver.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Thu, 2021-06-24 at 15:49 +0800, Liwei Song wrote:
> Let MAC80211_LEDS depends on LEDS_CLASS=IWLWIFI to fix the below warning:
> 
> WARNING: unmet direct dependencies detected for MAC80211_LEDS
>   Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=y] && (LEDS_CLASS [=m]=y || LEDS_CLASS [=m]=MAC80211 [=y])
>   Selected by [m]:
>   - IWLWIFI_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] && WLAN_VENDOR_INTEL [=y] && IWLWIFI [=m] && (LEDS_CLASS [=m]=y || LEDS_CLASS [=m]=IWLWIFI [=m]) && (IWLMVM [=m] || IWLDVM [=m])
> 
> Signed-off-by: Liwei Song <liwei.song@windriver.com>
> ---
>  net/mac80211/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/mac80211/Kconfig b/net/mac80211/Kconfig
> index 51ec8256b7fa..918a11fed563 100644
> --- a/net/mac80211/Kconfig
> +++ b/net/mac80211/Kconfig
> @@ -69,7 +69,7 @@ config MAC80211_MESH
>  config MAC80211_LEDS
>  	bool "Enable LED triggers"
>  	depends on MAC80211
> -	depends on LEDS_CLASS=y || LEDS_CLASS=MAC80211
> +	depends on LEDS_CLASS=y || LEDS_CLASS=MAC80211 || LEDS_CLASS=IWLWIFI

Eh, no. this is the wrong way around. If anything needs to be fixed,
then it must be in iwlwifi, not the generic core part.

johannes