Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A6040C4338A
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Emmanuel Grumbach <egrumbach@gmail.com>
Cc:     Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
        "Coelho\, Luciano" <luciano.coelho@intel.com>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        Ayala Beker <ayala.beker@intel.com>
Subject: Re: [PATCH v2 1/4] iwlwifi: mei: add the driver to allow cooperation with CSME
References: <20210621080159.12883-1-emmanuel.grumbach@intel.com>
        <87k0mmjaep.fsf@tynnyri.adurom.net>
        <CANUX_P2rdkaBpKV=RTkS9ffLR89hL1yqBHskRp_Vdu8hJVrshg@mail.gmail.com>
Date:   Thu, 24 Jun 2021 19:46:56 +0300
In-Reply-To: <CANUX_P2rdkaBpKV=RTkS9ffLR89hL1yqBHskRp_Vdu8hJVrshg@mail.gmail.com>
        (Emmanuel Grumbach's message of "Tue, 22 Jun 2021 16:39:00 +0300")
Message-ID: <87o8bvi51b.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Emmanuel Grumbach <egrumbach@gmail.com> writes:

> On Tue, Jun 22, 2021 at 4:32 PM Kalle Valo <kvalo@codeaurora.org> wrote:
>>
>> Emmanuel Grumbach <emmanuel.grumbach@intel.com> writes:
>>
>> > iwlmei is a driver that handles the communication with the
>> > Wireless driver of the CSME firmware.
>> > More details in the documentation included in this patch.
>>
>> A complicated new feature and just two sentences in the commit log? The
>> commit log should give a proper overview what the patch does and why.
>> This commit log really says to the reader "I don't care, find out
>> yourself".
>>
>> And being nice I did try to read few paragraphs from the patch but as I
>> didn't even see any explanation for CSME or SAP I gave up.
>>
>
> CSME stands for converged security and management engine.
> It is well known and has a driver in the kernel under drivers/misc/mei

It maybe well known to you but it's not for me, and I'm pretty sure I'm
not the only one. Remember that not everyone work for Intel and this is
a community project, so please write commit logs accordingly.

But I see that you submitted v3, good. I'm reading that right now.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches