Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp830586pxv; Thu, 24 Jun 2021 22:29:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxoKFP8mTNlM3HucOQquiEzamoosJEP+6E2cuiYDBKx8JdVoXiJw2XL0vLJmPY2hccix7QY X-Received: by 2002:a92:6d0b:: with SMTP id i11mr6230042ilc.160.1624598983602; Thu, 24 Jun 2021 22:29:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624598983; cv=none; d=google.com; s=arc-20160816; b=GxKW6Va8VOw0WUkl56Rc5DELLbONnmlVW/TzbTXtTtnGkf44WU8EPmmIYYuvCPO+wg Bxz5XkWsloLYNsAnOvP+gJn9lzqALkEixdZsfUO7bGgAZBYI4yMucyCbtY+1Ea91QHTX WtzbxGKvLQ0lrz/KxHKd/2G9KdjKw3KxvAIBRB9L0IfX7D5GD1G3D8Ej6ihIXQRuXdz1 hHztnwMD+TLwKSjdyza94JC1xHgkGJWRN9rZ5DtlwgSEGstrk3AZYYjxgPBZ0pe1MrRW KtircLVp6oFWFtE2Od5MBb4LMD7S+bsJfJfKL6u9SRSBmmnRhGQrXk8Lqw/2o3QDyc5F +51A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=uH4YEvmp5g7u93n9Dq2yTIhMcUrniJ3GekoEltOXyi0=; b=ikzulVWeGU1j/ClKB/eVg/f8LYmMXWER5nK/V+4Z0gRZ7qArKhHPyOFjge1rKXFYWK i/BOv1146rRrZzmp9E03BeIfcT046iWD7qEXXrlMj+PIFe4ylJNoybI2K4uX8zOhBPAt UVh2gjgtmNljDUiorH/45OZE5ySNsDw5X3V6rKCVWu5wIeWoZm+wuAlodbpprVKQ1oPP BdN3QqrxEV/tM5MfXTIEPlFS46k/yH+V4e364iLOKFCj74vSRkqYrfL7qfJyTbrip2S6 7VHbfilv3mTPrTaRCU+xY5g0OiR6+TK3jcQ/teYYP4H8N22fuQNN43C2FrYJ/FyWYUVf FmOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BWh1AVeR; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q24si5514017jav.15.2021.06.24.22.29.07; Thu, 24 Jun 2021 22:29:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BWh1AVeR; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233062AbhFYFbR (ORCPT + 99 others); Fri, 25 Jun 2021 01:31:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230192AbhFYFbR (ORCPT ); Fri, 25 Jun 2021 01:31:17 -0400 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D4C3C06175F for ; Thu, 24 Jun 2021 22:28:56 -0700 (PDT) Received: by mail-pg1-x52a.google.com with SMTP id t9so6657758pgn.4 for ; Thu, 24 Jun 2021 22:28:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=uH4YEvmp5g7u93n9Dq2yTIhMcUrniJ3GekoEltOXyi0=; b=BWh1AVeR7HY31dhsptuFMdXnjvMV7kDmH0Lm8NCVFqXNGL+U+OAstSLqLf0vzL5TjU kHw58AdDMDAB7aSROhCCVa/+zIfRC38hzdVbOGxcpuv+bn/EK0EM2v5yqM6nRlzAmWyt NPis4x1Gr58EuzqIeu467LxXh9f4xHabKX7auC1na/14Fk35yLXT2h+CPe4qfeWtuEtB w+WgYiN6z+euS54vuxzJvB1bIIjDDjFHSd1bEWy4R3bNzG1d5sSy2uqkHte5/OHwJtZe K7WO0jDr5hvADqUqxSZPHEGmW/UF2Su1D3czDqjWIMJ6DfjUSZWqOYsMaQLyYd2+ifcG FAEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=uH4YEvmp5g7u93n9Dq2yTIhMcUrniJ3GekoEltOXyi0=; b=fFKt7sgJJr4f24B8VSOBqi2fKiTR8e0LIztqR1wChCbHHz53vjioeyasDg+AgiJ9yU 4VOZfXSGoqOHzPjqfB+TT4sHWphy8BWRZqVL/HlzcoqpWLtRpZmBdjKI5ODcoteCFga6 Xi4lWRAbmrk6u1x7g24PkoFZLLsJv1xHKVAQYZS+14dpdAN4QlwGvx/Ggu+kC6K2zBcm ry7JJMQ808BymODG9I2r2A69vLOxfWCqU5N0Z3wLv/XcoWqFOX0GlHQ7iTiKJrR21qRv qQia6fwYyTtHgV/cxXUBq7vEa3G5CxvaWLThGBwFuiF05hgJo5NScNH2ygeqfl5gbjWZ wRYw== X-Gm-Message-State: AOAM531oIgQKxBiXnMTStgm9AUpDiN5c0X322je/p0BWNU+CU5C4hXIa vXWj9QlSzs5sRVGrWmZYqxNQ X-Received: by 2002:aa7:8684:0:b029:305:9474:6934 with SMTP id d4-20020aa786840000b029030594746934mr8533191pfo.45.1624598935313; Thu, 24 Jun 2021 22:28:55 -0700 (PDT) Received: from workstation ([120.138.13.204]) by smtp.gmail.com with ESMTPSA id g17sm4186329pfv.62.2021.06.24.22.28.52 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 24 Jun 2021 22:28:54 -0700 (PDT) Date: Fri, 25 Jun 2021 10:58:51 +0530 From: Manivannan Sadhasivam To: Bhaumik Bhatt Cc: linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org, jhugo@codeaurora.org, linux-kernel@vger.kernel.org, loic.poulain@linaro.org, linux-wireless@vger.kernel.org, kvalo@codeaurora.org, ath11k@lists.infradead.org Subject: Re: [PATCH v4 0/6] BHI/BHIe improvements for MHI power purposes Message-ID: <20210625052851.GF4974@workstation> References: <1620330705-40192-1-git-send-email-bbhatt@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1620330705-40192-1-git-send-email-bbhatt@codeaurora.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thu, May 06, 2021 at 12:51:39PM -0700, Bhaumik Bhatt wrote: > This patch series improves the power up behavior by allowing MHI host driver to > set BHI and/or BHIe offsets early on in the preparation phase and fail pre-power > up if offsets are not found or not within a limited MMIO region. This also > allows MHI host to clean up the offsets in the unprepare after power down phase. > > Going forward, controllers will be required to specify a reg_len field which > will be used to check whether the BHI/BHIe offsets are in range or not. > > This series has been tested on X86_64 architecture with the PCI generic driver > as controller and an SDX55 device. > Since there is a chance to send this series for 5.14, I've applied it now to mhi-next! Thanks, Mani > v4: > -Added reviewed-by tags > -Updated range check patch to include BHI/e offsets in the error message > > v3: > -Added reviewed-by tags > -Updated order of reg_len in mhi_controller structure documentation > > v2: > -Added reviewed-by tags > -Moved reg_len entry in mhi_controller structure to allow for a packed struct > > Bhaumik Bhatt (6): > bus: mhi: core: Set BHI/BHIe offsets on power up preparation > bus: mhi: core: Set BHI and BHIe pointers to NULL in clean-up > bus: mhi: Add MMIO region length to controller structure > ath11k: set register access length for MHI driver > bus: mhi: pci_generic: Set register access length for MHI driver > bus: mhi: core: Add range checks for BHI and BHIe > > drivers/bus/mhi/core/init.c | 61 ++++++++++++++++++++++++----------- > drivers/bus/mhi/core/pm.c | 28 +++------------- > drivers/bus/mhi/pci_generic.c | 1 + > drivers/net/wireless/ath/ath11k/mhi.c | 1 + > include/linux/mhi.h | 2 ++ > 5 files changed, 50 insertions(+), 43 deletions(-) > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >