Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp1870213pxv; Sat, 26 Jun 2021 02:52:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwWwDZ5XTx6leoxE4+0jAFwGGanGS4cQ/OY13AJBH4OuGoNlGvc5pTg+ZH/lc/rSaf0IM4y X-Received: by 2002:a17:906:b6c5:: with SMTP id ec5mr15321273ejb.290.1624701162830; Sat, 26 Jun 2021 02:52:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624701162; cv=none; d=google.com; s=arc-20160816; b=bDxTPu2XkVBxQKVBY23LwoG3ic1Iz4ZDfNKn2IRMA//sB7isV8f4G1gCVGFf+h0Vy9 inv5lhx4nDVXFRruEVzsSCHMvN0NyVIy0736DIXGjbudp2TLjLdhLO4g94C6KxvWr0xX Gr++957hIR5bIbN+cv+GlheAhONELgMOuEBIZ5GVMuvDZkNhIP/Dz2FE85zvGb4LSWR4 rMWqosGem5vz4Y3HEHbdKBFj7NPKNJQeeDx2sXeQFCoK1TUQDHQ4MvOkGmxICIiIIzm4 8WCAfyVZUsWxmauWG5PhbVKucvHbiP8bmgVS2tdY+EfZxVodJnT6Q+ESr9xJB+x2BiJv VSyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dmarc-filter:sender :dkim-signature; bh=cSDl8dR93NgooM2/ky6hGtUFG2ZSdKncVi+7WtxljEM=; b=EGt8TD3c3d9hlLPZqEijQhWggywfckS4YyLVT8Z38lQ9vXF10LBecmqEM4MobGW1Vz GKaUi9ZS5zzhIeOBqZoGiRX1lbv0WFg/ikiEUeqryGVT+Pmr7qKCqZPGmv0miGoy9z3T NJ/nWh480CyI88dOb2fIrAuZGVAYTFqH2mDhU7UL7sUvN2k2x8haoSaPbdBALJ4e7uIc fsLHAokb3lSdzSVfIxZjcuB8WkWqpVk3RNDgGJAGzc4N7vqvNHkSks25xNsg1OwOxvyg kONPxPrgGxHE3nwDOjCqUwBvKrZrQAD7zNXOJvzJhmqbcD4p+gagbCCMHfPpnqZjJfyK a3Uw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=S6761zFU; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b22si8773742edu.352.2021.06.26.02.52.20; Sat, 26 Jun 2021 02:52:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=S6761zFU; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229796AbhFZJqj (ORCPT + 99 others); Sat, 26 Jun 2021 05:46:39 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:29477 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229630AbhFZJqi (ORCPT ); Sat, 26 Jun 2021 05:46:38 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1624700656; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=cSDl8dR93NgooM2/ky6hGtUFG2ZSdKncVi+7WtxljEM=; b=S6761zFURdo78d9qvqBb27BgjheOk0bb7B5djm/IiR07+nl+lsQ6jVhW2AeTqT3R9fmx4OlI SbRLYWgKzbCeurNW91LQgkFHe4phZaJJMHY6bLIU5d7hgUlSgcCRdS7O8QTEuQTbUQBvW6eg g0ofCIBVevKRG8e6MslpRQfEyJQ= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-east-1.postgun.com with SMTP id 60d6f6ea7b2963a2823e3bde (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sat, 26 Jun 2021 09:44:10 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id E26F2C4323A; Sat, 26 Jun 2021 09:44:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from tykki (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1B83CC433F1; Sat, 26 Jun 2021 09:44:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1B83CC433F1 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Dan Carpenter Cc: Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Matthias Brugger , Shayne Chen , linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] mt76: mt7915: fix info leak in mt7915_mcu_set_pre_cal() References: Date: Sat, 26 Jun 2021 12:43:59 +0300 In-Reply-To: (Dan Carpenter's message of "Fri, 25 Jun 2021 17:58:54 +0300") Message-ID: <874kdlj6zk.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Dan Carpenter writes: > Zero out all the unused members of "req" so that we don't disclose > stack information. > > Fixes: 495184ac91bb ("mt76: mt7915: add support for applying pre-calibration data") > Signed-off-by: Dan Carpenter Felix, should I take this directly to wireless-drivers? If yes, please ack. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches