Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] mac80211: Reject zero MAC address in
 sta_info_insert_check()
To:     <johannes@sipsolutions.net>, <davem@davemloft.net>,
        <kuba@kernel.org>, <periyasa@codeaurora.org>
CC:     <linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20210626103856.19816-1-yuehaibing@huawei.com>
From:   YueHaibing <yuehaibing@huawei.com>
Message-ID: <41d9471d-a354-2a83-816a-46190fcc10da@huawei.com>
Date:   Sat, 26 Jun 2021 18:48:13 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <20210626103856.19816-1-yuehaibing@huawei.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Pls drop this.

On 2021/6/26 18:38, YueHaibing wrote:
> As commit 52dba8d7d5ab ("mac80211: reject zero MAC address in add station")
> said, we don't consider all-zeroes to be a valid MAC address in most places,
> so also reject it here.
> 
> Reported-by: syzbot+ef4ca92d9d6f5ba2f880@syzkaller.appspotmail.com
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  net/mac80211/sta_info.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c
> index f2fb69da9b6e..3a6887fc9160 100644
> --- a/net/mac80211/sta_info.c
> +++ b/net/mac80211/sta_info.c
> @@ -547,7 +547,7 @@ static int sta_info_insert_check(struct sta_info *sta)
>  		return -ENETDOWN;
>  
>  	if (WARN_ON(ether_addr_equal(sta->sta.addr, sdata->vif.addr) ||
> -		    is_multicast_ether_addr(sta->sta.addr)))
> +		    is_valid_ether_addr(sta->sta.addr)))
>  		return -EINVAL;
>  
>  	/* The RCU read lock is required by rhashtable due to
>