Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3C1DBC433D3
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Oleksij Rempel <o.rempel@pengutronix.de>
Cc:     Brian Norris <briannorris@chromium.org>,
        Ping-Ke Shih <pkshih@realtek.com>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        netdev@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH 04/24] rtw89: add debug files
In-Reply-To: <20210702175740.5cdhmfp4ldiv6tn7@pengutronix.de> (Oleksij
        Rempel's message of "Fri, 2 Jul 2021 19:57:40 +0200")
References: <20210618064625.14131-1-pkshih@realtek.com>
        <20210618064625.14131-5-pkshih@realtek.com>
        <20210702072308.GA4184@pengutronix.de>
        <CA+ASDXNjHJoXgRAM4E7TcLuz9zBmQkaBMuhK2DEVy3dnE-3XcA@mail.gmail.com>
        <20210702175740.5cdhmfp4ldiv6tn7@pengutronix.de>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
Date:   Mon, 05 Jul 2021 11:08:07 +0300
Message-ID: <87k0m5i3o8.fsf@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Oleksij Rempel <o.rempel@pengutronix.de> writes:

> On Fri, Jul 02, 2021 at 10:08:53AM -0700, Brian Norris wrote:
>> On Fri, Jul 2, 2021 at 12:23 AM Oleksij Rempel <o.rempel@pengutronix.de> wrote:
>> > On Fri, Jun 18, 2021 at 02:46:05PM +0800, Ping-Ke Shih wrote:
>> > > +#ifdef CONFIG_RTW89_DEBUGMSG
>> > > +unsigned int rtw89_debug_mask;
>> > > +EXPORT_SYMBOL(rtw89_debug_mask);
>> > > +module_param_named(debug_mask, rtw89_debug_mask, uint, 0644);
>> > > +MODULE_PARM_DESC(debug_mask, "Debugging mask");
>> > > +#endif
>> >
>> >
>> > For dynamic debugging we usually use ethtool msglvl.
>> > Please, convert all dev_err/warn/inf.... to netif_ counterparts
>> 
>> Have you ever looked at a WiFi driver?
>
> Yes. You can parse the kernel log for my commits.
>
>> I haven't seen a single one that uses netif_*() for logging.
>> On the other hand, almost every
>> single one has a similar module parameter or debugfs knob for enabling
>> different types of debug messages.
>> 
>> As it stands, the NETIF_* categories don't really align at all with
>> the kinds of message categories most WiFi drivers support. Do you
>> propose adding a bunch of new options to the netif debug feature?
>
> Why not? It make no sense or it is just "it is tradition, we never do
> it!" ? 
>
> Even dynamic printk provide even more granularity. So module parameter looks
> like stone age against all existing possibilities.

I'm all for improving wireless driver debugging features, but let's
please keep that as a separate thread from reviewing new drivers. I
think there are 4-5 new drivers in the queue at the moment so to keep
all this manageable let's have the review process as simple as possible,
please.

Using a module parameter for setting the debug mask is a standard
feature in wireless drivers so it shouldn't block rtw89. If we want a
generic debug framework for wireless drivers, an rfc patch for an
existing upstream wireless driver is a good way to get that discussion
forward.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches