Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp4537324pxv; Tue, 6 Jul 2021 03:25:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzU6DZhFm8hTOcp76X4iBo0e47bImxnVJwtke6GYQOH7KBpHXowPmFkXOc36o81bhpTjZi+ X-Received: by 2002:a92:360e:: with SMTP id d14mr13732564ila.106.1625567152839; Tue, 06 Jul 2021 03:25:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625567152; cv=none; d=google.com; s=arc-20160816; b=hDFNiu0ujru0oJZS5uQbVXEeQ1qizwiPtHNG0tPdo1VdboSI+O0MSLMDCqvCM4EDbh gracwVBP9XBSILnZxbDrsP1QASuzKEk+/YPS3jwhVir9Jk3giKZrJxk1M2qUjGL6ZFWy KLWUlr2Nbl4QLDp2rJ7n7u+LLu6TuyLb7tDabi3kuoFlnq4JXK4FR9i5dzWJalOO2q7Z dzpOz0UM7KHlfEtDQJX2J4FAnu4hIqqJPLabylcbzXAfaC7Iru/6fsgmvvh/uEvp+aFJ JSucID3vs0AQSEmG/YGIRjo/RrGeLHTKblYxX2P31peSycPaRhxJOr74UGYRPs3Aute9 fOtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:reply-to:in-reply-to:references:mime-version; bh=b5JX2HPSavuTBklTpMu5/hScRG3hMtnAhM7szifcVbg=; b=YwuWmTJSb11SmkGYzBc1v8DaBEhocOsJzzUS8IY6rE0UPja/3Ctg+1E1izDdzXZq/0 T/lxmr0rxKGG8suSpieuB2XfIpnVpQnIRx+oJq3Ee5/2dQdraqu3F8oO4grMxwyvwJ0H DOQmNE3FAc/GG7q2NIN5Ep5Q+oF/lrR9SKtcMsP09rEnULqqXgombYe1zjpBHZmve5St BjFAc2g/uHjHCnCexvA54dHhKh0pKioGz3CM6XW3khRvDG3odd5HiVqRkq8LH9jqGxLC aOb2klvXyrzD2S61tGV7UJOwpgsq33m5eSK0/Xd04NXekPX6oyyzG/g2N1fdsswo7v6p 8+OQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w10si5469452ilc.77.2021.07.06.03.25.39; Tue, 06 Jul 2021 03:25:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231426AbhGFK1z convert rfc822-to-8bit (ORCPT + 99 others); Tue, 6 Jul 2021 06:27:55 -0400 Received: from mail-lj1-f176.google.com ([209.85.208.176]:36467 "EHLO mail-lj1-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231208AbhGFK1r (ORCPT ); Tue, 6 Jul 2021 06:27:47 -0400 Received: by mail-lj1-f176.google.com with SMTP id a6so28460117ljq.3; Tue, 06 Jul 2021 03:25:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc:content-transfer-encoding; bh=QFd4cSgjRlNs6aAHRKVeotkaIh4ASKGZEfmqK4rh/rE=; b=oXNQLlxPzgnBZq3/xXAjJVT8XHqb1xY+dFLjzkWT1y3jEvKSxAghVIBui0SS6a3/bI JZZLaxGwN5E0qqqu3F52dhi5N1H5vrtZOP9aHdPX2DMetNZEmfn/IXnmKCMENmeqvxVw YgqdPrslv4mBqobeMwFnhkXmgD9xA9GBYU3Fs4ti/7H+9K5rHk6b7wA5EL/3Ouwlnwk+ OkgxiKe36VdwMjh2xWkkZ5iJmluttilYozIYYMklu0Q7vPWsivWcw82Vwqwrbsr2yiQ3 ZFATje5BAlbmuOoVIXYgGg0L4YauJEuN/pKobTxpqMGmYsEBtySNusGMe8oq7Vr7ZAZa 10Qg== X-Gm-Message-State: AOAM533P/ev3NzipRRn0DyIqrWWGF6yde0bCVt/BvIPLPwAijrmAcnl0 scuAgyK2Nte2lT2YQyrivglSSu4qYMlF7pRa X-Received: by 2002:a2e:92cd:: with SMTP id k13mr14417894ljh.282.1625567103983; Tue, 06 Jul 2021 03:25:03 -0700 (PDT) Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com. [209.85.208.182]) by smtp.gmail.com with ESMTPSA id v5sm156756lfr.299.2021.07.06.03.25.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jul 2021 03:25:03 -0700 (PDT) Received: by mail-lj1-f182.google.com with SMTP id a18so2239235ljk.6; Tue, 06 Jul 2021 03:25:03 -0700 (PDT) X-Received: by 2002:a2e:1409:: with SMTP id u9mr9759960ljd.94.1625567102788; Tue, 06 Jul 2021 03:25:02 -0700 (PDT) MIME-Version: 1.0 References: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de> In-Reply-To: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de> Reply-To: wens@csie.org From: Chen-Yu Tsai Date: Tue, 6 Jul 2021 18:24:51 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] bus: Make remove callback return void To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: Greg Kroah-Hartman , Sascha Hauer , linux-kernel , Russell King , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Geoff Levand , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , "Rafael J. Wysocki" , Len Brown , William Breathitt Gray , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Maxime Ripard , Jernej Skrabec , Alison Schofield , Vishal Verma , Ira Weiny , Ben Widawsky , Dan Williams , Dave Jiang , Vinod Koul , Stefan Richter , Sudeep Holla , Cristian Marussi , Wu Hao , Tom Rix , Moritz Fischer , Jiri Kosina , Benjamin Tissoires , Srinivas Pandruvada , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Alexander Shishkin , Wolfram Sang , Alexandre Belloni , Dmitry Torokhov , Samuel Iglesias Gonsalvez , Jens Taprogge , Johannes Thumshirn , Mauro Carvalho Chehab , Maxim Levitsky , Alex Dubov , Ulf Hansson , Lee Jones , Tomas Winkler , Arnd Bergmann , Jakub Kicinski , "David S. Miller" , Jon Mason , Allen Hubbe , Kishon Vijay Abraham I , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Bjorn Helgaas , Dominik Brodowski , Maximilian Luz , Hans de Goede , Mark Gross , Matt Porter , Alexandre Bounine , Ohad Ben-Cohen , Bjorn Andersson , Mathieu Poirier , "Martin K. Petersen" , Thorsten Scherer , Srinivas Kandagatla , Andy Gross , Mark Brown , Stephen Boyd , Michael Buesch , Sven Van Asbroeck , Johan Hovold , Alex Elder , Andreas Noever , Michael Jamet , Mika Westerberg , Yehezkel Bernat , Rob Herring , Jiri Slaby , Heikki Krogerus , "Michael S. Tsirkin" , Jason Wang , Kirti Wankhede , Alex Williamson , Cornelia Huck , Martyn Welch , Manohar Vanga , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Johannes Berg , Jaroslav Kysela , Takashi Iwai , Marc Zyngier , Tyrel Datwyler , Vladimir Zapolskiy , Samuel Holland , Qinglang Miao , Alexey Kardashevskiy , Kai-Heng Feng , Joey Pabalan , =?UTF-8?Q?Pali_Roh=C3=A1r?= , Adrian Hunter , Frank Li , Mike Christie , Bodo Stroesser , Hannes Reinecke , David Woodhouse , SeongJae Park , Julien Grall , linux-arm-kernel , linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-wireless , linux-sunxi@lists.linux.dev, linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev, "open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM" , linux1394-devel@lists.sourceforge.net, linux-fpga@vger.kernel.org, linux-input@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-i2c@vger.kernel.org, linux-i3c@lists.infradead.org, industrypack-devel@lists.sourceforge.net, Linux Media Mailing List , linux-mmc , netdev , linux-ntb@googlegroups.com, PCI , platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-scsi@vger.kernel.org, Linux-ALSA , linux-arm-msm , linux-spi@vger.kernel.org, linux-staging@lists.linux.dev, greybus-dev@lists.linaro.org, target-devel@vger.kernel.org, linux-usb , linux-serial@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, Jul 6, 2021 at 5:54 PM Uwe Kleine-König wrote: > > The driver core ignores the return value of this callback because there > is only little it can do when a device disappears. > > This is the final bit of a long lasting cleanup quest where several > buses were converted to also return void from their remove callback. > Additionally some resource leaks were fixed that were caused by drivers > returning an error code in the expectation that the driver won't go > away. > > With struct bus_type::remove returning void it's prevented that newly > implemented buses return an ignored error code and so don't anticipate > wrong expectations for driver authors. > > Signed-off-by: Uwe Kleine-König > --- > Hello, > > this patch depends on "PCI: endpoint: Make struct pci_epf_driver::remove > return void" that is not yet applied, see > https://lore.kernel.org/r/20210223090757.57604-1-u.kleine-koenig@pengutronix.de. > > I tested it using allmodconfig on amd64 and arm, but I wouldn't be > surprised if I still missed to convert a driver. So it would be great to > get this into next early after the merge window closes. > > I send this mail to all people that get_maintainer.pl emits for this > patch. I wonder how many recipents will refuse this mail because of the > long Cc: list :-) > > Best regards > Uwe > > drivers/bus/sunxi-rsb.c | 4 +--- Acked-by: Chen-Yu Tsai