Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp4552894pxv; Tue, 6 Jul 2021 03:52:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw9x144TD0CZzFnJSNUCzoHdSj8/WuavcvMx9wkQWgBzLAvDMSKeRg0ENZfVGJxVB8FL4+T X-Received: by 2002:a17:907:608c:: with SMTP id ht12mr2450442ejc.12.1625568735988; Tue, 06 Jul 2021 03:52:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625568735; cv=none; d=google.com; s=arc-20160816; b=uZb3P/8SOD2j+gri0l2CN9XfgDngmtbY37xxxE45rniRA5R8rEn3BQmUvrJOrRZ5Z9 YLGXS4pBtOBYMIPnN6kBHrSGe1TUw2i21LgEi1wYxRRrTJwjcqqKd5BnJL3YZsM5z1Ic oYr2qGri9d3UD6gzQe9BP89k1E3z9cy2kZd5YQGbYhOaHZOSwrgN5xzEIQLit1RquDJR QbMCkDEStsxSTzZaN6DgdpW6IGFvGRW8Rvzb4gh4Sz+pNpOHBIeEWkEjAFJ4/mX+JNio bE1MjXykt6R42nuLIQ64HpFO7RhObLh+Lzej18ExXVyD76lgy0c3R27sz0JudKF8V0FY FalA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=oqFeMs0t/tulKyivs9XdEykvS3IanrxD7xZ+q/IUdM8=; b=hBNHXXktPY0Bb/qY3Q2ROdpBfoD81MFHflITWPoMj6yaVHRpHLLURedr3slSpzPLOE z6AaDYJ9GSREAV5UJvupjcdb2sfjsL5nhQ4yHR53H7ymBR1A20Uga/aUrJpmWpPmy3ii nOBw1r6L+bxGgxWW5ftKEMQD8enmw7hHzb073BSB6eOnzGPAVBcTy07LdZqFUHVySD5h bQkFNVlaHbvprcmphP5OL2e9HnIens3TveXYJY3b4Dya0cF/2lMzxgubW9mj5RdQU6hK htQIpZC92eAzu9sVuGCl833VI6cPbPyY72fX0lmZfj4y74Xa9U0aFpJlypTO57Z0tDVa 9xuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XLBiGX+c; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f21si13774477ejj.567.2021.07.06.03.51.52; Tue, 06 Jul 2021 03:52:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XLBiGX+c; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231785AbhGFKwa (ORCPT + 99 others); Tue, 6 Jul 2021 06:52:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:46708 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231450AbhGFKwX (ORCPT ); Tue, 6 Jul 2021 06:52:23 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6A11E6113A; Tue, 6 Jul 2021 10:49:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625568584; bh=QakVDMCwjBt5tusk+4GnLyspONeoeI28ccgP32Kkl6Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XLBiGX+c23s7Hd4vl9BpJNl+HHlvfzXaPVrxwmNjZbEn3M/O+E2BBk+XwQO60Fx+h AGg3I9ZxntsVRKX9hKl3+llY2WPdIEmlFNvB047fUI1IK4JVxOEF4dF9gqmuEuGb+m YdZOAhq21BupqowkOvwPwtMAMl0LvNKX33WcPSHpRbL6TIhRCmu9lOkum3OF5ngTKK 9dqdoQWVX++wNeQLXO8JH9t41sX/NUE8HwM2MQno+iFQNi2V60qlJhNUGu7azofLM8 OVyn3cBQUkqlxFBpjSV6EjXVn4VMkYYJLp789FfNvMpAjh38hTrSLglIFeyVVqTb4s nT0/m/zLxXrsA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1m0idy-0003U8-8E; Tue, 06 Jul 2021 12:49:34 +0200 Date: Tue, 6 Jul 2021 12:49:34 +0200 From: Johan Hovold To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Greg Kroah-Hartman , kernel@pengutronix.de, linux-kernel@vger.kernel.org, Russell King , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Geoff Levand , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , "Rafael J. Wysocki" , Len Brown , William Breathitt Gray , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Alison Schofield , Vishal Verma , Ira Weiny , Ben Widawsky , Dan Williams , Dave Jiang , Vinod Koul , Stefan Richter , Sudeep Holla , Cristian Marussi , Wu Hao , Tom Rix , Moritz Fischer , Jiri Kosina , Benjamin Tissoires , Srinivas Pandruvada , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Alexander Shishkin , Wolfram Sang , Alexandre Belloni , Dmitry Torokhov , Samuel Iglesias Gonsalvez , Jens Taprogge , Johannes Thumshirn , Mauro Carvalho Chehab , Maxim Levitsky , Alex Dubov , Ulf Hansson , Lee Jones , Tomas Winkler , Arnd Bergmann , Jakub Kicinski , "David S. Miller" , Jon Mason , Allen Hubbe , Kishon Vijay Abraham I , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Dominik Brodowski , Maximilian Luz , Hans de Goede , Mark Gross , Matt Porter , Alexandre Bounine , Ohad Ben-Cohen , Bjorn Andersson , Mathieu Poirier , "Martin K. Petersen" , Thorsten Scherer , Srinivas Kandagatla , Andy Gross , Mark Brown , Stephen Boyd , Michael Buesch , Sven Van Asbroeck , Alex Elder , Andreas Noever , Michael Jamet , Mika Westerberg , Yehezkel Bernat , Rob Herring , Jiri Slaby , Heikki Krogerus , "Michael S. Tsirkin" , Jason Wang , Kirti Wankhede , Alex Williamson , Cornelia Huck , Martyn Welch , Manohar Vanga , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Johannes Berg , Jaroslav Kysela , Takashi Iwai , Marc Zyngier , Tyrel Datwyler , Vladimir Zapolskiy , Samuel Holland , Qinglang Miao , Alexey Kardashevskiy , Kai-Heng Feng , Joey Pabalan , Pali =?utf-8?B?Um9ow6Fy?= , Adrian Hunter , Frank Li , Mike Christie , Bodo Stroesser , Hannes Reinecke , David Woodhouse , SeongJae Park , Julien Grall , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-wireless@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev, dmaengine@vger.kernel.org, linux1394-devel@lists.sourceforge.net, linux-fpga@vger.kernel.org, linux-input@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-i2c@vger.kernel.org, linux-i3c@lists.infradead.org, industrypack-devel@lists.sourceforge.net, linux-media@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-ntb@googlegroups.com, linux-pci@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-scsi@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, linux-staging@lists.linux.dev, greybus-dev@lists.linaro.org, target-devel@vger.kernel.org, linux-usb@vger.kernel.org, linux-serial@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH] bus: Make remove callback return void Message-ID: References: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, Jul 06, 2021 at 11:50:37AM +0200, Uwe Kleine-König wrote: > The driver core ignores the return value of this callback because there > is only little it can do when a device disappears. > > This is the final bit of a long lasting cleanup quest where several > buses were converted to also return void from their remove callback. > Additionally some resource leaks were fixed that were caused by drivers > returning an error code in the expectation that the driver won't go > away. > > With struct bus_type::remove returning void it's prevented that newly > implemented buses return an ignored error code and so don't anticipate > wrong expectations for driver authors. > > Signed-off-by: Uwe Kleine-König > drivers/staging/greybus/gbphy.c | 4 +--- > drivers/usb/serial/bus.c | 4 +--- > include/linux/device/bus.h | 2 +- Acked-by: Johan Hovold