Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 7 Jul 2021 06:45:32 -0400
From:   Sasha Levin <sashal@kernel.org>
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        kernel test robot <lkp@intel.com>,
        Kees Cook <keescook@chromium.org>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 5.10 113/137] wireless: wext-spy: Fix
 out-of-bounds warning
Message-ID: <YOWFzFBGGqiYWsI6@sashalap>
References: <20210706112203.2062605-1-sashal@kernel.org>
 <20210706112203.2062605-113-sashal@kernel.org>
 <5da1f4fbdac533be3b753e54b43e2058ba270bc8.camel@sipsolutions.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <5da1f4fbdac533be3b753e54b43e2058ba270bc8.camel@sipsolutions.net>
Precedence: bulk

On Tue, Jul 06, 2021 at 04:08:09PM +0200, Johannes Berg wrote:
>On Tue, 2021-07-06 at 07:21 -0400, Sasha Levin wrote:
>> From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
>>
>> [ Upstream commit e93bdd78406da9ed01554c51e38b2a02c8ef8025 ]
>>
>> Fix the following out-of-bounds warning:
>>
>> net/wireless/wext-spy.c:178:2: warning: 'memcpy' offset [25, 28] from the object at 'threshold' is out of the bounds of referenced subobject 'low' with type 'struct iw_quality' at offset 20 [-Warray-bounds]
>
>For the record: while this clearly isn't harmful, there's almost
>basically no chance that the stable kernel will ever compile warning-
>free with -Warray-bounds, so there's not much point in backporting this
>patch.

While the warning is a non-issue, it wasn't clear if it fixes a real bug
or just silences the warning which is why I took it in.

-- 
Thanks,
Sasha