Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp263103pxv; Wed, 14 Jul 2021 03:28:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzfgI9VhgvpiYgvBtKYNW68ljwmd/+JHjsGPslLa/BsIH/Ht1N1lNCX5gwbctn0z0F9H3eM X-Received: by 2002:a05:6402:22cf:: with SMTP id dm15mr12490925edb.280.1626258485328; Wed, 14 Jul 2021 03:28:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626258485; cv=none; d=google.com; s=arc-20160816; b=REL3ckbA6wEElIGuUX2rOgPQO9SRymh5jKN5PZTeXQaH1IcySJjAcNowPAP5olrOWq xbQqDm8F5tqNG41bDH2aW4C+vx/icfZb12CE1KqXmueG55QLv3JWRh2BZJv6qO/ubW2G LRE3wsZY0dLaCw9eo2gSCo7ROShGgrKdHY0CoBqEJU5rvdvuizoeirUGi3JgqEP1Pk9u A3yaNPt9Mp5Q1EQYquBynsJ48KWKu28BcA8V06P3MVLABagY/tGYuynJuIktyLLXxLyx pYKTjTW29g67hheWLXIRap8+mmzYWG9U/cfngIuk/gqnnJ52tg46g9dqOnNAHY8bRCwt Ge2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=eIknNa3KAU6m4EoITUWdB5BbL4fnIW8+QONAn3OVfnc=; b=GitfXOZGs8qEexRXRnaHJZeWILSZSNiv4U/HXJ7Hv6uj9qIuw0yg1Dal6rky4iqVD0 Q9N25bXwpqBw34P12IE8KRDsR+dxUbi8HCVN2PVgBq7EH9qv8uJuBcIHk4v+MNFVffna 5VYTB5THIg7bpz0bPSkGE/fWnmQtMifgnFPoPKOIXmFV2+dmFtCffJzxy8ESELgO4448 v3TJFge7/1ACkHmKRF2ZtLzH2uHJzvpGzy/6DpRzv0gYzafinH49WApyRRr5urbU0SoS ACOyGR1By05nFXM+ugIfkfABLsbOixt5PRdljFLzpRwCdv2pXxqX616TbxTTT8jtPpWb atyg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p20si2144132ejr.572.2021.07.14.03.27.37; Wed, 14 Jul 2021 03:28:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239062AbhGNK37 (ORCPT + 99 others); Wed, 14 Jul 2021 06:29:59 -0400 Received: from foss.arm.com ([217.140.110.172]:32922 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230270AbhGNK3w (ORCPT ); Wed, 14 Jul 2021 06:29:52 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 354A311D4; Wed, 14 Jul 2021 03:27:00 -0700 (PDT) Received: from bogus (unknown [10.57.79.213]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2FF633F774; Wed, 14 Jul 2021 03:26:27 -0700 (PDT) Date: Wed, 14 Jul 2021 11:25:29 +0100 From: Sudeep Holla To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Greg Kroah-Hartman , kernel@pengutronix.de, Sudeep Holla , Alexander Shishkin , Alexandre Belloni , Alexandre Bounine , Alex Dubov , Alex Elder , Alex Williamson , Alison Schofield , Allen Hubbe , Andreas Noever , Andy Gross , Arnd Bergmann , Benjamin Herrenschmidt , Benjamin Tissoires , Ben Widawsky , Bjorn Andersson , Bjorn Helgaas , Bodo Stroesser , Boris Ostrovsky , Chen-Yu Tsai , Christian Borntraeger , Cornelia Huck , Cristian Marussi , Dan Williams , Dave Jiang , "David S. Miller" , David Woodhouse , Dexuan Cui , Dmitry Torokhov , Dominik Brodowski , Finn Thain , Florian Fainelli , Frank Li , Geert Uytterhoeven , Geoff Levand , Haiyang Zhang , Hannes Reinecke , Hans de Goede , Harald Freudenberger , Heikki Krogerus , Heiko Carstens , Helge Deller , Ira Weiny , Jakub Kicinski , "James E.J. Bottomley" , Jaroslav Kysela , Jason Wang , Jens Taprogge , Jernej Skrabec , Jiri Kosina , Jiri Slaby , Joey Pabalan , Johan Hovold , Johannes Berg , Johannes Thumshirn , Jon Mason , Juergen Gross , Julien Grall , Kai-Heng Feng , Kirti Wankhede , Kishon Vijay Abraham I , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , "K. Y. Srinivasan" , Lee Jones , Len Brown , Lorenzo Pieralisi , Manohar Vanga , Marc Zyngier , Mark Brown , Mark Gross , "Martin K. Petersen" , Martyn Welch , Mathieu Poirier , Matt Porter , Mauro Carvalho Chehab , Maxime Ripard , Maximilian Luz , Maxim Levitsky , Michael Buesch , Michael Ellerman , Michael Jamet , "Michael S. Tsirkin" , Mika Westerberg , Mike Christie , Moritz Fischer , Ohad Ben-Cohen , Pali =?utf-8?B?Um9ow6Fy?= , Paul Mackerras , Peter Oberparleiter , "Rafael J. Wysocki" , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Rich Felker , Rikard Falkeborn , Rob Herring , Russell King , "Russell King (Oracle)" , Samuel Holland , Samuel Iglesias Gonsalvez , SeongJae Park , Srinivas Kandagatla , Srinivas Pandruvada , Stefano Stabellini , Stefan Richter , Stephen Boyd , Stephen Hemminger , Sven Van Asbroeck , Takashi Iwai , Thomas Bogendoerfer , Thorsten Scherer , Tomas Winkler , Tom Rix , Tyrel Datwyler , Ulf Hansson , Vasily Gorbik , Vineeth Vijayan , Vinod Koul , Vishal Verma , Wei Liu , William Breathitt Gray , Wolfram Sang , Wu Hao , Yehezkel Bernat , Yoshinori Sato , YueHaibing , Yufen Yu , alsa-devel@alsa-project.org, dmaengine@vger.kernel.org, greybus-dev@lists.linaro.org, industrypack-devel@lists.sourceforge.net, kvm@vger.kernel.org, linux1394-devel@lists.sourceforge.net, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-cxl@vger.kernel.org, linux-fpga@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-i2c@vger.kernel.org, linux-i3c@lists.infradead.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-media@vger.kernel.org, linux-mips@vger.kernel.org, linux-mmc@vger.kernel.org, linux-ntb@googlegroups.com, linux-parisc@vger.kernel.org, linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-serial@vger.kernel.org, linux-sh@vger.kernel.org, linux-spi@vger.kernel.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, nvdimm@lists.linux.dev, platform-driver-x86@vger.kernel.org, sparclinux@vger.kernel.org, target-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, Johannes Thumshirn , "Rafael J . Wysocki" Subject: Re: [PATCH v4 5/5] bus: Make remove callback return void Message-ID: <20210714102529.ehwquc2s2qlbccyg@bogus> References: <20210713193522.1770306-1-u.kleine-koenig@pengutronix.de> <20210713193522.1770306-6-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210713193522.1770306-6-u.kleine-koenig@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, Jul 13, 2021 at 09:35:22PM +0200, Uwe Kleine-K?nig wrote: > The driver core ignores the return value of this callback because there > is only little it can do when a device disappears. > > This is the final bit of a long lasting cleanup quest where several > buses were converted to also return void from their remove callback. > Additionally some resource leaks were fixed that were caused by drivers > returning an error code in the expectation that the driver won't go > away. > > With struct bus_type::remove returning void it's prevented that newly > implemented buses return an ignored error code and so don't anticipate > wrong expectations for driver authors. > [...] > diff --git a/drivers/firmware/arm_scmi/bus.c b/drivers/firmware/arm_scmi/bus.c > index 784cf0027da3..2682c3df651c 100644 > --- a/drivers/firmware/arm_scmi/bus.c > +++ b/drivers/firmware/arm_scmi/bus.c > @@ -116,15 +116,13 @@ static int scmi_dev_probe(struct device *dev) > return scmi_drv->probe(scmi_dev); > } > > -static int scmi_dev_remove(struct device *dev) > +static void scmi_dev_remove(struct device *dev) > { > struct scmi_driver *scmi_drv = to_scmi_driver(dev->driver); > struct scmi_device *scmi_dev = to_scmi_dev(dev); > > if (scmi_drv->remove) > scmi_drv->remove(scmi_dev); > - > - return 0; > } > > static struct bus_type scmi_bus_type = { Acked-by: Sudeep Holla -- Regards, Sudeep