Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp683638pxv; Wed, 14 Jul 2021 13:00:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz+msP6y6NhRbtAxk42vpbDO6Yg0iG6744HKYiBrAhpfqaMik8Qlctf709pSpbbQMcVwlJK X-Received: by 2002:a02:a595:: with SMTP id b21mr6545jam.122.1626292850365; Wed, 14 Jul 2021 13:00:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626292850; cv=none; d=google.com; s=arc-20160816; b=g3dMSUyyNnRkVPmGtChCIoW7fKj+2Y8NQqZ51Vv/hfJm5h+92xYyDwNXE88v5YSJ/A SuGTAsjRIEpUXs3NEe13nHzj1wLFJseYnH2Uog/23ChsuNW86D4Wy16YnPCQlQiu4oRv 7xsp4IAPETFOomJs+dRbsfI2/vp1DkJiSAGeoILnnqSmD2cyTTAiztOsanotgjym8s9D BrsImyMfAFlVkWSZ9Yzlfnd65ZKFhLjZU5BTpufbZTByspPtWrAW6OQiZw22LA0dLLdG grttbcV6nnLbDqAXsBm/dBinZAwlABrBdmhAimVdPEgXyfS5IATHeRrkF0EQZ5zkiYgH FT9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id:dkim-signature; bh=X3NTtRZZfavq8tUwtnJa4YEwGxb8+reN+LzCH02gIG4=; b=embiOPakWBUequoyJuZmKjaDKpS6Rw3luSwadKL/6MjuIFPa8nIGpB101RleRIclgF NAJXlP6WhQWADYkEVnim6gDRaVcndNQwlzpfZXZatpocUTxRBJmtWaOpE8jCHwB+iwMe HSIcQ/lKrC+O88nl1tNwFBxEQR/Ap33aw10Ct2i6ocBXpKihesZ02KYAHhuX8jB49Pgf T1yQKlPEAazz23x3A8eOqr+25C2ZnPEDu7zFL3xLhWE6lkxGvs7qYQQ4+HDfJa0ZjYxf BwupMq5pTTffQMykA5ZFjAd9Fotl8sN45ib1zlSW6+WyvLj5FSlkyK1C4jrcFXAUeh2+ fZ2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=hF1sD1lk; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t9si3735551jaj.20.2021.07.14.13.00.31; Wed, 14 Jul 2021 13:00:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=hF1sD1lk; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237065AbhGNUCE (ORCPT + 99 others); Wed, 14 Jul 2021 16:02:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241145AbhGNT5y (ORCPT ); Wed, 14 Jul 2021 15:57:54 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D478C0613EF for ; Wed, 14 Jul 2021 12:48:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=X3NTtRZZfavq8tUwtnJa4YEwGxb8+reN+LzCH02gIG4=; t=1626292100; x=1627501700; b=hF1sD1lkdCk+cSPKmcTK72vDnnWXu22oU3ISiCiRP+mDedJ 7Er5GcwVr2Jgpowed3kDqxs/4+lK7icIzBTvh/dbJNTV1Vi4jpmu7VGXFVkHp/pWMdYHjafrtJaW+ fy5DORwUjaxgceBEw11P7aqVAcgq1FGI75tOavWSY/1A9dUeN5B/J4VX8xaaXZnlayaemf0wboDxX PhQTe+kuJClHmr1OFS9Cj8e32TsDOfNaF4S9RLL0InebA77czwawBcg7RO1cfAWKrwEHEybwVyYHi IhTojMw1h65zTgu2g5s1yHQlOG/nlfuw4XWw1arrJ+LvXVUkgnjIZssfs151j7VA==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1m3krd-002Jd6-EI; Wed, 14 Jul 2021 21:48:13 +0200 Message-ID: Subject: Re: [PATCH] mt76: mt7915: fix endianness warnings in mu radiotap From: Johannes Berg To: Ryder Lee , Felix Fietkau Cc: Lorenzo Bianconi , Shayne Chen , Evelyn Tsai , linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org Date: Wed, 14 Jul 2021 21:48:12 +0200 In-Reply-To: <042666b307b7a424680bd20b6ac3bd3a74e3a1f7.1626291427.git.ryder.lee@mediatek.com> References: <042666b307b7a424680bd20b6ac3bd3a74e3a1f7.1626291427.git.ryder.lee@mediatek.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org > > - he_mu->ru_ch1[0] = FIELD_GET(MT_CRXV_HE_RU0, cpu_to_le32(rxv[3])); > + he_mu->ru_ch1[0] = FIELD_GET(MT_CRXV_HE_RU0, le32_to_cpu(rxv[3])); Instead of FIELD_GET(MASK, le32_to_cpu(value)) you should probably consider le32_get_bits(value, MASK) (not really sure why the order of arguments got inverted though ...) We might even consider doing an spatch to get rid of all the FIELD_GET() I guess. johannes