Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 15 Jul 2021 05:59:46 +0200
From:   Oleksij Rempel <o.rempel@pengutronix.de>
To:     Pkshih <pkshih@realtek.com>
Cc:     "kvalo@codeaurora.org" <kvalo@codeaurora.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 14/24] rtw89: 8852a: add 8852a RFK files
Message-ID: <20210715035946.7l4gldk32mdcahk4@pengutronix.de>
References: <20210618064625.14131-1-pkshih@realtek.com>
 <20210618064625.14131-15-pkshih@realtek.com>
 <20210709174112.GC2099@pengutronix.de>
 <b752f356a4ee482ca21db867dc7254b2@realtek.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <b752f356a4ee482ca21db867dc7254b2@realtek.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Precedence: bulk

On Thu, Jul 15, 2021 at 03:33:47AM +0000, Pkshih wrote:
> 
> > -----Original Message-----
> > From: Pkshih
> > Sent: Monday, July 12, 2021 2:24 PM
> > To: 'Oleksij Rempel'
> > Cc: kvalo@codeaurora.org; linux-wireless@vger.kernel.org
> > Subject: RE: [PATCH 14/24] rtw89: 8852a: add 8852a RFK files
> > 
> 
> [...]
> 
> > 
> > > > +	rtw89_debug(rtwdev, RTW89_DBG_TSSI, "[TSSI] %s: phy=%d\n",
> > > > +		    __func__, phy);
> > > > +
> > > > +	if (!rtwdev->is_tssi_mode[RF_PATH_A])
> > > > +		return;
> > > > +	if (!rtwdev->is_tssi_mode[RF_PATH_B])
> > > > +		return;
> > > > +
> > > > +	_tssi_disable(rtwdev, phy);
> > > > +
> > > > +	for (i = RF_PATH_A; i < RF_PATH_NUM_8852A; i++) {
> > > > +		_tssi_rf_setting(rtwdev, phy, i);
> > > > +		_tssi_set_sys(rtwdev, phy);
> > > > +		_tssi_set_tmeter_tbl(rtwdev, phy, i);
> > > > +		_tssi_pak(rtwdev, phy, i);
> > > > +	}
> > > > +
> > > > +	_tssi_enable(rtwdev, phy);
> > > > +	_tssi_set_efuse_to_de(rtwdev, phy);
> > > > +}
> > > > +
> > > > +void rtw8852a_tssi_track(struct rtw89_dev *rtwdev)
> > > > +{
> > > > +	_tssi_track(rtwdev);
> > > > +}
> > >
> > > rtw8852a_tssi_track() is not used
> > >
> > 
> > I'll check TSSI owner.
> > Will remove it if we don't need it, or call it if necessary.
> > 
> 
> I have confirmed with TSSI owner; we'll call it from rtw8852a_rfk_track().
> Thanks for the catch.

Sounds good :)

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |