Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp611419pxv; Thu, 15 Jul 2021 11:29:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyqg8R+AEy3LzKKEL4uTj/iRwhYNDuMQKeVF275lvMudJvxeZPoSv+vdI+c4pZZh6qx55QE X-Received: by 2002:a02:cd0a:: with SMTP id g10mr5174379jaq.18.1626373744959; Thu, 15 Jul 2021 11:29:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626373744; cv=none; d=google.com; s=arc-20160816; b=1Bl2LQFR01gtZRet1IOzwQ2ckFpsH77kUDmkqoB2tBBTjCenvS6nqLLsQdTXPtsuia 4rDmNlUxu71FAFDFzl3jc/ZqJOsT2gYd9w5HADNBiTrjutRFZ1JpE8apf8iuD6ahjoL3 Vak3FVi8Zzq0WqtWW2J/t+2ZKQpC7Mw0Mp+6vfZk6gUJUyUvIA7u+DfIyXOpWhEBzwLK xuounvR1hK/CDfNvUDGOIWTLlveLljaX9mwYcR6B7WjhL1GdhJjFuHjPFXX2IttgixEQ dB8UkgAVc9NunE5AP2IMu0VGj0N9Fz1DsuyNIH1HwpH1lTgyNeEBf+/gGp8a4yBbOsjr H8Bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:subject:from :references:cc:to:dkim-signature; bh=KSx2asI5pX+mS3gCmaVT617vwX5KrFoBd1JmsZKmIHg=; b=T92wdMiUrXIoyIXov982j2Y57czvzyHv+cTlb4R4+YgYbSv20Gy5Xrn87SnsJi2xCy 8uAU5914dOwhBysWyMnfM9Ai9evz6GEvNK1CREBkY9akQn8FwBCT1b+tIHkCXw0XQ5gB MuqxdQq9vcozmig3ow+atR0RaPMyvNy1JtARMsBR9VCGkd2/MxkwpfoG2AumgM0mz1X/ ZEX0oMkX4V//fXTjvDz6nPsnQXnck4omOQEyi/5zgaca712Byq4nlyA3Pak6mjl6QnDs AOlznKp5jYUqrwK45+rNliOve+AERdftfpC+V2/QNik/k57kXwnHdX5gvnRemj8+XhBa sq8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=NuON8Nz2; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q7si7686278ioi.41.2021.07.15.11.28.48; Thu, 15 Jul 2021 11:29:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=NuON8Nz2; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232890AbhGOSMM (ORCPT + 99 others); Thu, 15 Jul 2021 14:12:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231970AbhGOSML (ORCPT ); Thu, 15 Jul 2021 14:12:11 -0400 Received: from nbd.name (nbd.name [IPv6:2a01:4f8:221:3d45::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C815C06175F for ; Thu, 15 Jul 2021 11:09:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:Subject:From:References:Cc:To:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KSx2asI5pX+mS3gCmaVT617vwX5KrFoBd1JmsZKmIHg=; b=NuON8Nz2WdXWPVA/dMdLz/x1j/ wnV+X7HVQjZ7p4V5R7osU17F4HsGxCdqXhDIKlgw9UEOvUypR0+lI66SNXOO3VbYWZz6oTZThavzP 0tkyNn9dxyqgO0EEX5XuTck6B17+C05QzdLfNOAGy5++N9NY9pdzYU7tZ15A9BKE+JpI=; Received: from p54ae93f7.dip0.t-ipconnect.de ([84.174.147.247] helo=nf.local) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1m45nO-0007Qh-7H; Thu, 15 Jul 2021 20:09:14 +0200 To: sean.wang@mediatek.com, lorenzo.bianconi@redhat.com Cc: Soul.Huang@mediatek.com, YN.Chen@mediatek.com, Leon.Yen@mediatek.com, Eric-SY.Chang@mediatek.com, Deren.Wu@mediatek.com, km.lin@mediatek.com, robin.chiu@mediatek.com, ch.yeh@mediatek.com, posh.sun@mediatek.com, Eric.Liang@mediatek.com, Stella.Chang@mediatek.com, jemele@google.com, yenlinlai@google.com, linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org References: <92a8ecfdf198b34f98d5c1489a83adf151657760.1626207204.git.objelf@gmail.com> From: Felix Fietkau Subject: Re: [PATCH v3 1/4] mt76: fix mt76_rates for the multiple devices Message-ID: Date: Thu, 15 Jul 2021 20:09:12 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <92a8ecfdf198b34f98d5c1489a83adf151657760.1626207204.git.objelf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2021-07-13 22:15, sean.wang@mediatek.com wrote: > From: Sean Wang > > PHY offset in either .hw_value or .hw_value_short for mt7615, mt7663, > mt7915 and mt7921 device all start at bit 6, not 8. > > Suggested-by: Ryder Lee > Signed-off-by: Sean Wang Unfortunately this patch causes a few regressions. Since tx and rx handling is different in their use of the PHY mode bits, the PHY part should of hw_value should be masked out when filling the tx rateval. There are a few places in the code that rely on the fixed shift of 8, including the generic function mt76_get_rate. This patch should be dropped, and the bit offset differences dealt with in the other patches of this series. I will send an updated version - Felix