Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 15 Jul 2021 11:57:04 -0700
From:   Brian Norris <briannorris@chromium.org>
To:     Ping-Ke Shih <pkshih@realtek.com>
Cc:     kvalo@codeaurora.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 03/24] rtw89: add core and trx files
Message-ID: <YPCFABiygQbiMqcB@google.com>
References: <20210618064625.14131-1-pkshih@realtek.com>
 <20210618064625.14131-4-pkshih@realtek.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210618064625.14131-4-pkshih@realtek.com>
Precedence: bulk

Hi,

On Fri, Jun 18, 2021 at 02:46:04PM +0800, Ping-Ke Shih wrote:
> --- /dev/null
> +++ b/drivers/net/wireless/realtek/rtw89/core.c
> @@ -0,0 +1,2359 @@
> +static void rtw89_traffic_stats_calc(struct rtw89_dev *rtwdev,
> +				     struct rtw89_traffic_stats *stats)
> +{
...
> +	stats->tx_avg_len = (u32)(stats->tx_cnt ? stats->tx_unicast / stats->tx_cnt : 0);
> +	stats->rx_avg_len = (u32)(stats->rx_cnt ? stats->rx_unicast / stats->rx_cnt : 0);

You're doing 64-bit division which isn't supported on all architectures.
You need a do_div()-based solution here, like:

	stats->tx_avg_len = stats->tx_cnt
			    ? DIV_ROUND_DOWN_ULL(stats->tx_unicast, stats->tx_cnt)
			    : 0;
	stats->rx_avg_len = stats->rx_cnt
			    ? DIV_ROUND_DOWN_ULL(stats->rx_unicast, stats->rx_cnt)
			    : 0;

Brian