Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 17 Jul 2021 15:57:38 +0200
From:   Pali =?utf-8?B?Um9ow6Fy?= <pali@kernel.org>
To:     Sharvari Harisangam <sharvari.harisangam@nxp.com>
Cc:     Maximilian Luz <luzmaximilian@gmail.com>,
        Jonas =?utf-8?Q?Dre=C3=9Fler?= <verdre@v0yd.nl>,
        Ganapathi Bhat <ganapathi017@gmail.com>,
        Amitkumar Karwar <amitkarwar@gmail.com>,
        Xinming Hu <huxinming820@gmail.com>,
        linux-wireless@vger.kernel.org,
        Marek =?utf-8?B?QmVow7pu?= <marek.behun@nic.cz>
Subject: Re: mwifiex: mwifiex_cfg80211_change_station and AP mode
Message-ID: <20210717135738.isur3l2v4yyo54ad@pali>
References: <20200701124837.3jss6u324f7kqeou@pali>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200701124837.3jss6u324f7kqeou@pali>
User-Agent: NeoMutt/20180716
Precedence: bulk

[+cc: Maximilian, Jonas and Sharvari]

Just to note that hostapd does not work in EAP mode (which is used e.g.
in WPA2-Enterprise) when kernel driver does not implement
NL80211_CMD_SET_STATION with NL80211_ATTR_STA_VLAN support.

So without it is mwifiex basically unusable for EAP mode.

On Wednesday 01 July 2020 14:48:37 Pali Rohár wrote:
> Hello!
> 
> I'm looking at mwifiex_cfg80211_change_station() function which
> basically implements NL80211_CMD_SET_STATION nl80211 API.
> 
> Currently this mwifiex implementation does not support AP mode, only
> client STA mode.
> 
> The most common usage of NL80211_CMD_SET_STATION in AP mode is via
> NL80211_ATTR_STA_VLAN to put clients into separate VLANs.
> 
> Is there any possibility how to implement NL80211_CMD_SET_STATION with
> NL80211_ATTR_STA_VLAN in mwifiex (in mwifiex_cfg80211_change_station)?
> It looks like it is needed some mwifiex firmware command which would do
> it (put client into vlan).
> 
> Do you have any information / documentation for this feature?