Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp4433712pxv; Tue, 20 Jul 2021 03:47:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzNlYI8eLnNJE3gxMpUI1IAb6cGuz909IIbJTVKejnSbHVzaUB7rVkQMH1xOjTB5H2KzMfT X-Received: by 2002:a92:d302:: with SMTP id x2mr20251737ila.161.1626778039630; Tue, 20 Jul 2021 03:47:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626778039; cv=none; d=google.com; s=arc-20160816; b=mvDD73ON4u+hvCTyNeVSj4MfOwQpSogm7fruqRmpSeP1gM6cI2eZsZopzDYikLNi0Y 44T8hNX2X51QbIfK7Jutk9Wz54GyZZRCtOC7XQtRaLdNieSErQs7HFxN+Fuzz2eWUtm2 WdP7wm8OEDMmdepBW9nDBnMc1Ai+J9Jg/U1WPfTdc+zsfJZDaCyBCcXbNRWQDegrtDTc gY2kpdTUulqHuGl0w7f/JU3iaq7U+BnHpLtFsNPANIIPfJIpu9A/FFUefIQQW2hDfQ+n Serw38lPvRrN9WGqiPVd3o1jU7EVI2u0wFZCYlTLq4ZR6GnhYogwBWES1x5WxyEY5jU/ HSmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=w2foh2yOKtcNvlrENpupi0wPT8fl/U5hjBsxLa5nQ/I=; b=aMXcsqJ+YqLe/UEwuw62HuzCn0BCZsu+m441h7Ap6ZnOLbddsUZ2GBeKOJwd/W/yEk 1lTx75fA2K5Suv3Y1b8v6WkCqgfusfanld3GgwqMuwURzjlVtKP6rgKyC8u2ylkGDhk6 TFmbBupI/VAeJm3Mo1XUKpecrURC7zCstJOvG8GcnupvVW/VsOzl4l0scgAKyQw+lWuP TrVqC7j9I+mjEqc2HVwy5E5eCPV6E+BLlZSMin80AhGOCy9DIfSS/ucrRdwN8Yts/PRp du1XK8LSvcmw/cr6Nm0EYhsE045HjE/GCwNNy3zjCtycFv98c5irpcxOm0+SPHKkkTi0 6NZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GLafNpJF; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h12si30103956iow.59.2021.07.20.03.47.02; Tue, 20 Jul 2021 03:47:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GLafNpJF; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237692AbhGTKFt (ORCPT + 99 others); Tue, 20 Jul 2021 06:05:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:34986 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237614AbhGTKEP (ORCPT ); Tue, 20 Jul 2021 06:04:15 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4748B6120F; Tue, 20 Jul 2021 10:44:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626777876; bh=J4am9/bVVh/y4DpPyboBO49mcaLQLuHHpQ8U9G74tLM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GLafNpJFthhFofmm7KYcXWxJZ8kEW8iN5MLI/SE2NA6r0HtLmmoBpV3HURGhRWnbB h6r+J2co8OCnH11uB16ZdOSHJOGqPmb5HH5LSSWzXzyqihDtvF96i1U7AgVwiygyb4 JatBw+Zkksw1rKKxRhKSpcpca4soppvBHGoEEnRIY8AiTa9+YiQuhwO77EWeLYNAKc dBewllbngb1F4G1CR/PUXrUfKoGCUh1DGhTkRHgAQ+TDf7+cVJ3tvm42aME8I2PpbU lNdTCWUx6ZppCbkV8I7jExAG+jM7w/jQZ8q0Evspkip4O+uwDChCr3rl1Wks0ViBu6 5G8TV2uXPUOUg== Date: Tue, 20 Jul 2021 12:44:27 +0200 From: Jakub Kicinski To: Yajun Deng Cc: davem@davemloft.net, roopa@nvidia.com, nikolay@nvidia.com, yoshfuji@linux-ipv6.org, dsahern@kernel.org, courmisch@gmail.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, johannes@sipsolutions.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bridge@lists.linux-foundation.org, linux-decnet-user@lists.sourceforge.net, linux-wireless@vger.kernel.org Subject: Re: [PATCH 0/4] Remove rtnetlink_send() in rtnetlink Message-ID: <20210720124427.6b4e05a8@cakuba> In-Reply-To: <20210719122158.5037-1-yajun.deng@linux.dev> References: <20210719122158.5037-1-yajun.deng@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, 19 Jul 2021 20:21:54 +0800, Yajun Deng wrote: > rtnetlink_send() is similar to rtnl_notify(), there is no need for two > functions to do the same thing. we can remove rtnetlink_send() and > modify rtnl_notify() to adapt more case. > > Patch1: remove rtnetlink_send() modify rtnl_notify() to adapt > more case in rtnetlink. > Path2,Patch3: Adjustment parameters in rtnl_notify(). > Path4: rtnetlink_send() already removed, use rtnl_notify() instead > of rtnetlink_send(). You can't break compilation in between patches. Each step of the series (each patch) must be self-contained, build, and work correctly. Otherwise bisection becomes a nightmare. Please also post series as a thread (patches in reply to the cover letter), it seems that patchwork did not group the patches correctly here.