Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp4788093pxv; Tue, 20 Jul 2021 11:28:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz+yBg+6HdcmNbv4erbFjOq//K9Go8TvBLAKMofgEpvnKfderetGafRfUsuIDSpdVrQKCmU X-Received: by 2002:a05:6602:198:: with SMTP id m24mr10984391ioo.144.1626805714440; Tue, 20 Jul 2021 11:28:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626805714; cv=none; d=google.com; s=arc-20160816; b=oyaj6AkU10TPbQ7c+gaQFfT7Uj0Ks4WMX/PD+OXYk42ahqhbXlyft2maf9bjLWkHtt XJBccGpRc7UYoQZMFAFabq5m4upWCM45Us+wh243B58abrtgiBNOgWmbqcqYFsGRV/Pa U9LR00tQpIjfdUApS1e3z8pfWe5CPIzDthjH+mT/jscqNtm2KBShVNjl3LOeSO/Ue0lF go6PKKBF1k1QuIPHGhxApnQ8uMT6ReRqOvwHj29L0MxhpgYtnlsxk8souviv3PQeXKRc 7xc5Peqw4gkWUko+DURuMuPghWKupWYHdlTta0VJafDo+7CyWBp8wfq8OzBQASI3jSZX JXmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=pkwuNDs25asxpZxe8MPjeyJu0nSda4JFa+M93Yv8H6U=; b=T68ZtoHrtEv3pLD0QlO3I55iC2TIkucY7NXzO8sAIZgieY7Z8OKVocM1y1iglnB1eI 3uGiPwrreYD/ANhH4oFXCRaVSLpqDXzUF12P6ITvXS4Iq2Q+F+mKlre8Niu/R+AIBjYX YDLHze8tsm4DqgBhOnKx9a2a2kQSj4qR0NTX9/UsiuHypISnxbfVPJDry+TfnCqpKX6h zvSo3puaMYFSyUPdo/VWOLHss4BF4cgpuHpiefCqJst2XYwPSKRjygfD/0egtcgudkcI q1SH5kN934Vl8vOz5mFPIOHnnB4OwaJxxFxg55gpSKfjgbV3iLs6rmGRH0zVO5isaY4Q Gszg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@candelatech.com header.s=default header.b=Vj6E6hj5; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=candelatech.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f16si27007552ilc.93.2021.07.20.11.28.22; Tue, 20 Jul 2021 11:28:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@candelatech.com header.s=default header.b=Vj6E6hj5; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=candelatech.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232482AbhGTRqM (ORCPT + 99 others); Tue, 20 Jul 2021 13:46:12 -0400 Received: from dispatch1-us1.ppe-hosted.com ([148.163.129.49]:34274 "EHLO dispatch1-us1.ppe-hosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234886AbhGTRmi (ORCPT ); Tue, 20 Jul 2021 13:42:38 -0400 X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.7.64.31]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id CCFE31C006E for ; Tue, 20 Jul 2021 18:23:01 +0000 (UTC) Received: from mail3.candelatech.com (mail2.candelatech.com [208.74.158.173]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id AC2C660007A for ; Tue, 20 Jul 2021 18:23:01 +0000 (UTC) Received: from ben-dt4.candelatech.com (50-251-239-81-static.hfc.comcastbusiness.net [50.251.239.81]) by mail3.candelatech.com (Postfix) with ESMTP id 7180413C2BE; Tue, 20 Jul 2021 11:23:01 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 mail3.candelatech.com 7180413C2BE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=candelatech.com; s=default; t=1626805381; bh=TDMfAWUi3ndw7i5HSIKX1OkblhFBE2r7VxVUK+aw7EE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Vj6E6hj5BKaOQ6hKxw6MfM/pIEz/kLDASrA1UROyfc6ttRojJvJJXKRZgpOrFsl6l SnCrCaR2xMMmi0vDpMOvQVWY4pPs5UhzNXe1X2chKg5SyIiG94e9Iz/suGOI5lkA6V nvw/JLUpgi2lkYwWhqLhHWte/BtllQwgq+EL7IN0= From: greearb@candelatech.com To: linux-wireless@vger.kernel.org Cc: Ben Greear Subject: [PATCH 09/11] mt76: mt7915: txfree status to show txcount instead of latency. Date: Tue, 20 Jul 2021 11:22:53 -0700 Message-Id: <20210720182256.30536-9-greearb@candelatech.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210720182256.30536-1-greearb@candelatech.com> References: <20210720182256.30536-1-greearb@candelatech.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-MDID: 1626805382-EjVERiEopKr7 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Ben Greear Latency is not obviously that useful, but txcount can let us deduce retries, which may be more interesting. Signed-off-by: Ben Greear --- drivers/net/wireless/mediatek/mt76/mt7915/init.c | 3 +++ drivers/net/wireless/mediatek/mt76/mt7915/mac.h | 8 +++++--- drivers/net/wireless/mediatek/mt76/mt7915/regs.h | 4 ++++ 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/init.c b/drivers/net/wireless/mediatek/mt76/mt7915/init.c index 0e8296a2d75a..fb3161c08baf 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7915/init.c +++ b/drivers/net/wireless/mediatek/mt76/mt7915/init.c @@ -304,6 +304,9 @@ static void mt7915_mac_init(struct mt7915_dev *dev) /* enable hardware de-agg */ mt76_set(dev, MT_MDP_DCR0, MT_MDP_DCR0_DAMSDU_EN); + /* disable Tx latency report to enable Tx count in txfree path */ + mt76_clear(dev, MT_PLE_HOST_RPT0, MT_PLE_HOST_RPT0_TX_LATENCY); + for (i = 0; i < MT7915_WTBL_SIZE; i++) mt7915_mac_wtbl_update(dev, i, MT_WTBL_UPDATE_ADM_COUNT_CLEAR); diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mac.h b/drivers/net/wireless/mediatek/mt76/mt7915/mac.h index 986a65badd1b..741d51b0fa06 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7915/mac.h +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mac.h @@ -304,13 +304,15 @@ struct mt7915_tx_free { #define MT_TX_FREE_MSDU_CNT GENMASK(9, 0) #define MT_TX_FREE_WLAN_ID GENMASK(23, 14) +/* when configured for txfree latency mode. See MT_PLE_HOST_RPT0_TX_LATENCY + * Not enabled by default now. + */ #define MT_TX_FREE_LATENCY GENMASK(12, 0) -/* 0: success, others: dropped */ +/* when configured for txcount mode. See MT_PLE_HOST_RPT0_TX_LATENCY. */ +#define MT_TX_FREE_TXCNT GENMASK(12, 0) #define MT_TX_FREE_STATUS GENMASK(14, 13) #define MT_TX_FREE_MSDU_ID GENMASK(30, 16) #define MT_TX_FREE_PAIR BIT(31) -/* will support this field in further revision */ -#define MT_TX_FREE_RATE GENMASK(13, 0) #define MT_TXS0_FIXED_RATE BIT(31) #define MT_TXS0_BW GENMASK(30, 29) diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/regs.h b/drivers/net/wireless/mediatek/mt76/mt7915/regs.h index 62cc32a098fc..ac4d233b8cf2 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7915/regs.h +++ b/drivers/net/wireless/mediatek/mt76/mt7915/regs.h @@ -22,6 +22,10 @@ #define MT_PLE_BASE 0x8000 #define MT_PLE(ofs) (MT_PLE_BASE + (ofs)) +/* Modify whether txfree struct returns latency or txcount. */ +#define MT_PLE_HOST_RPT0 MT_PLE(0x030) +#define MT_PLE_HOST_RPT0_TX_LATENCY BIT(3) + #define MT_PLE_FL_Q0_CTRL MT_PLE(0x1b0) #define MT_PLE_FL_Q1_CTRL MT_PLE(0x1b4) #define MT_PLE_FL_Q2_CTRL MT_PLE(0x1b8) -- 2.20.1