Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 10/11] mt76: mt7915: Report tx-retries
To:     linux-wireless@vger.kernel.org
References: <20210720182256.30536-1-greearb@candelatech.com>
 <20210720182256.30536-10-greearb@candelatech.com>
From:   Ben Greear <greearb@candelatech.com>
Organization: Candela Technologies
Message-ID: <41e9db97-741b-a4a3-4b15-2c1ea36a7f7c@candelatech.com>
Date:   Thu, 22 Jul 2021 11:03:45 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <20210720182256.30536-10-greearb@candelatech.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/20/21 11:22 AM, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
> 
> mac80211 stack will only report tx-status for skb claiming to be ampdu heads,
> so lie a bit in mt7915 and set the flag so that mac80211 will record status
> for each skb.
> 
> mt7915 appears to report retry status on an individual per-skb manner,
> so that method above seems to work.
> 
> Re-constitute the txinfo status rate info so that the rix and flags
> is also at least close to correct.  No direct way to report HE
> rates that way, so mac80211 might could use some tweaking in
> the ieee80211_tx_status_ext to take both info and status->rate
> into account.

Please don't apply this patch, it has a bug related to the aql and how
I cleared the skb shared info struct..  I will fix this directly and
re-post the series.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com