Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp4141540pxv; Mon, 26 Jul 2021 23:03:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzbSEiLC7sZOY0CzjHpabREZcUuKzktvgx+DvBbjeu48hM2dSvVbmfLaF6nysPrdffPdRPE X-Received: by 2002:a50:9350:: with SMTP id n16mr12608530eda.176.1627365788858; Mon, 26 Jul 2021 23:03:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627365788; cv=none; d=google.com; s=arc-20160816; b=Cn99Zvdd04htIOT4hkea3rPO6n6afHTs4I+HxvhkMaJt83s++yxF10QiD+wJcHlw65 Gn2R+z9GhQcrSzMWo7lNndDw0VfRMQ69YagxLkpsLah4zTL8VAHhmW+/GcP+mXSwSWPy aaN2Lc1eqkptnWQ9H6nFKhMamF1YsL2EAIn/Uidd8eaSl/Y9lhEezDPl5b/AP3F7Ygmn 7CRGrIh4NiVCIc1uDdMmG77ANGuCR7d/FuzsifffuqD6HopTJLnHxotaRYjEaKac4a/R iMv6cCujJISJnD2sHr5FYtwyQe08MAnWp2PqDGG76ljqzlX69+8c7+ynRIsC3z73Byvd lnQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dmarc-filter:sender :dkim-signature; bh=LZqKYy1v64NNofFiaZNW6zb9oWb1tmIOWKvk53k8Qt8=; b=Tq844567hfnlD2wKbvp+6VjK9bPC6Dg0YsRcorTLyk8lgRg+t2DaBQqkYEuPGcSVKM 14rEVy+n3p1EGird6TZT3woWuU/xCA/csYX6Ri1RXzMw/F0+nFDdzaG+kQu9DlsqTkao LG/PSi35DndCg+RhrvzO2Vqy21v0lzvsJ9gGElir7YtejIPPZRtBJiSZi3kZ9E9WGxaO U9n+CR51m8OI9svYdlsPantczkZ+nSZWrwYBWE0ukhkF8GXhcMu9ioalzk4lpd3TVKf9 TFNBjRGu6PbacuaMwgSkwaOTTcpbvha9iA2GtrNlxkC5pa8lGmkbUSoqCD+UB+YzCMMR g/Ow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=kXyl8vc8; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ka11si2196979ejc.367.2021.07.26.23.02.41; Mon, 26 Jul 2021 23:03:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=kXyl8vc8; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235458AbhG0GC2 (ORCPT + 99 others); Tue, 27 Jul 2021 02:02:28 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:51497 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235444AbhG0GC0 (ORCPT ); Tue, 27 Jul 2021 02:02:26 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1627365747; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=LZqKYy1v64NNofFiaZNW6zb9oWb1tmIOWKvk53k8Qt8=; b=kXyl8vc8/Qttc5qFMNESUvBOLx5iI9cYfoiHb6wSfRkVQRai5RngZEMkic/gAZbegg+K9jvT 6A6irTN9pF8Z6fAm8VJTHuYxMfbqpvxUAOQJBMOo920nm+SXFN20APlVjm3LacAY2kraWDvW csAKrq7qPfVo5dkPf7CC96s/HYM= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-west-2.postgun.com with SMTP id 60ffa1729771b05b24811da3 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 27 Jul 2021 06:02:26 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 446B9C43145; Tue, 27 Jul 2021 06:02:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from tykki (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 66387C433F1; Tue, 27 Jul 2021 06:02:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 66387C433F1 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Dongliang Mu Cc: ath9k-devel@qca.qualcomm.com, "David S. Miller" , Jakub Kicinski , Brooke Basile , syzbot+6692c72009680f7c4eb2@syzkaller.appspotmail.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ath9k: hif_usb: fix memory leak in ath9k_hif_usb_firmware_cb References: <20210709084351.2087311-1-mudongliangabcd@gmail.com> Date: Tue, 27 Jul 2021 09:02:21 +0300 In-Reply-To: <20210709084351.2087311-1-mudongliangabcd@gmail.com> (Dongliang Mu's message of "Fri, 9 Jul 2021 16:43:51 +0800") Message-ID: <87r1fkguqa.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Dongliang Mu writes: > The commit 03fb92a432ea ("ath9k: hif_usb: fix race condition between > usb_get_urb() and usb_kill_anchored_urbs()") adds three usb_get_urb > in ath9k_hif_usb_dealloc_tx_urbs and usb_free_urb. > > Fix this bug by adding corresponding usb_free_urb in > ath9k_hif_usb_dealloc_tx_urbs other and hif_usb_stop. > > Reported-by: syzbot+6692c72009680f7c4eb2@syzkaller.appspotmail.com > Fixes: 03fb92a432ea ("ath9k: hif_usb: fix race condition between usb_get_urb() and usb_kill_anchored_urbs()") > Signed-off-by: Dongliang Mu In the past there have been so many problems with ath9k syzbot fixes that I have now a hard time trusting them. Can someone review this in detail, please? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches