Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: wgong=codeaurora.org@mg.codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Date:   Fri, 30 Jul 2021 18:00:48 +0800
From:   Wen Gong <wgong@codeaurora.org>
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 4/9] cfg80211: add definition for 6G power spectral
 density(psd)
In-Reply-To: <1553c2923cc332acf3da00b49e2d2ac17cc12ba0.camel@sipsolutions.net>
References: <20210517201932.8860-1-wgong@codeaurora.org>
 <20210517201932.8860-5-wgong@codeaurora.org>
 (sfid-20210517_222029_605505_DDB76CEE)
 <1553c2923cc332acf3da00b49e2d2ac17cc12ba0.camel@sipsolutions.net>
Message-ID: <03159ab593d309353d69cd65db0a8da8@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk

On 2021-07-23 17:24, Johannes Berg wrote:
> On Mon, 2021-05-17 at 16:19 -0400, Wen Gong wrote:
>> 
>> + * @IEEE80211_CHAN_PSD: power spectral density (in dBm)
>> + *	on this channel.
> 
> Do we need that? Which really is just another way of asking
> 
>> + * @psd: power spectral density (in dBm)
> 
> whether or not 0 is a valid value for this?
yes, 0 is also a valid value.
It also have negative, such as -1dBm.
> 
>> +++ b/include/uapi/linux/nl80211.h
>> @@ -4040,6 +4040,7 @@ enum nl80211_sched_scan_match_attr {
>>   * @NL80211_RRF_NO_80MHZ: 80MHz operation not allowed
>>   * @NL80211_RRF_NO_160MHZ: 160MHz operation not allowed
>>   * @NL80211_RRF_NO_HE: HE operation not allowed
>> + * @NL80211_RRF_PSD: channels has power spectral density value
> 
> It doesn't seem like we need this, after all, there must be some kind 
> of
> attribute for the PSD, and then its presence/absence already indicates
> this?
Now the psd value 0 is also a valid value, so now we can not consider 
the
psd 0 as NON-PSD, so we need this flag to check it is psd or NON-psd.
> 
> johannes