Received: by 2002:a05:6a10:c7c6:0:0:0:0 with SMTP id h6csp230153pxy; Sat, 31 Jul 2021 05:43:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxFCWko2vrs/vR0Pe0Kl6fgm8j2fcwB8vgk2BLZPmwyduqKrLiIi4ItESVmNqNd2l9raWbx X-Received: by 2002:a05:6e02:e02:: with SMTP id a2mr1652914ilk.127.1627735396372; Sat, 31 Jul 2021 05:43:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627735396; cv=none; d=google.com; s=arc-20160816; b=n9wEE8txAE/RnE1cybNsOIpM4B/RiV6tauZrAV6dZy3vVxgJ4kKYnmi5w6oNCyG4Ga evNbeMmB3gV3FpFs6e7t0SRze+o9iHH/Dn3xl6LWoVtRo16Aaas5uIAkDUSaw8UkoDx1 XEWUuRQH2vDp1JzWyeM3Epf7fhXRCQ/O4kl1FRfwHgJWktq/sAk4ooXpQ5fsY2qLRupd HZgzx3idivj2E1NKufRbZWZJNTe7nZKk8w6Ti+rhfQLVTwIKAE5ntBBNpxNHHdKCuxzT 5JpvQZh3WlV60TxCm+NZn50NhTvY9YKjGCCKxTMs2NOp7tIk+D8jrY+FubL0Sj66JgvC k0Ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=oUq6gPgdLVraYDRbQRFMm2OILuIbppCsvEd0SKiqGuE=; b=OJfJUvocKrF+N9/eZml7dzzocsxmoXrmObnCdAaI0bukrc85RFWEMJAcBbRipaKfxD GEVbruc1PkQIko8ZYdRhFGet98loDID6C+ncs5l0NwLXGCbVL8YFO0/C3Z37N+HZdUL6 o0PcDAewSV5EqT1GGN5RvcQxr6hgVWRbBUU0CQmTjA0JByV8Ujro3hdVRyAtcJHPcwnq oPtlSxlvLcOEytFjKTMPGfzIBFB1crqb9jyC5Y9rZ6lnP+2FIrPDfK3GBEdTQh1m+lro dA8qb7N/39HY/0+oGmav1k2bulX64JOrr2LSy/rVSBk2DfFCq8nffzmniioaBbIjG8cM hTAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=Qa+aNlMg; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d11si5948505ilc.143.2021.07.31.05.42.46; Sat, 31 Jul 2021 05:43:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=Qa+aNlMg; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232957AbhGaMk5 (ORCPT + 99 others); Sat, 31 Jul 2021 08:40:57 -0400 Received: from smtp-relay-canonical-1.canonical.com ([185.125.188.121]:39810 "EHLO smtp-relay-canonical-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232690AbhGaMk4 (ORCPT ); Sat, 31 Jul 2021 08:40:56 -0400 Received: from localhost (1.general.cking.uk.vpn [10.172.193.212]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id 572F73F0FD; Sat, 31 Jul 2021 12:40:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1627735249; bh=oUq6gPgdLVraYDRbQRFMm2OILuIbppCsvEd0SKiqGuE=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type; b=Qa+aNlMgECRGFRqmuzEkdbaBsr2JR/J5l8wJ3pc+dtD11jqap5mt9b/P7TC/4xXBl 0OEPEBnnFhiTkNqBhauRBAWPTzvHYhb95qg4/+PS3AVrxOX05hqx3pI4K8mBvY4zCb kn4i/AJxg0sOZNjwc1c6W2Vq6jIfL+C1VBWK1eFDsqbS02RvJeOFJIE6GZ1LbYn8Wa Q/ofzr1RCPDMixYNcaDUvV3qq820sBk+whGGKu5wSxar+zI4lZHJxPxVeo9qPN4x/E Hx/+1FrTEAudD/eKN/0/kfIn49m/7GVUPtpqwBKufJTEKL2/tnfjp21eaFR2OxyG5W BhTPlHcd3UGyg== From: Colin King To: Ping-Ke Shih , Kalle Valo , "David S . Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] rtlwifi: rtl8192de: Remove redundant variable initializations Date: Sat, 31 Jul 2021 13:40:43 +0100 Message-Id: <20210731124044.101927-1-colin.king@canonical.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Colin Ian King The variables rtstatus and place are being initialized with a values that are never read, the initializations are redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c index 76dd881ef9bb..4eaa40d73baf 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c @@ -681,7 +681,7 @@ static bool _rtl92d_phy_bb_config(struct ieee80211_hw *hw) struct rtl_priv *rtlpriv = rtl_priv(hw); struct rtl_phy *rtlphy = &(rtlpriv->phy); struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw)); - bool rtstatus = true; + bool rtstatus; rtl_dbg(rtlpriv, COMP_INIT, DBG_TRACE, "==>\n"); rtstatus = _rtl92d_phy_config_bb_with_headerfile(hw, @@ -1362,7 +1362,7 @@ u8 rtl92d_get_rightchnlplace_for_iqk(u8 chnl) 132, 134, 136, 138, 140, 149, 151, 153, 155, 157, 159, 161, 163, 165 }; - u8 place = chnl; + u8 place; if (chnl > 14) { for (place = 14; place < sizeof(channel_all); place++) { -- 2.31.1