Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <3f55848b4612d1b17d95a4c36bec1dee2b1814f1.camel@perches.com>
Subject: Re: [PATCH 1/2] rtlwifi: rtl8192de: Remove redundant variable
 initializations
From:   Joe Perches <joe@perches.com>
To:     Colin King <colin.king@canonical.com>,
        Ping-Ke Shih <pkshih@realtek.com>,
        Kalle Valo <kvalo@codeaurora.org>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Mon, 02 Aug 2021 01:35:35 -0700
In-Reply-To: <20210731124044.101927-1-colin.king@canonical.com>
References: <20210731124044.101927-1-colin.king@canonical.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.40.0-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Sat, 2021-07-31 at 13:40 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The variables rtstatus and place are being initialized with a values that
> are never read, the initializations are redundant and can be removed.

trivia:

> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
[]
> @@ -1362,7 +1362,7 @@ u8 rtl92d_get_rightchnlplace_for_iqk(u8 chnl)
> ?		132, 134, 136, 138, 140, 149, 151, 153, 155,
> ?		157, 159, 161, 163, 165
> ?	};
> -	u8 place = chnl;
> +	u8 place;
> ?
> 
> ?	if (chnl > 14) {
> ?		for (place = 14; place < sizeof(channel_all); place++) {

This line should probably be

		for (place = 14; place < ARRAY_SIZE(channel_all); place++) {