Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <e96786f5772f8ed01ab3153e0d5d66820b2e920a.camel@perches.com>
Subject: Re: [PATCH 2/2] rtlwifi: rtl8192de:  make arrays static const,
 makes object smaller
From:   Joe Perches <joe@perches.com>
To:     Colin King <colin.king@canonical.com>,
        Ping-Ke Shih <pkshih@realtek.com>,
        Kalle Valo <kvalo@codeaurora.org>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Mon, 02 Aug 2021 01:35:46 -0700
In-Reply-To: <20210731124044.101927-2-colin.king@canonical.com>
References: <20210731124044.101927-1-colin.king@canonical.com>
         <20210731124044.101927-2-colin.king@canonical.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.40.0-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Sat, 2021-07-31 at 13:40 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Don't populate arrays the stack but instead make them static const
> Makes the object code smaller by 852 bytes.
[]
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
[]
> @@ -1354,7 +1354,7 @@ static void _rtl92d_phy_switch_rf_setting(struct ieee80211_hw *hw, u8 channel)
> ?
> 
> ?u8 rtl92d_get_rightchnlplace_for_iqk(u8 chnl)
> ?{
> -	u8 channel_all[59] = {
> +	static const u8 channel_all[59] = {
> ?		1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14,
> ?		36, 38, 40, 42, 44, 46, 48, 50, 52, 54, 56, 58,
> ?		60, 62, 64, 100, 102, 104, 106, 108, 110, 112,
> @@ -3220,7 +3220,7 @@ void rtl92d_phy_config_macphymode_info(struct ieee80211_hw *hw)
> ?u8 rtl92d_get_chnlgroup_fromarray(u8 chnl)
> ?{
> ?	u8 group;
> -	u8 channel_info[59] = {
> +	static const u8 channel_info[59] = {
> ?		1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14,
> ?		36, 38, 40, 42, 44, 46, 48, 50, 52, 54, 56,
> ?		58, 60, 62, 64, 100, 102, 104, 106, 108,

These two arrays (channel_info and channel_all) are identical but
laid out differently and could be combined and use a single name.