Received: by 2002:a05:6a10:c7c6:0:0:0:0 with SMTP id h6csp1668531pxy; Mon, 2 Aug 2021 07:29:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxyibXxLAqd1xMzWkExvVp2BOegTWaVk/s5LzjPb8/MVUioBC7zecYdhJKCgukzJsG+R9ao X-Received: by 2002:a17:906:45b:: with SMTP id e27mr15703028eja.375.1627914551616; Mon, 02 Aug 2021 07:29:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627914551; cv=none; d=google.com; s=arc-20160816; b=evbklO0AKy4xNGdR1VcesM+MHtkfFvGDR3OLCpVaEgZSK3Ou52OMWLjLfj/UtejKXK yKDPdfcH97Q7vel4pM0Xpr9HENu+sl/998NoVVTUCuR+sbEJMuwziI88GO0w8/O1m99i FCTlKdUSpZwc3sNiUh/yWqh18UfVcdc4Cu4lLglFtc7w0nNe9gnGIuEzj3d6j9qX4jy7 Jg9J+dtBWa/1HJhHnmjIdYm0V3hm+NkRclNKgf+oduG8PMlMOqixGeaSKjNDsOz997g3 GYtub7ssZ9fEH4n4wd+onBqIqg1kpxTuVyEv+4W+pvenrabP9a4mgbIizoEomL/ujTUc lSYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:cc:to:from; bh=cKAOR0mCIceb4NVHpjycutNHIp/YJeM+eFfs1lMmRKw=; b=RWdJeC9RhHePubK4lSJKkYqucRBfv5SHT5FJ7h73xnB1y8Si4np77IvYppmvbfHVtn yS010Cq9B8B2jz8g6+mCILF/msju+xabNIiOCWl++ISiW/XgQcmRvNYZzbKmYTX/IkX0 F6/VHR11X3+07LM8fUmnO7vj28YoJy/SeFx7BwdHWa9SHlwo1DytfEIB3IgtN8z1dz/G rh2dME9NSMk+CIeDprSIS3EslNaKO32ZoyuwLNX+Nl99got8oXTij2OLRohUqbT1oWnO IiyFOs9jNMVHvBbBPtN3oTdm/C1Yo5dNEpatdwjsPfbM/wyyeZQFEP3YcbqpO+Qzl4fY CKuA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d12si12721582ejj.278.2021.08.02.07.28.49; Mon, 02 Aug 2021 07:29:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234095AbhHBO2r (ORCPT + 99 others); Mon, 2 Aug 2021 10:28:47 -0400 Received: from paleale.coelho.fi ([176.9.41.70]:50930 "EHLO farmhouse.coelho.fi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S234057AbhHBO2r (ORCPT ); Mon, 2 Aug 2021 10:28:47 -0400 Received: from 91-156-6-193.elisa-laajakaista.fi ([91.156.6.193] helo=kveik.ger.corp.intel.com) by farmhouse.coelho.fi with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1mAYvi-001xts-MJ; Mon, 02 Aug 2021 17:28:36 +0300 From: Luca Coelho To: kvalo@codeaurora.org Cc: luca@coelho.fi, linux-wireless@vger.kernel.org Date: Mon, 2 Aug 2021 17:28:22 +0300 Message-Id: X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210802142829.109448-1-luca@coelho.fi> References: <20210802142829.109448-1-luca@coelho.fi> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Checker-Version: SpamAssassin 3.4.5-pre1 (2020-06-20) on farmhouse.coelho.fi X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, TVD_RCVD_IP autolearn=ham autolearn_force=no version=3.4.5-pre1 Subject: [PATCH 05/12] iwlwifi: mvm: remove check for vif in iwl_mvm_vif_from_mac80211() Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Luca Coelho This check is useless, because we would return NULL in that case and none of the callers actually check that the return value was not NULL before accessing it. Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h b/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h index b50942f28bb7..82a53cbf4342 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h +++ b/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h @@ -431,8 +431,6 @@ struct iwl_mvm_vif { static inline struct iwl_mvm_vif * iwl_mvm_vif_from_mac80211(struct ieee80211_vif *vif) { - if (!vif) - return NULL; return (void *)vif->drv_priv; } -- 2.32.0