Received: by 2002:a05:6a10:c7c6:0:0:0:0 with SMTP id h6csp1706546pxy; Mon, 2 Aug 2021 08:18:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwU4Vn3ctt6X4fKlN8czC4x2pCT1pCQmA7Bbn0vzJcc2xigxoOHqp3qX9FXy0bOmO8bPPOV X-Received: by 2002:a05:6e02:1561:: with SMTP id k1mr1824636ilu.25.1627917508646; Mon, 02 Aug 2021 08:18:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627917508; cv=none; d=google.com; s=arc-20160816; b=XNrPCDxRon4lXCrHH3I23KEdOTFz03474RLNaD1+1Pv4B8CBlxSaPDhHLi1m9MvbQJ p9bRRoEwIE311MxYXX0IUi7U83T6v0dU4inbidCNXlsRYGQ3K65WIhLIB/wJppBExMpx kw0ny2QgFUUpjuREQ245Sw7ALB9pIEviogx06LPidWJkModoKSPyKR9pMeZIaUFhcgPE ZUmG9xrzMzo3DXXTnNoqpSUxqbPMDs0Ynhnvl43YH990uGLP6U77f+boDh/M0vpUVma5 0uV6wLNEGssGMoo88QfEFwNUSsT6xBC5bX+dcZJTCFVQQodQ0409Y8GePaMNlD2FRjOM M6HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=e5y3Da+qzfH/46A+6qdYlxwV8WJyisYwQGRBAwj5HOY=; b=BSZGb+g0MNU0qOE2MC/ys+5guhw8ktIPCxfgf7EfbkdnR/xD5wPq+7tubTTuKkm/m6 HMXq5z1HyQvJT0oCq5pDyA4gNXvK34MFQW4LfyfiZIICep+ydOhQOpSn/ZLJpVoDgFMf afV7IKUpz9cIRkXRnDw3XjXozSwqjBa8O0IumDLjEi35x6xltguUvNnQTh50D/qZ6/QA o6CHyPMzuNkoKOf2e0u0MBRUNmI1tcGkQdWUfiyx8f492iP4NiklZjNe11NpI2kQk5Eo 68rEp5DUTP0W52DMae7+bLBdnEvJmQlWRaBrZjqVb+C8YP/yfcOj3LOU76v98lLCDcDF hd3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@candelatech.com header.s=default header.b=i0vNezaH; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=candelatech.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m6si12988881iol.83.2021.08.02.08.18.17; Mon, 02 Aug 2021 08:18:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@candelatech.com header.s=default header.b=i0vNezaH; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=candelatech.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235064AbhHBPRK (ORCPT + 99 others); Mon, 2 Aug 2021 11:17:10 -0400 Received: from dispatch1-us1.ppe-hosted.com ([148.163.129.49]:47138 "EHLO dispatch1-us1.ppe-hosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235051AbhHBPRI (ORCPT ); Mon, 2 Aug 2021 11:17:08 -0400 X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.7.64.218]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 302931C0069 for ; Mon, 2 Aug 2021 15:16:58 +0000 (UTC) Received: from mail3.candelatech.com (mail2.candelatech.com [208.74.158.173]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 12272840067 for ; Mon, 2 Aug 2021 15:16:58 +0000 (UTC) Received: from ben-dt4.candelatech.com (50-251-239-81-static.hfc.comcastbusiness.net [50.251.239.81]) by mail3.candelatech.com (Postfix) with ESMTP id B10DC13C2BE; Mon, 2 Aug 2021 08:16:57 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 mail3.candelatech.com B10DC13C2BE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=candelatech.com; s=default; t=1627917417; bh=h2xMhm9UxN6BDuy69k72yO4HI2gAYuDeEEu3x0t5Ygo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=i0vNezaHOmTyEy0cMuQ+7MEo2PRBOKxDmeaER3VKMp8kExAKVkCNDQsPdpyCh+gPb WcDJTXvMXaH0SRca4H2ZfLUZnnmOr4Rh9v3fMDP4UveI8AIwCfVxm7F9oOMztvKuy3 CxQTyLVQDMFKEW+vT6Ztan1MMDl8DY7NoZfYGSC8= From: greearb@candelatech.com To: linux-wireless@vger.kernel.org Cc: Ben Greear Subject: [PATCH v4 09/11] mt76: mt7915: txfree status to show txcount instead of latency Date: Mon, 2 Aug 2021 08:16:41 -0700 Message-Id: <20210802151643.32394-9-greearb@candelatech.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210802151643.32394-1-greearb@candelatech.com> References: <20210802151643.32394-1-greearb@candelatech.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-MDID: 1627917418-njsNmeY9snWg Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Ben Greear Latency is not obviously that useful, but txcount can let us deduce retries, which may be more interesting. Signed-off-by: Ben Greear --- drivers/net/wireless/mediatek/mt76/mt7915/init.c | 3 +++ drivers/net/wireless/mediatek/mt76/mt7915/mac.h | 8 +++++--- drivers/net/wireless/mediatek/mt76/mt7915/regs.h | 4 ++++ 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/init.c b/drivers/net/wireless/mediatek/mt76/mt7915/init.c index f174cf219724..a0d282771d77 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7915/init.c +++ b/drivers/net/wireless/mediatek/mt76/mt7915/init.c @@ -304,6 +304,9 @@ static void mt7915_mac_init(struct mt7915_dev *dev) /* enable hardware de-agg */ mt76_set(dev, MT_MDP_DCR0, MT_MDP_DCR0_DAMSDU_EN); + /* disable Tx latency report to enable Tx count in txfree path */ + mt76_clear(dev, MT_PLE_HOST_RPT0, MT_PLE_HOST_RPT0_TX_LATENCY); + for (i = 0; i < MT7915_WTBL_SIZE; i++) mt7915_mac_wtbl_update(dev, i, MT_WTBL_UPDATE_ADM_COUNT_CLEAR); diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mac.h b/drivers/net/wireless/mediatek/mt76/mt7915/mac.h index 986a65badd1b..741d51b0fa06 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7915/mac.h +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mac.h @@ -304,13 +304,15 @@ struct mt7915_tx_free { #define MT_TX_FREE_MSDU_CNT GENMASK(9, 0) #define MT_TX_FREE_WLAN_ID GENMASK(23, 14) +/* when configured for txfree latency mode. See MT_PLE_HOST_RPT0_TX_LATENCY + * Not enabled by default now. + */ #define MT_TX_FREE_LATENCY GENMASK(12, 0) -/* 0: success, others: dropped */ +/* when configured for txcount mode. See MT_PLE_HOST_RPT0_TX_LATENCY. */ +#define MT_TX_FREE_TXCNT GENMASK(12, 0) #define MT_TX_FREE_STATUS GENMASK(14, 13) #define MT_TX_FREE_MSDU_ID GENMASK(30, 16) #define MT_TX_FREE_PAIR BIT(31) -/* will support this field in further revision */ -#define MT_TX_FREE_RATE GENMASK(13, 0) #define MT_TXS0_FIXED_RATE BIT(31) #define MT_TXS0_BW GENMASK(30, 29) diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/regs.h b/drivers/net/wireless/mediatek/mt76/mt7915/regs.h index 62cc32a098fc..ac4d233b8cf2 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7915/regs.h +++ b/drivers/net/wireless/mediatek/mt76/mt7915/regs.h @@ -22,6 +22,10 @@ #define MT_PLE_BASE 0x8000 #define MT_PLE(ofs) (MT_PLE_BASE + (ofs)) +/* Modify whether txfree struct returns latency or txcount. */ +#define MT_PLE_HOST_RPT0 MT_PLE(0x030) +#define MT_PLE_HOST_RPT0_TX_LATENCY BIT(3) + #define MT_PLE_FL_Q0_CTRL MT_PLE(0x1b0) #define MT_PLE_FL_Q1_CTRL MT_PLE(0x1b4) #define MT_PLE_FL_Q2_CTRL MT_PLE(0x1b8) -- 2.20.1