Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 4 Aug 2021 11:23:48 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Arend van Spriel <aspriel@gmail.com>
Cc:     Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        Chi-hsien Lin <chi-hsien.lin@infineon.com>,
        Wright Feng <wright.feng@infineon.com>,
        Chung-hsien Hsu <chung-hsien.hsu@infineon.com>,
        Kalle Valo <kvalo@codeaurora.org>,
        Lee Jones <lee.jones@linaro.org>,
        Zheng Yongjun <zhengyongjun3@huawei.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        linux-wireless@vger.kernel.org,
        brcm80211-dev-list.pdl@broadcom.com,
        SHA-cyfmac-dev-list@infineon.com, kernel-janitors@vger.kernel.org
Subject: [PATCH] brcmfmac: uninitialized variable in brcmf_fw_get_firmwares()
Message-ID: <20210804082348.GA32730@kili>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.10.1 (2018-07-13)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from kili (2a02:6900:8208:1848::11d1) by LO4P123CA0368.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.20 via Frontend Transport; Wed, 4 Aug 2021 08:23:56 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2e5a0501-1b8b-44e2-4fbc-08d9572137f7
X-MS-TrafficTypeDiagnostic: CO6PR10MB5412:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <CO6PR10MB5412A849AF8C3F0CB2A36AAF8EF19@CO6PR10MB5412.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:431;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: BXTstLZDlEwMj/YRIfNRi7GUwiGXkkZ9jk52qZ0svH9RQoH+hdKaLkYGJKmaU92tFAmCP6x8+hQWqsUFkrgNUVioT+Y9RsAY0jMTl19P1M+2cuwsDSrPxP7SXWMxdyfPY2CSz43rZhXQPMPoUj5s/snZIDihwhVo4ZDju8mchESN82xwpQFeh8Qbje+gluKQMG8rgK8BaSwxThxo4wumSQBYfTyGL8pIED269V2+jB9Kzep8ty6eA+3Mt7sRF39SIK3jEhgn7jVKW4wd3KY5ngt/z2fosjVJ6K8+ypdoe3PQgT/Yj4Dt2344sqBU31KZZo0ysYv02CzhsjmphoCzJzFXlVXihnESdjEuJxZFrBY1q/tzNNHAnevoN7wCRVP+VSgyUPerHEiqIq2vUk0bxFj0xi/jay12zAgGG84ZcM1XPpSFEtkycD6SXI3hCG+YGKSpe5J60arooB+25+AcQAnSimiZR9++LxlCqCVRefgTMNLcYy0t6+8IEtZMCdvB41ZAi2/VE2QhQwKKAypkvqzHKSWIxsPof+J1AkEgJBg5+//yraGvxN/0JMwGLvuGOoF6XsxJtHdJns/WJTP7MOJDYZA1uIJa7juf3enlR4oLyWP6oqe2JbwTgpqOil4qaBg94LigAC0FjEAjAQ27FA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(366004)(376002)(136003)(346002)(39860400002)(86362001)(8676002)(8936002)(4326008)(6666004)(33656002)(9576002)(83380400001)(55016002)(5660300002)(54906003)(478600001)(44832011)(7416002)(9686003)(52116002)(316002)(1076003)(38100700002)(33716001)(4744005)(2906002)(6916009)(66476007)(6496006)(186003)(66556008)(66946007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LMbn/bwYs/skSfIx/NZJRXYuDaGwWB7psQHNAFl+mYpLDZMj7YG2w9jZzj7/?=
 =?us-ascii?Q?SH+tlbP2cC4N2UeqZ5VqevFdFI/v/5SKNOaLe4Vx/L7GA632fWqxuZaKxh+6?=
 =?us-ascii?Q?sUFuFm1E3o2jZwROOrstvE2R3AxHiJtlkzdkb30zgfcDWXj/dDg1C/Pf3cyT?=
 =?us-ascii?Q?SSiVC6rfmBVe9FHWwc7gbgPkmMKIe37u+8fm1fSd3pdvX7GAEiI3ikXrXiMg?=
 =?us-ascii?Q?zv8lmHasmVrTpMhGtyN9vLcr/H35oj1jNam85gOUqZxzgYDc0LNk+rVC8vBE?=
 =?us-ascii?Q?o8tWwHHSFegswsk8DWcj64lWX+zRzV5z19VEKURAnyFbMqLQsLBDWOuOQTpG?=
 =?us-ascii?Q?2cNtmvIsE94Y4FI7g4Oyvg+ufEovL5bxlbH2KzRSsQcrXwLmVv3PAv67ifIq?=
 =?us-ascii?Q?WJEt2lNzusTtjL/EvHUabsUYfbUTzkdDiSADbCy68t+xUCGYrcqcJGof01CG?=
 =?us-ascii?Q?uZqXGz/ysE5biwIYybV6t5lXp74Zt9NgUJokH3PJoCCXKXSLVer5W4BaKLS0?=
 =?us-ascii?Q?HHOUtjCDs0+HfgWJJfgZai7yhihFUKSRJYBQbo4uBhGerjPNKzOATvJ4zmkB?=
 =?us-ascii?Q?H/1D9A+fz3YnGFv2nLymLUyFjPqqjfTYKg8urUgZKHElnEq2PNkMOo5OqoH6?=
 =?us-ascii?Q?Nk2fq5sDSuG2HfKYdXyQzu5dwE7Cl1yKnG/II9gyjZE97xlborAgelXYvaSi?=
 =?us-ascii?Q?a2bg8t6wrhHejc57kPJLoVsmEUtNV8iyyLVN97H9/y+d4OZ2UHMFD3K+10xX?=
 =?us-ascii?Q?n1CC8fCbw5my1NJd5Hopjef/43chis5YlBeZitKLV0xrwQpIS4zwm44Mg5Yy?=
 =?us-ascii?Q?zm5nE1JS3o2NZkgPIwVzUGSinwWSXKFrQFeae0CCwInSaHtChmrHqpJMtKNt?=
 =?us-ascii?Q?5t8P5B5U6zR1EYSXhDymmSortrBrTReMd6pcmwd0C8chcs2Sp0gk2afMg6PZ?=
 =?us-ascii?Q?AGwdhYtysxoJRDsd1TgKPUrbVWs1vsEfBGVobF5NAqHJwmPomUVaGV5LG9II?=
 =?us-ascii?Q?j5bGeuzX8duesRAtZJrHdkBR645qTCSCH1FJbS/7zvcg1EmHTPSUjUR8mHIg?=
 =?us-ascii?Q?UkcndSoY37UmK7wwtDDDX4RrT9+fKI3/Lo/X/xZsxA9IuT1zzRaJpLc0njY4?=
 =?us-ascii?Q?qgJO8ncT8qMn/qWNk5VoLs9jtp68x3SXARo6XbAKhQ6meUM7xMtH92AZeXlS?=
 =?us-ascii?Q?JBif5h1WZBGi1gAKQux3y1e0ikV+E7/iOqMJlDpTMgOexrepWcJ2gVt+vETI?=
 =?us-ascii?Q?qOjRE3EmXloFr3Ie7Umu8Tnd1xlYDyqkIG5jlTlcAPHxJ3aWdTc/APmeu7qp?=
 =?us-ascii?Q?oXJS59pzx6zZyjxuk/ACFK+E92xKo3SnoH2gj7cWUslAgS3abTrPBz/VNG6i?=
 =?us-ascii?Q?oMz9bkY=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2e5a0501-1b8b-44e2-4fbc-08d9572137f7
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2021 08:24:03.5417
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ckqPVldifmhQjyt8aZCL/VRSqYC80GSSvmO/J/l0n8qan5T8JjRQ2ziKhoYpI3S9fo8HeXWHBNf6EyGZNE7q8nRISZCf5izFz/qZm8F/AEg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5412
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10065 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 malwarescore=0
 suspectscore=0 mlxscore=0 adultscore=0 mlxlogscore=999 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000
 definitions=main-2108040041
X-Proofpoint-GUID: -kWrT9O1P3JnDF5NyinvmzftZUHwP3q1
X-Proofpoint-ORIG-GUID: -kWrT9O1P3JnDF5NyinvmzftZUHwP3q1
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

The "ret" variable is used without being initialized when "alt_path" is
false.

Fixes: 5ff013914c62 ("brcmfmac: firmware: Allow per-board firmware binaries")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c
index adfdfc654b10..4f387e868120 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c
@@ -680,7 +680,7 @@ int brcmf_fw_get_firmwares(struct device *dev, struct brcmf_fw_request *req,
 	struct brcmf_fw_item *first = &req->items[0];
 	struct brcmf_fw *fwctx;
 	char *alt_path;
-	int ret;
+	int ret = 0;
 
 	brcmf_dbg(TRACE, "enter: dev=%s\n", dev_name(dev));
 	if (!fw_cb)
-- 
2.20.1