Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp66150pxt; Wed, 4 Aug 2021 16:00:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQbcPBu2N9kxp1e/3MLSxP9dK/MVbpTpOBf7Tb/OwJhCM0Cz9ci0Xz4gSmP+44SnvgjoWn X-Received: by 2002:a17:906:1355:: with SMTP id x21mr1495348ejb.490.1628118017084; Wed, 04 Aug 2021 16:00:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628118017; cv=none; d=google.com; s=arc-20160816; b=WDpAMYcQNCWwRsUcmWHhC+ifqkKYukjYGA53rimLvFi1i2lXLSuJbdqrLmCnLGdAxY Mshu9wbOCzLn60iGPY9uT2ColgssyO93M04K6goFao190Ltgi+W0KHgpTyCGU8IZpiLP ixRYO1SRpJ44mQtCv1AxNE8uQ+hv2ovXj4gW9m7eFyxzIzjB2a5USD7HPdrTL2MI03UJ rjpdAjePGARZBspTQ6auzA/ejHxDU306vrn3h42QOuHHAJ4ArkFa/us4UgAW6M+Op8H7 okP6Shx/pCcSEAtSRVIKsv+FYCv5of+xySkNxp0qEiEzWiok0wxsX6Qbzejckf7qV4lS U04Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=wvjJXIAyDtPL/Ndk/Btj800bsnjEboaOCHdw/tjENlE=; b=YdOEhCszlDuALKfjZ8VpFXmA/Fpd6j8+wKJcwDBJGtdCRao4rX3obTyvCLPHhFIhmc v8DSnH12WbP1IPBZarOyZfGyvp2GL3+JkxB95Cn0TcCwXqFlXKpKR3BaQXx35dcohmyV 9UZHkRoubRdfDavpM7OgTfbIoaroA1qaVFF5B2W5IsQwpo8FWFrzR0r79+xhN1D/i6DM wHisd+3qSL8MrDPQ14NtVKwN6wQ7cabGUpfZzJjHE8NoShrdiQ2SM5YoPAOzwwSTOaJv OiURtEgdhPQ/oWox+7NQodJEhHlTFOUQATAkQMzXAn8PBmoY5wuxDETQUM4aZ4+eDglW ldZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=NvgNV1Bm; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h27si3337614ejl.425.2021.08.04.15.59.52; Wed, 04 Aug 2021 16:00:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=NvgNV1Bm; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234022AbhHDWqY (ORCPT + 99 others); Wed, 4 Aug 2021 18:46:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229775AbhHDWqX (ORCPT ); Wed, 4 Aug 2021 18:46:23 -0400 Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A49C5C0613D5 for ; Wed, 4 Aug 2021 15:46:09 -0700 (PDT) Received: by mail-ot1-x32e.google.com with SMTP id a5-20020a05683012c5b029036edcf8f9a6so3209728otq.3 for ; Wed, 04 Aug 2021 15:46:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wvjJXIAyDtPL/Ndk/Btj800bsnjEboaOCHdw/tjENlE=; b=NvgNV1BmOyqa+ONMf/ndrJq3FcJ7c5LtBMHtnvF0HO93XBKfRK4RrR34Cc/uKakySh m7ZcUjTOAWSAAigDKMZlCvF7srO4sHeRrHLUrLoJxffYgyd+VQBKS40QzRAd432FN48J RSWCYqHIZn95SJUMdLqpkiUnfZs96ZUZQ7ggQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wvjJXIAyDtPL/Ndk/Btj800bsnjEboaOCHdw/tjENlE=; b=Rov9ejBhSpKGAlvUWg22ywOiuUDM9Y9mF2Jrdp4WK4s+2n0RHuYOAclQ07gmy1RYIy BConA23glf36mLY2cD0Uz+1xS8oVIjDczMtNWKoUHMcQ7/zUFA0tepGwIMDTUl9UjVIs TW2GtPbzg4qkeUTLujU57pMm+vG7tVCqbMNFKCgTiD1tNen34NCsZYNxR2G+uzI2CExn 5gA65aaIQ1T9Xpn+o4FhD8lzPy1Z9KmXlyNs3LZg1sGWa+KN7jWZUXeexXnugACkuf+h J5tajix7sM1wCORz7vEoK6rMfSEBL3IsYQvMbpf1WCUpkjHB01PKEdsB8VRzGgmCrTwZ s42A== X-Gm-Message-State: AOAM532//2iFetFEmmDRIK751JECG9Q6FN9it5PDt787lohelQSFWIAa zat1hEcJ1/QMvw6niENoshoM2iAenA3UIQ== X-Received: by 2002:a9d:6d16:: with SMTP id o22mr1402460otp.336.1628117168615; Wed, 04 Aug 2021 15:46:08 -0700 (PDT) Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com. [209.85.167.169]) by smtp.gmail.com with ESMTPSA id p8sm394988otk.22.2021.08.04.15.46.06 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Aug 2021 15:46:06 -0700 (PDT) Received: by mail-oi1-f169.google.com with SMTP id q6so4771496oiw.7 for ; Wed, 04 Aug 2021 15:46:06 -0700 (PDT) X-Received: by 2002:aca:110d:: with SMTP id 13mr7258895oir.77.1628117166068; Wed, 04 Aug 2021 15:46:06 -0700 (PDT) MIME-Version: 1.0 References: <20210804020305.29812-1-islituo@gmail.com> In-Reply-To: <20210804020305.29812-1-islituo@gmail.com> From: Brian Norris Date: Wed, 4 Aug 2021 15:45:54 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] mwifiex: drop redundant null-pointer check in mwifiex_dnld_cmd_to_fw() To: Tuo Li Cc: amit karwar , Ganapathi Bhat , Sharvari Harisangam , Xinming Hu , Kalle Valo , "David S. Miller" , Jakub Kicinski , linux-wireless , "" , Linux Kernel , baijiaju1990@gmail.com, TOTE Robot Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, Aug 3, 2021 at 7:03 PM Tuo Li wrote: > > There is no case in which the variable cmd_node->cmd_skb has no ->data, > and thus the variable host_cmd is guaranteed to be not NULL. Therefore, > the null-pointer check is redundant and can be dropped. > > Reported-by: TOTE Robot > Signed-off-by: Tuo Li Tested-by: Brian Norris Reviewed-by: Brian Norris