Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp620909pxt; Thu, 5 Aug 2021 07:46:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw9+ObcYHvJeIJwl/kJOTcoJ5/xNHD2LogjzjsJJMxzP4TPj2ozEnyEH6220ghH87yQUvtH X-Received: by 2002:a17:907:1c08:: with SMTP id nc8mr5355504ejc.514.1628174778210; Thu, 05 Aug 2021 07:46:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628174778; cv=none; d=google.com; s=arc-20160816; b=z7zt+EjRVw5dPRwwOFTH3Lscc97BPk+534Olcu+8zdTBFcz3RCFFLUPQG4Wq6nE9Sl A+jGl+7MZukzLSkNdjxwmJS5QYjc/dpRw/jtvHMcNAcWmivUVtiuzGRrzjWd+s5XmxOc xnLc1eOMQbkJPa+ugFhoju9nt/iCOAFahaqobLOKwk28Det2PRf8LOiKfCuntcKnorVx RT96xUk6oSp8T4WGR5cIshJpflVdqJaKBBtUsyKddGrPlM9tzAyU1JMOL5uVQ98u+mSM IwCezZh9q82+shuAaN3pGK9qvGHIG//nDtAROmsLLHqiu6kL1zkN23uCROISO33DczhZ QiWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dmarc-filter:sender :dkim-signature; bh=bcr6vJTCmnIH6dipHg22HDP4Lj3skF7+z+y098CkOwU=; b=JzFcexeS5+xXq0lkdVkhYq22eHzBFm0BO5kHSztg9Z3Aq1jIsJqEk+SSS18V769WY/ D/Dx4gELFvzeNMlw6BXc/pM3June91rCZwj0u+pu+LfiBON33I2x0UGRv8BBMmdJ4zQR 2cEMCDShdpvfptILDKViDE9sFFCHlByMVbxdcP/07zuLT1VjEqfmY26AGgGts79R19Zl O+f3sbtV9W4iPAHUWBVr058zoJLQuO7dJ0NK5QnjV01gtZtsyHpnbwAQGz/vRv1mibzK ALRernFHg1u910fTErVNcJYMIiw2T9oLcYcTUQ8+xJa1uplPepjVTTae4ebhSxVG2tS1 poAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=Fo4mxh4c; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f19si5668367eds.480.2021.08.05.07.45.54; Thu, 05 Aug 2021 07:46:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=Fo4mxh4c; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241352AbhHENyg (ORCPT + 99 others); Thu, 5 Aug 2021 09:54:36 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:32115 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235180AbhHENyf (ORCPT ); Thu, 5 Aug 2021 09:54:35 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1628171661; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=bcr6vJTCmnIH6dipHg22HDP4Lj3skF7+z+y098CkOwU=; b=Fo4mxh4cKkbiA4iy+pywh/yDDLIuIMKYTq78IW4d3UGbaXBinONGmjLw9P081u2kQt/Q299k +AcMTXFgbAjRAkOBFjG8wX9Z7SLEeziSVdVtAnvkau64VyMcv3zy2lIuQG3XZ5Tuemnczdhv 70Pxr90mZZHRw1qrB227XJSxprw= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-east-1.postgun.com with SMTP id 610bed7db4dfc4b0ef3c8f9e (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 05 Aug 2021 13:54:05 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 4FF41C43147; Thu, 5 Aug 2021 13:54:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from tykki (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id E3DC7C433F1; Thu, 5 Aug 2021 13:53:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E3DC7C433F1 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Linus Walleij Cc: Colin King , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-hsien Lin , Wright Feng , Chung-hsien Hsu , "David S . Miller" , Jakub Kicinski , linux-wireless , brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com, netdev , kernel-janitors@vger.kernel.org, linux-kernel Subject: Re: [PATCH][next] brcmfmac: firmware: Fix uninitialized variable ret References: <20210803150904.80119-1-colin.king@canonical.com> Date: Thu, 05 Aug 2021 16:53:54 +0300 In-Reply-To: (Linus Walleij's message of "Tue, 3 Aug 2021 21:14:07 +0200") Message-ID: <875ywkc80d.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Linus Walleij writes: > On Tue, Aug 3, 2021 at 5:09 PM Colin King wrote: > >> From: Colin Ian King >> >> Currently the variable ret is uninitialized and is only set if >> the pointer alt_path is non-null. Fix this by ininitializing ret >> to zero. >> >> Addresses-Coverity: ("Uninitialized scalar variable") >> Fixes: 5ff013914c62 ("brcmfmac: firmware: Allow per-board firmware binaries") >> Signed-off-by: Colin Ian King > > Nice catch! > Reviewed-by: Linus Walleij I assume this will be fixed by Linus' patch "brcmfmac: firmware: Fix firmware loading" and I should drop Colin's patch, correct? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches