Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp333361pxt; Fri, 6 Aug 2021 03:14:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzeAWwAb82mEmu9Q/BBZ4ZMdQIwWNJ5e+JgwvgJqpcUiP4/znKnYsyVuxDHDrY+pgn5F77m X-Received: by 2002:a5d:9906:: with SMTP id x6mr436854iol.23.1628244871574; Fri, 06 Aug 2021 03:14:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628244871; cv=none; d=google.com; s=arc-20160816; b=N+XnZ/q2p6I0Wm33+7LE5/XJntAZAjr0RHedGjv8I1lxp5zV5LOb+8i3iBJshumTlr yWU79I90ba90skFrInIUsqlKbC2apUDlUq9ZQlFbplwyfGI0LXOTTUvSvdhKAX/jfKUM KIgupf/eGQrXOFgSAT0kYg3xJyGBgVfwMDZUrZxhSGIjKwdD1RxkGQfKI0ubSLRJGsXA 5D9ddve7SoDis9YPaZYygfTmuIV0LPKZUnqxiacbn3hJP6Ceg51mFNXPHBvVlnzoQMI8 YOTO5puUyda5rzMQYkYAiTR2duDWt5PQizz2M2ibsGfC1tJJrVSshPxPM1C0aHg3CgbU uCEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=GtlwxJGb7XtoulFrcH3vkorKxrRtS07qNf7k549KKWU=; b=xjEKfU8GDMK2ywa40naFXnPfkbFQitRItiPk10CbmUYG2xI/Nkr3aTow1UUHOeh0lP NNIdYzIRQfzZldOZLlnu4y1ZAQJqicsDVqBDJ3bgRXfBNuQK2cUo0TWqkL1isJc3uLmU LAVAtT77dsloYhEgvdIIMu9NvTd8wkXbKARXoeWz3SxZ2admAWpl37t4SdJtdJA7Y+tN 5ztSSwvItaxYK3BjY19AzMvRmiEiDa7b+VvHTw1ZFBnPxD2spXHp0pKtUhCbeReGMm0/ tjrcpd4R9wUv3E9qdPJ+MOj3hgXW1rvmRJYaG0t4JJpQ7dH1HvKsJ7oTn9en1x/WWLhw BLYg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g14si9718836jat.28.2021.08.06.03.14.11; Fri, 06 Aug 2021 03:14:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244941AbhHFKNf (ORCPT + 99 others); Fri, 6 Aug 2021 06:13:35 -0400 Received: from amphora3.sui-inter.net ([80.74.147.35]:51798 "EHLO amphora3.sui-inter.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244980AbhHFKN1 (ORCPT ); Fri, 6 Aug 2021 06:13:27 -0400 X-Greylist: delayed 588 seconds by postgrey-1.27 at vger.kernel.org; Fri, 06 Aug 2021 06:13:25 EDT Received: from [IPV6:2a02:168:6182:1:7643:c4ac:7a96:f4a3] (localhost [127.0.0.1]) by amphora3.sui-inter.net (Postfix) with ESMTPSA id 1068DB042353; Fri, 6 Aug 2021 12:03:19 +0200 (CEST) Authentication-Results: amphora.sui-inter.net; spf=pass (sender IP is 2a02:168:6182:1:7643:c4ac:7a96:f4a3) smtp.mailfrom=rs@hqv.ch smtp.helo=[IPV6:2a02:168:6182:1:7643:c4ac:7a96:f4a3] Received-SPF: pass (amphora.sui-inter.net: connection is authenticated) Message-ID: <26f85a9f-552d-8420-0010-f5cda70d3a00@hqv.ch> Date: Fri, 6 Aug 2021 12:03:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.0 Subject: Re: [PATCH v2] rtl8xxxu: Fix the handling of TX A-MPDU aggregation Content-Language: en-US To: chris.chiu@canonical.com Cc: code@reto-schneider.ch, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jes.sorensen@gmail.com, kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org References: <20210804151325.86600-1-chris.chiu@canonical.com> From: Reto Schneider In-Reply-To: <20210804151325.86600-1-chris.chiu@canonical.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hi Chris, On 8/4/21 17:13, chris.chiu@canonical.com wrote: > The TX A-MPDU aggregation is not handled in the driver since the > ieee80211_start_tx_ba_session has never been started properly. > Start and stop the TX BA session by tracking the TX aggregation > status of each TID. Fix the ampdu_action and the tx descriptor > accordingly with the given TID. I'd like to test this but I am not sure what to look for (before and after applying the patch). What should I look for when looking at the (sniffed) Wireshark traces? Kind regards, Reto