Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
To:     Kalle Valo <kvalo@codeaurora.org>,
        Emmanuel Grumbach <egrumbach@gmail.com>
CC:     "Coelho, Luciano" <luciano.coelho@intel.com>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        "Beker, Ayala" <ayala.beker@intel.com>
Subject: RE: [PATCH v3 3/4] nl80211: vendor-cmd: add Intel vendor commands for
 iwlmei usage
Thread-Topic: [PATCH v3 3/4] nl80211: vendor-cmd: add Intel vendor commands
 for iwlmei usage
Thread-Index: AQHXif1wGoEh3hgq1EWl9IMc9He2FqtoYGOA
Date:   Sat, 7 Aug 2021 18:32:26 +0000
Message-ID: <SA0PR11MB47521818C15629E58B99525AF2F49@SA0PR11MB4752.namprd11.prod.outlook.com>
References: <20210623141033.27475-1-emmanuel.grumbach@intel.com>
        <20210623141033.27475-3-emmanuel.grumbach@intel.com>
        <87k0mji43p.fsf@codeaurora.org>
        <CANUX_P0d0jrq9x99jM824oKOhmi0Wa5WqhECMsX=hd269H6atw@mail.gmail.com>
 <87sfzoc9bw.fsf@codeaurora.org>
In-Reply-To: <87sfzoc9bw.fsf@codeaurora.org>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dWvPIhjkuJRinbhf5/kqMK4TjRshy9nsQA7ruwLYdbMInCWojxBs88v0CenR?=
 =?us-ascii?Q?iMvTBsJUuYutTExzhvIqvciemzTpoyjTqX0zOX5iFD+Uyf93Y+74KEq3D82M?=
 =?us-ascii?Q?wRN1jXL3hloXFi3uSVzZaeQrQNjF0ERXiJcFpbclzvahV66BZvKzMdPAiB20?=
 =?us-ascii?Q?dhRvBp4rGB3X4KodsjHbpNAhMIFYYRl+Fcajdr8L1TdDyB9jO5489FPBaP+i?=
 =?us-ascii?Q?Q6zQzX/ytBJnXK8THN3aj+PMA1jjLDVzKOf5f7W0JAP8hXcgawEqUOwj7PKh?=
 =?us-ascii?Q?qWEHZx68CmoMMnDpAzT4jpX6+82atrWWayAz6i01j9UPiO/sF+SaLT4484Eo?=
 =?us-ascii?Q?q6pbHUY/mQkb7eo9HLozE0dyWujBwlAmkq+4UxXmP8VpRm2ukRS6N0XB5xE6?=
 =?us-ascii?Q?vgyFDpZcRx36QkCuJIQkIK/DssRFA8CkAPZ9qbNCQ8rJI/v7CY1LHJ74Li4B?=
 =?us-ascii?Q?vVKx+Ahe5ZoYL5BkcZon6mKHRMHfem9n7xhbSVLiY12MjQYgl/ootStKhUat?=
 =?us-ascii?Q?CTtM0G9OB4R2kOcG6bPsXUSX369KovW5nprQnRn0f0rh+p7MsizwPsroqIZn?=
 =?us-ascii?Q?eT9eNOP1bxaVfre0xRN1QiGjANcXZ1I1pkHRlUeyLzq8ArUC4qhZJSm+i9xm?=
 =?us-ascii?Q?drT4q4qxKAf5mUJVULfa0Hg6EV+GPoSu0I5jobwW+0WYi0uJ/kHUEz5owYkr?=
 =?us-ascii?Q?H8mx2rBPlumg31mmqMJiqYg5LKKrsjM+qgVmKUT/j7rg/rCulVmgtyITaEMt?=
 =?us-ascii?Q?fECXXCki7pL2pUN2oOk0me/v/8RpwnRhheQEnms+kLSSU30l6FONfKHYRdQO?=
 =?us-ascii?Q?/7yCgClKGtD5JbJc4pTS5X03Yrv5DPxdnfAEn1AZNgD8Sd7qIkcwK9mkHDtd?=
 =?us-ascii?Q?ABAuyWvj4moedbqAZ0bcA7QTk/nEl25/zATjRV6q3ABVYOXNjTRgBB0D+MOY?=
 =?us-ascii?Q?0TVuinOxOnpvlATRK44nJclLAnVFKLkI0KRPmr6RdkS8kfm2wkbE1MmAP5pR?=
 =?us-ascii?Q?wE6B0SNdjmu9YdmrSkcyX2/+f3+VBgzzaaqgX7/WDUjftb0lGKLHHoNDFbBP?=
 =?us-ascii?Q?i3mPBd/K6AeaPcV8tT2+ZTEXwiascpSakVUFoGDqSjFJMGDiZYLHGxWHCV8a?=
 =?us-ascii?Q?8UrDzZKFGP2/vfZVAr1wUOxzTY8MdSHCz5CkEcV1GoLIJqvfucHCM+/low8x?=
 =?us-ascii?Q?VXDjM4aD8Zj9+s2N4NiZ6VH/iG20Str5Gcd5ACNze3TJ4mrreV0el57RnRRh?=
 =?us-ascii?Q?DghWNLiCxo5FdzkTG/d+/16GOISKTvH7/JEBbhQ3ExgcxNWzr8clXVw11m/Y?=
 =?us-ascii?Q?DfI=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA0PR11MB4752.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e7c7155c-9752-4f50-4d79-08d959d1b4ef
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Aug 2021 18:32:26.7418
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: krfege+Vo7Y0Tp/D/U6xLNoougYbhN1bWPiX8GSlnyAljSM4lKoHQg0xkuWsmg8moU5s5iAjlLJZs1jHjV9OTErNjZ9TG77mNYObz6SsmOY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4986
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

>=20
> > On Thu, Jun 24, 2021 at 8:09 PM Kalle Valo <kvalo@codeaurora.org> wrote=
:
> >>
> >> Emmanuel Grumbach <emmanuel.grumbach@intel.com> writes:
> >>
> >> > iwlmei allows to integrate with the CSME firmware. There are flows
> >> > that are prioprietary for this purpose:
> >> >
> >> > * Get the information the AP, the CSME firmware is connected
> >> >   to. This is useful when we need to speed up the connection
> >> >   process in case the CSME firmware has an TCP connection
> >> >   that must be kept alive across the ownership transition.
> >> > * Forbid roaming, which will happen when the CSME firmware
> >> >   wants to tell the user space not disrupt the connection.
> >> > * Request ownership, upon driver boot when the CSME firmware
> >> >   owns the device.
> >>
> >> Vendor command requirements are documented here:
> >>
> >> https://wireless.wiki.kernel.org/en/developers/documentation/nl80211#
> >> vendor-specific_api
> >>
> >> The commit log is not really answering to those. For example, how a
> >> user would use this? Or is there a user space tool?
> >
> > We intend to send those command from the NetworkManager.
>=20
> I'm not really fond of the idea that NetworkManager uses nl80211 vendor
> commands, sounds quite hacky to me. I would prefer that NetworkManager
> uses generic nl80211 interface so that it works with every driver. But I =
need
> to look at v4 to understand more how this all works.
>=20

You'd need to look at v5 which I already sent.
Nothing of this can be generic, because it is really Intel proprietary. CSM=
E can only use Intel devices by design.
It uses a proprietary bus implemented only in Intel devices (and not even a=
ll of them, only the ones in systems
with the vPRO sticker).
I already touched base with the NetworkManager's maintainers about this. Th=
ey asked the vendor commands
to be upstream in the kernel, so this is what I am doing.