Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
To:     Kalle Valo <kvalo@codeaurora.org>,
        Emmanuel Grumbach <egrumbach@gmail.com>
CC:     "Coelho, Luciano" <luciano.coelho@intel.com>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        "Beker, Ayala" <ayala.beker@intel.com>
Subject: RE: [PATCH v3 4/4] iwlwifi: mvm: add vendor commands needed for
 iwlmei
Thread-Topic: [PATCH v3 4/4] iwlwifi: mvm: add vendor commands needed for
 iwlmei
Thread-Index: AQHXif7lxFnULUNnIESM18ARXXkclatoYS8g
Date:   Sat, 7 Aug 2021 18:34:34 +0000
Message-ID: <SA0PR11MB4752D9B34C2A60B85CA3E5F3F2F49@SA0PR11MB4752.namprd11.prod.outlook.com>
References: <20210623141033.27475-1-emmanuel.grumbach@intel.com>
        <20210623141033.27475-4-emmanuel.grumbach@intel.com>
        <87fsx7i416.fsf@codeaurora.org>
        <CANUX_P3HWWBkeHHSw+-wdQEBFNF1V+GWRDFiEerH7NhksRvOzA@mail.gmail.com>
 <87o8acc8v1.fsf@codeaurora.org>
In-Reply-To: <87o8acc8v1.fsf@codeaurora.org>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JcUwZHhjfvpv4Bg3Wexg/kNWeXNtukA39QMBMxg0cN7YH4siFn6FWLl6CjzD?=
 =?us-ascii?Q?1CTfKdQ5s/JxwglqjvkIQTml97oTCBINPzGWSoYwlKfgwe3ytE9Jq5wI1y4M?=
 =?us-ascii?Q?6nKdPmbsuST/4Stdpieg0NHP1Amf9O+r6Oo45YvHA5zM13h6lFNl+JxVS5j3?=
 =?us-ascii?Q?S5xO952VOiPoJIeNI34SuLt9JCCB8QSoPdMBPYSs4k9tqXJa9XHpDhvohx7p?=
 =?us-ascii?Q?INwx+xyhsVz2/Oyfj6om0sMDYRQiw5zjYSbBPgR1gOLx5KgKUNJq88UF7uuu?=
 =?us-ascii?Q?JvRYXS8HpsksVEvI/9ydH5V078pdBgWxtcvevmIns+FWWFia/ZGQKZDwknJa?=
 =?us-ascii?Q?4IokGNZpWSISy0OIZF6E6DL47pBC5G9+3/aldd5vrzYQ2TPajBs5ONb/1KE1?=
 =?us-ascii?Q?KiSKrozHjKppQwIcJ/M3ruWmvkR+tH5PaSHNCUTsSI7j4BSffkz8d+dTjbRs?=
 =?us-ascii?Q?x7rF5+DZLGzvv+AjdqFvJOaB0XyBN0CictpHRUASNEO0w0elqpDmsQrZWj+R?=
 =?us-ascii?Q?ftmNeZel+syv30N5GWqJZyt/PtONZC9czr+aMqtiU8pNC2J9KKmvf6Jn6/N8?=
 =?us-ascii?Q?oe1hCV15lF6S/qZNU+6Y0rJy50mnlOktVtDfJSlzL05j4DctJGMwq4WdamrU?=
 =?us-ascii?Q?vlC0RnhdgnBc6QPMIEqR7ZOifILeJQAndXsescVAZ4S03rAGC29Q7ky6cYAd?=
 =?us-ascii?Q?plch6RBLYjXLmcZkjlmXM9Ut5xI3CvstLDAAgON/fM5D5ieDK3PagAuFRrea?=
 =?us-ascii?Q?55LkRI3ma0/LrmayfI21YqaonGvdYm4lwlOgHO+jx3ZgSL9piz0yU21GOYfK?=
 =?us-ascii?Q?6B5llllduxaZP3kn05jkDPO1OcWV9O83L7lc5Kd0aUQegqaA/7RBSNM07f9V?=
 =?us-ascii?Q?Hi7TamFlRErr1aNQZWgreuP5DLRHQzVjHqfsHKKndACDkeHuI80sq88KdHSD?=
 =?us-ascii?Q?jjRY1tQfMI8g1BCNrckjJWAmNCHxGfJHBa2WtH2cgEdb4+ZBdmO66b0OTYRM?=
 =?us-ascii?Q?TN5DoB9g9RfFBpdpfF++cbgVVV+HAhvyX2IVApkhpZb/r1qdlhNpGRyqdIlN?=
 =?us-ascii?Q?mYJxybiPl4jLUxYZ0StqHg/GaZEYaxyaW5ryEJGY7mH5kzabCH1Iqy1ThIyp?=
 =?us-ascii?Q?rn3dYnCyNeZ42y20MKtjjWj2mmpts2ifVWbFbY8hdI/lPRdon+FSFl3YYxEA?=
 =?us-ascii?Q?2S2/aIGhvL9TRF/S5NhgeXOaUOe2H1TSG8ptKg383laV/e3H1uNUHuza6hrI?=
 =?us-ascii?Q?uk9EqA/5TIoSND8dNACBXiFCIePYt5t2Mth3tvL8hlr11pPHWnPKJ+gTA8kU?=
 =?us-ascii?Q?vneKbmuuctezW+z07+S0MNAq?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA0PR11MB4752.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1cb430be-be12-42c1-99f3-08d959d200e3
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Aug 2021 18:34:34.1032
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: c6gLl0S38YKt9z6E3AJ8jbo+Y8zNgCj8kcDH2e+Sd1lQXS0w7IEYn1FuvHIMaXpiGVFgNFIJP4ifh/2ty0OQBwuXH6qUdjC1KasVkx67dJI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5017
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

=20
> > On Thu, Jun 24, 2021 at 8:13 PM Kalle Valo <kvalo@codeaurora.org> wrote=
:
> >>
> >> Emmanuel Grumbach <emmanuel.grumbach@intel.com> writes:
> >>
> >> > Add the vendor commands that must be used by the network manager
> to
> >> > allow proper operation of iwlmei.
> >> >
> >> > * Send information on the AP CSME is connected to
> >> > * Notify the userspace when roaming is forbidden
> >> > * Allow the userspace to require ownership
> >> >
> >> > Co-Developed-by: Ayala Beker <ayala.beker@intel.com>
> >> > Signed-off-by: Emmanuel Grumbach
> <emmanuel.grumbach@intel.com>
> >> > ---
> >> >  drivers/net/wireless/intel/iwlwifi/Kconfig    |  11 ++
> >> >  .../net/wireless/intel/iwlwifi/mvm/Makefile   |   1 +
> >> >  .../net/wireless/intel/iwlwifi/mvm/mac80211.c |   2 +
> >> >  drivers/net/wireless/intel/iwlwifi/mvm/mvm.h  |   9 +-
> >> >  .../wireless/intel/iwlwifi/mvm/vendor-cmd.c   | 186
> ++++++++++++++++++
> >> >  5 files changed, 203 insertions(+), 6 deletions(-)  create mode
> >> > 100644 drivers/net/wireless/intel/iwlwifi/mvm/vendor-cmd.c
> >> >
> >> > diff --git a/drivers/net/wireless/intel/iwlwifi/Kconfig
> >> > b/drivers/net/wireless/intel/iwlwifi/Kconfig
> >> > index 629aaa26a230..f91516d08b28 100644
> >> > --- a/drivers/net/wireless/intel/iwlwifi/Kconfig
> >> > +++ b/drivers/net/wireless/intel/iwlwifi/Kconfig
> >> > @@ -92,11 +92,22 @@ config IWLWIFI_BCAST_FILTERING
> >> >         If unsure, don't enable this option, as some programs might
> >> >         expect incoming broadcasts for their normal operations.
> >> >
> >> > +config IWLMVM_VENDOR_CMDS
> >> > +     bool "Enable vendor commands"
> >> > +     depends on IWLMVM
> >> > +     help
> >> > +       This option enables support for vendor commands, including s=
ome
> >> > +       that don't have their own Kconfig option. Other Kconfig opti=
ons
> >> > +       depend on this one as well.
> >> > +
> >> > +       This is not enabled by default, if unsure, say N.
> >>
> >> Why do we need a new Kconfig option? Why not always include it in the
> >> compilation?
> >
> > I expect 99.9% of the users to want to disable this.VENDOR_CMDS adds a
> > user space API and in a sense, it increases the attack surface. You
> > can claim that I can reuse the IWLMEI Kconfig option, which is true,
> > but we have other features that need VENDOR_CMDS that are not (yet)
> > upstream. So the idea here is that any feature that needs the
> > VENDOR_CMDS will select it and if none of them are enabled (for 99.9%
> > of the use cases), then, we would disable VENDOR_CMDS and decrease
> the
> > attack surface.
> >
> > Makes sense?
>=20
> How do you prevent users or distros from enabling the feature? They can b=
e
> in a hurry, lazy or not caring and enable the feature anyway. So no, I'm =
not
> really buying this. If the interface is not secure it should not be in up=
stream, I
> think only exception to this is the nl80211 testmode interface which is f=
or lab
> or similar use.
>=20

So what do you want?
To make it depend on IWLMEI Kconfig knob and not add the VENDOR_CMDS one?
Fine.