Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
To:     Kalle Valo <kvalo@codeaurora.org>,
        Emmanuel Grumbach <egrumbach@gmail.com>
CC:     "Coelho, Luciano" <luciano.coelho@intel.com>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        "Beker, Ayala" <ayala.beker@intel.com>
Subject: RE: [PATCH v3 1/4] iwlwifi: mei: add the driver to allow cooperation
 with CSME
Thread-Topic: [PATCH v3 1/4] iwlwifi: mei: add the driver to allow cooperation
 with CSME
Thread-Index: AQHXif89mPyUVY6cEEicwpT+rJZpFKtoYcMA
Date:   Sat, 7 Aug 2021 18:38:00 +0000
Message-ID: <SA0PR11MB4752B06F7330E6C14717E113F2F49@SA0PR11MB4752.namprd11.prod.outlook.com>
References: <20210623141033.27475-1-emmanuel.grumbach@intel.com>
        <87bl7vi3o1.fsf@codeaurora.org>
        <CANUX_P3QE9xNnQLT=mHNDp4VCv37Bcjuvn9O1wQ4Btejjkbrvg@mail.gmail.com>
 <87k0l0c8pa.fsf@codeaurora.org>
In-Reply-To: <87k0l0c8pa.fsf@codeaurora.org>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6yLzPx2WrWQk6t/58mkL1IBBviWCWVPLrPll/BuMtxbpIgy3RUMiRD7CEcDK?=
 =?us-ascii?Q?Kfw5Wl9Xrp7uE/XvSko7k+DD+5VzUhzMFV/3/XvEoDLmtm6xdkNt/5AEOxOH?=
 =?us-ascii?Q?7r9ynymeXFBg0PZGH00OqbLkLR1pKy2400Zacq1RVntqy/XsacX5atd2Sxd4?=
 =?us-ascii?Q?BVuhLO59+8BB3P2OFq7nbdW54niihbaoEFPKXU2dGb8nFcNV+R9s4et8Xyni?=
 =?us-ascii?Q?CoRqspTP+1wXJPgWMDhH33SSTW3weoQ6ALgIXhopERtxG/tmfBgfJSwhUAgb?=
 =?us-ascii?Q?H+0xeFtquLD9EAyacS7CAsM5tE1JORdIeMZuIWUs/DVGB1dPrEiXFPMD0O4A?=
 =?us-ascii?Q?s7SMpJ7e39f9cDe1sgaWBN3IMFsi0RT87ed7iWXIlb7303NqmV7qoesyaz0p?=
 =?us-ascii?Q?76dKXchBdnNzcpBy3Ho8K1xlytTL6UlYMpVRzZNhmBtWcmMULhPkCqIBSbb8?=
 =?us-ascii?Q?2wV0AWUcM4iyeMfwbl1BvpyEp8PgUqyK5/YkUpotAAwRnZPQ05SiPIuEzmxw?=
 =?us-ascii?Q?aEiOM7LKstMwofH5xTHBgQ5tKM8l7hKQhZhLhLUVF8xjZWlm308YaHXtDCJT?=
 =?us-ascii?Q?kb5mueBAbkxF8288cLnLf1JvuOiTFG7N00PQqTrv4GT7gCaxInJrBbJVRYmE?=
 =?us-ascii?Q?oQyUTK8XKddYSbe5kXzGLxwBuMcCsEzOoFXebiCPvGCWIBmS19JErxPysfVF?=
 =?us-ascii?Q?79cvPeXt0zwZrNoQWjYeh8RG5Rew22OmpIEF3AaUpcnktpgtasMdQOgTj6aa?=
 =?us-ascii?Q?Rn0tmswBChLX2rDbEvhJBtt2O9TuTz49qQg9vC1HjEUUUClHndW4MlmJqBW0?=
 =?us-ascii?Q?jr9s7q60D5ZaqSa4aemCooZNXTfSjQU+ph24oLlJDjnQEVA/1HHGBP7krDID?=
 =?us-ascii?Q?ItUYlrCvhsfel/ggnpb7E4Ja9s7OINNBngb4NyJqU87vKajO/PDEiXDUeoZa?=
 =?us-ascii?Q?C8KtjDUVeT062b0uBK4VB/vnCSMWPLo/q4LrWJmvWgBYxsgYQEprW3HjfAVr?=
 =?us-ascii?Q?iiqxfgGZBUUb7lZcf1iRRycrzD7yT02T1Ye1SW8pCfxhWwMxSHBeFKfKL6lT?=
 =?us-ascii?Q?qCJhj6BvLEfsW1QhMSPS0bXj56xEbxKhIxCtUTidvTjtVEDKsYe7kvuMYMR0?=
 =?us-ascii?Q?9u/xevmz4wPPBlK52lYFNnp9vLKdWOTCVm4dcIFwXuTzqc28FDUMS+f8fn8A?=
 =?us-ascii?Q?HCLT42YK4pP/5OTk4U2NrAY4p8qAMVMaCLOR0c26l86120U+5aIb+VV1f9l/?=
 =?us-ascii?Q?GGZUDu0Iqg9w+hD2J8iQr0D9BhETLYLWJxyKYfvhYaGMg2btjn+WuuLNPeav?=
 =?us-ascii?Q?rxavNJRR9qqvjBN2SoGhI0ol?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA0PR11MB4752.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c354f3a2-cc0b-4740-954d-08d959d27be2
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Aug 2021 18:38:00.4593
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YVn33+cCX9QoUlA6qRVzUsRrIg34p2VWuiD9apOIZ1i8OJiYb7FtZSk/nAEd7EZ6juVaSPsiod0fsJIsYnMEbPM/QXklXUTFMQRHEN3GT30=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2544
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

>=20
> >> > +     BUILD_BUG_ON((u32)IWL_MEI_AKM_AUTH_OPEN !=3D
> >> > +                  (u32)SAP_WIFI_AUTH_TYPE_OPEN);
> >> > +     BUILD_BUG_ON((u32)IWL_MEI_AKM_AUTH_RSNA !=3D
> >> > +                  (u32)SAP_WIFI_AUTH_TYPE_RSNA);
> >> > +     BUILD_BUG_ON((u32)IWL_MEI_AKM_AUTH_RSNA_PSK !=3D
> >> > +                  (u32)SAP_WIFI_AUTH_TYPE_RSNA_PSK);
> >> > +     BUILD_BUG_ON((u32)IWL_MEI_AKM_AUTH_SAE !=3D
> >> > +                  (u32)SAP_WIFI_AUTH_TYPE_SAE);
> >> > +
> >> > +     BUILD_BUG_ON((u32)IWL_MEI_CIPHER_NONE !=3D
> >> > +                  (u32)SAP_WIFI_CIPHER_ALG_NONE);
> >> > +     BUILD_BUG_ON((u32)IWL_MEI_CIPHER_CCMP !=3D
> >> > +                  (u32)SAP_WIFI_CIPHER_ALG_CCMP);
> >> > +     BUILD_BUG_ON((u32)IWL_MEI_CIPHER_GCMP !=3D
> >> > +                  (u32)SAP_WIFI_CIPHER_ALG_GCMP);
> >> > +     BUILD_BUG_ON((u32)IWL_MEI_CIPHER_GCMP_256 !=3D
> >> > +                  (u32)SAP_WIFI_CIPHER_ALG_GCMP_256);
> >>
> >> These look just weird, and suspicious. You are using two different
> >> enums but they have to be same values, or what?
> >
> > Exactly. I don't want the userspace to have to include all the SAP
> > protocol header file. OTOH, I don't want to have to translate between
> > vendor commands attributes values and the SAP values.
>=20
> Why not? I assume you would just need a helper function with switch
> statements to "translate" between enums, not much more lines of code but
> a lot cleaner code.
>=20

I disagree that it'll give us a cleaner code.
What we'll have is two different enums with two different values and functi=
ons
that translate from one value to another. This is very bug prone. When you =
want
to debug, you get a value, you always need to think of what type of enum yo=
u're
dealing with.
I believe your suggestion is not good, but since I am tired arguing I will =
do it to
make you happy.