Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: msinada=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 26B78C4338A
From:   "Muna Sinada" <msinada@codeaurora.org>
To:     "'Johannes Berg'" <johannes@sipsolutions.net>
Cc:     <linux-wireless@vger.kernel.org>
References: <1607468044-31789-1-git-send-email-msinada@codeaurora.org>   <1607468044-31789-2-git-send-email-msinada@codeaurora.org> <0f45b43c5a2dd4d0d2839487540611994ec10feb.camel@sipsolutions.net>
In-Reply-To: <0f45b43c5a2dd4d0d2839487540611994ec10feb.camel@sipsolutions.net>
Subject: RE: [PATCH 2/2] mac80211: Handling driver updated MU-EDCA params
Date:   Tue, 10 Aug 2021 19:48:15 -0700
Message-ID: <000801d78e5b$55d46530$017d2f90$@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQEnZdCLZBNC6EG9F8ZPYUSPl+pHHAHggUnZAb6IkuCssPBL0A==
Content-Language: en-us
Precedence: bulk

Hello Johannes,

I saw on your review comment that this wrapper is not needed. I wanted =
to confirm with you if it would be ok to call a cfg80211 API from a =
mac80211 based driver, since that is what would be done if this wrapper =
is removed. Additionally, another reason I have this wrapper is so I can =
place a tracepoint. What are your thoughts about this?

Thank you,
Muna =20

-----Original Message-----
From: Johannes Berg <johannes@sipsolutions.net>=20
Sent: Friday, February 12, 2021 12:49 AM
To: Muna Sinada <msinada@codeaurora.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] mac80211: Handling driver updated MU-EDCA =
params


> +void ieee80211_update_muedca_params(struct ieee80211_hw *hw,
> +				    struct ieee80211_mu_edca_param_set
> +				    *params, gfp_t gfp)
> +{
> +	struct ieee80211_local *local =3D hw_to_local(hw);
> +
> +	trace_api_update_muedca_params(local, params);
> +
> +	cfg80211_update_muedca_params_event(local->hw.wiphy, params, gfp); } =

> +EXPORT_SYMBOL(ieee80211_update_muedca_params);
>=20

I see no reason to have this trivial wrapper.

johannes