Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp4311778pxt; Wed, 11 Aug 2021 03:08:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy2B+gOXYYP3OBFhTLz/cqGXaf3OzXTACO9RtsaYuYmpRTI8iveWnX9j262J+8CfvrkXx1Y X-Received: by 2002:a05:6e02:1354:: with SMTP id k20mr94140ilr.133.1628676489114; Wed, 11 Aug 2021 03:08:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628676489; cv=none; d=google.com; s=arc-20160816; b=iWgn3YXLODUh0gUaiy1zraS3mbnwX4eVPcLy+PW18hQJ4iOZEd1tzH4IjrXt56EWd7 XTyBeDQ4cT9wCcwH4LygmVPiftMmnwzFx5x6ElC23VS9cYUCTn1+dInp7ltZTxKJSYC3 fkOSzAWsSOQOsYZpRV6fX80QTxyWFHwR+H1xO71Xvc1tLWpmy8/80/JT9D9gE8kk+RYx 1xamc3EaQTewIHbOaqUgXfRKCxKwpVQhYvB57S9oR9+FkxZCNBpAwEt8mqN4s8vTxGSi AZI90kCoY9uknkx8RpNwspKxMDi8PisGIrkegjNchQIm+hARbOKp8to0udGYE4UEKSUl iDPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id:dkim-signature; bh=dcT2+AM+V1Yjt155WU2LBABRxISl1osjxMEi3eGGvlg=; b=PBh8Cc9/nxF7sSUh4Wk4r4KxNn/+ikibBfLHm3KZxsXRW2y1W17t7UvefcC2TqC4sl c0m+G/RnvL1RxJOSiW+4r03EL0jG05TGEq5abt/eGJuZh4JJ2K/90sbgRwdPIcng/Amh IjpIHklISJYGzLGOtLow+pwLFOkGW24m+h8UIAt0YJYqt9n3CHAyjZnZMgAdf5GqX+3c MYmxsSCwtLwS/N5zuiAgPtFbZ+5cDXQ6wjvRV0wa55POOfI8d6oKCewwlZD/cF5UnSlL 0ov31qV18eh4/bUVG688M6W5aRP4s7SHXNCZ6w/6A5NUe+LRlGzbT9szwtdB9HxVcY5Z bjdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=CtviNlVI; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y15si29601242ill.98.2021.08.11.03.07.52; Wed, 11 Aug 2021 03:08:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=CtviNlVI; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237005AbhHKKHt (ORCPT + 99 others); Wed, 11 Aug 2021 06:07:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236982AbhHKKHq (ORCPT ); Wed, 11 Aug 2021 06:07:46 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 195D6C061765 for ; Wed, 11 Aug 2021 03:07:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=dcT2+AM+V1Yjt155WU2LBABRxISl1osjxMEi3eGGvlg=; t=1628676442; x=1629886042; b=CtviNlVI9KZUBlaI0JhjcTZEHHh7HsmdmQZd7Gi1rJiFVXl Oc6KmKZJkHzejqpd6RA8mqdgr+GCSOIARPfMRm1uH6DtSO809NjEVO+jywHzD/RK8ITfCi/mTkjBU yaZNRt9SJpPMJCbhAGrwaC0+2v02tZi+53Cru04k3AlqzowHCIKzC8QE3bA7QAwwQC5RjVlQW6utC uLa8tPn4rxHwTsCLctbXZFzHIASKTMIYeCacwd1sH/fWL3we2UErnA3+2G8Ta8zIszyp5be4YYALA cV2ZDnLfDphuQ7MZ22QmA8m7/9H2h8klBLj87Humaml9dYYC9clsheH2YR/8TWtg==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1mDl8p-009AGp-1N; Wed, 11 Aug 2021 12:07:19 +0200 Message-ID: Subject: Re: [PATCH 2/2] mac80211: Handling driver updated MU-EDCA params From: Johannes Berg To: Muna Sinada Cc: linux-wireless@vger.kernel.org Date: Wed, 11 Aug 2021 12:07:18 +0200 In-Reply-To: <000801d78e5b$55d46530$017d2f90$@codeaurora.org> References: <1607468044-31789-1-git-send-email-msinada@codeaurora.org> <1607468044-31789-2-git-send-email-msinada@codeaurora.org> <0f45b43c5a2dd4d0d2839487540611994ec10feb.camel@sipsolutions.net> <000801d78e5b$55d46530$017d2f90$@codeaurora.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, 2021-08-10 at 19:48 -0700, Muna Sinada wrote: > Hello Johannes, > > I saw on your review comment that this wrapper is not needed. I wanted > to confirm with you if it would be ok to call a cfg80211 API from a > mac80211 based driver, since that is what would be done if this > wrapper is removed. Yes, that's fine. > Additionally, another reason I have this wrapper is so I can place a > tracepoint. What are your thoughts about this? You already have a tracepoint on cfg80211, seems sufficient? johannes