Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v5 04/11] mt76: mt7915: allow processing TXS for 'NO_SKB'
 pkt-ids
To:     greearb@candelatech.com, linux-wireless@vger.kernel.org
References: <20210804134505.3208-1-greearb@candelatech.com>
 <20210804134505.3208-4-greearb@candelatech.com>
From:   Felix Fietkau <nbd@nbd.name>
Message-ID: <5b629ea2-d269-26af-f7a5-d389fa584555@nbd.name>
Date:   Fri, 13 Aug 2021 19:13:33 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20210804134505.3208-4-greearb@candelatech.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2021-08-04 15:44, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
> 
> This will let us update stats and wcid.rate for every TXS
> callback we receive for a particular wcid.
> 
> For now, the TXS is not requested for NO_SKB frames, however.
> That will be allowed in next patch.
> 
> Signed-off-by: Ben Greear <greearb@candelatech.com>
> ---
>  .../net/wireless/mediatek/mt76/mt7915/mac.c    | 18 +++++++++++++-----
>  1 file changed, 13 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c
> index 6f92e207680f..2228dad71657 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c
> @@ -1047,6 +1047,7 @@ void mt7915_mac_write_txwi(struct mt7915_dev *dev, __le32 *txwi,
>  	txwi[4] = 0;
>  
>  	val = FIELD_PREP(MT_TXD5_PID, pid);
> +	/* NOTE:  mt7916 does NOT request TXS for 'NO_SKB' frames by default. */
I think this comment can be dropped, given that you're adding extra
checks in the next patch that clarify this.
>  	if (pid >= MT_PACKET_ID_FIRST)
>  		val |= MT_TXD5_TX_STATUS_HOST;
>  	txwi[5] = cpu_to_le32(val);

- Felix