Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v5 05/11] mt76: mt7915: debugfs hook to enable TXS for
 NO_SKB pkt-ids
To:     greearb@candelatech.com, linux-wireless@vger.kernel.org
References: <20210804134505.3208-1-greearb@candelatech.com>
 <20210804134505.3208-5-greearb@candelatech.com>
From:   Felix Fietkau <nbd@nbd.name>
Message-ID: <02b63c52-9b34-b374-fa43-6e2148f3616d@nbd.name>
Date:   Fri, 13 Aug 2021 19:16:04 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20210804134505.3208-5-greearb@candelatech.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2021-08-04 15:44, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
> 
> This lets user turn on/off this feature.  Enabling gives better
> tx-rate related stats, but will cause extra driver and (maybe)
> firmware work.  Not sure if it actually affects performance or
> not.
> 
> Signed-off-by: Ben Greear <greearb@candelatech.com>
> ---
>  .../wireless/mediatek/mt76/mt7915/debugfs.c   | 24 +++++++++++++++++++
>  .../net/wireless/mediatek/mt76/mt7915/mac.c   |  3 ++-
>  .../wireless/mediatek/mt76/mt7915/mt7915.h    |  5 ++++
>  3 files changed, 31 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c b/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c
> index 91664ac63a8d..6be194f16548 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c
> @@ -344,6 +367,7 @@ int mt7915_init_debugfs(struct mt7915_dev *dev)
>  				    mt7915_queues_acq);
>  	debugfs_create_file("tx_stats", 0400, dir, dev, &mt7915_tx_stats_fops);
>  	debugfs_create_file("fw_debug", 0600, dir, dev, &fops_fw_debug);
> +	debugfs_create_file("txs_for_no_skb", 0600, dir, dev, &fops_txs_for_no_skb);
I think this is a rather confusing name. Maybe "force_txs"?

- Felix

-